Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Felipe Balbi
hy-fsl-usb.c | 2 +- for the drivers above: Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH 09/10] crypto: omap-aes: gcm: Add support for PIO mode

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 10:48:39AM +0530, Lokesh Vutla wrote: > Add support for PIO mode for GCM mode. > > Signed-off-by: Lokesh Vutla why do you require PIO ? Is there any situation where DMA can't be used? What would that case be ? -- balbi signature.asc Description: Digital signature

Re: [PATCH 07/10] crypto: omap-aes: gcm: Add support for unaligned lengths

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 10:48:37AM +0530, Lokesh Vutla wrote: > Check if the inputs are not aligned, if not process > the input before starting the hw acceleration. > Similarly after completition of hw acceleration. > > Signed-off-by: Lokesh Vutla and this ? -- balbi signature.asc Descriptio

Re: [PATCH 06/10] crypto: omap-aes: gcm: Handle inputs properly

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 10:48:36AM +0530, Lokesh Vutla wrote: > Its not necessary that assoc data and plain text is passed always. > Add these checks before processing the input. > > Signed-off-by: Lokesh Vutla why can't this be combined with patch which added GCM in the first place ? > --- >

Re: [PATCH 05/10] crypto: omap-aes: Add support for GCM mode

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 10:48:35AM +0530, Lokesh Vutla wrote: > OMAP AES hw supports aes gcm mode. here you refer to it as 'gcm' > Adding support for GCM mode in omap-aes driver. while here and in subject as 'GCM'. > Signed-off-by: Lokesh Vutla > --- > drivers/crypto/Makefile |3 +-

Re: [PATCH 04/10] crypto: omap-aes: Use BIT() macro

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 10:48:34AM +0530, Lokesh Vutla wrote: > Use BIT()/GENMASK() macros for all register definitions instead of > hand-writing bit masks. > > Signed-off-by: Lokesh Vutla > --- > drivers/crypto/omap-aes.c | 36 ++-- > 1 file changed, 18 inserti

Re: [PATCH 03/10] crypto: aead: Add aead_request_cast() api

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 10:48:33AM +0530, Lokesh Vutla wrote: > Add aead_request_cast() api to get pointer to aead_request > from cryto_async_request. > > Signed-off-by: Lokesh Vutla > --- > include/linux/crypto.h |6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/include/linux/c

Re: [PATCH 02/10] crypto: omap-aes: Fix configuring of AES mode

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 10:48:32AM +0530, Lokesh Vutla wrote: > AES_CTRL_REG is used to configure AES mode. Before configuring > any mode we need to make sure all other modes are reset or else > driver will misbehave. So mask all modes before configuring > any AES mode. > > Signed-off-by: Lokesh V

Re: [PATCH 01/10] crypto: omap-aes: Add support for lengths not aligned with AES_BLOCK_SIZE

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 10:48:31AM +0530, Lokesh Vutla wrote: > OMAP AES driver returns an error if the data is not aligned with > AES_BLOCK_SIZE bytes. > But OMAP AES hw allows data input upto 1 byte aligned, but still > zeros are to be appended and complete AES_BLOCK_SIZE has to be written. > And

Re: [PATCH V2] crypto: omap-des - handle error of pm_runtime_get_sync

2014-04-15 Thread Felipe Balbi
On Tue, Apr 15, 2014 at 11:58:31AM -0500, Nishanth Menon wrote: > pm_runtime_get_sync may not always succeed depending on SoC involved. > So handle the error appropriately ensuring usage_count is accurate in > case of failure. > > Signed-off-by: Nishanth Menon Reviewed-b

Re: [PATCH] crypto: omap-des - handle error of pm_runtime_get_sync

2014-04-15 Thread Felipe Balbi
Hi, On Tue, Apr 15, 2014 at 10:33:02AM -0500, Nishanth Menon wrote: > pm_runtime_get_sync may not always succeed depending on SoC involved. So > handle the error appropriately. > > Reported-by: Joachim Eastwood > Signed-off-by: Nishanth Menon > --- > > based on v3.15-rc1 > > Report-thread: ht

Re: [PATCH 42/51] DMA-API: usb: musb: use platform_device_register_full() to avoid directly messing with dma masks

2013-09-20 Thread Felipe Balbi
Hi, On Fri, Sep 20, 2013 at 02:49:38PM +0100, Russell King - ARM Linux wrote: > On Fri, Sep 20, 2013 at 08:11:25AM -0500, Felipe Balbi wrote: > > Hi, > > > > On Fri, Sep 20, 2013 at 12:14:38AM +0100, Russell King wrote: > > > Use platform_device_register_full() f

Re: [PATCH 42/51] DMA-API: usb: musb: use platform_device_register_full() to avoid directly messing with dma masks

2013-09-20 Thread Felipe Balbi
m within its callbacks, which may be called during the musb > device probing. > > Signed-off-by: Russell King you want me to carry this one through my tree or you prefer getting my Acked-by ? Either way works for me: Acked-by: Felipe Balbi there's also the third option of me set

Re: [PATCH 20/39] usb: musb: ux500: move channel number knowledge into the driver

2013-05-30 Thread Felipe Balbi
HI On Thu, May 30, 2013 at 09:12:11AM +0100, Lee Jones wrote: > On Thu, 30 May 2013, Linus Walleij wrote: > > > On Wed, May 29, 2013 at 7:57 PM, Felipe Balbi wrote: > > > On Wed, May 15, 2013 at 10:51:43AM +0100, Lee Jones wrote: > > >> For all ux500 based pl

Re: [PATCH 20/39] usb: musb: ux500: move channel number knowledge into the driver

2013-05-29 Thread Felipe Balbi
gt; and will aid us when we come to enable the driver for Device Tree. > > Cc: Felipe Balbi > Cc: linux-...@vger.kernel.org > Acked-by: Linus Walleij > Acked-by: Fabio Baltieri > Signed-off-by: Lee Jones for drivers/usb/musb Acked-by: Felipe Balbi -- balbi signature.asc Description: Digital signature

Re: [PATCH 20/39] usb: musb: ux500: move channel number knowledge into the driver

2013-05-28 Thread Felipe Balbi
> > platform data. This also removes quite a bit of complexity from the driver > > and will aid us when we come to enable the driver for Device Tree. > > > > Cc: Felipe Balbi > > Cc: linux-...@vger.kernel.org > > Acked-by: Linus Walleij > > Acked-by: Fab

Re: [PATCH 2/5] omap-aes: DMA initialization fixes for OMAP off mode

2010-11-10 Thread Felipe Balbi
Hi, On Wed, 2010-11-10 at 19:26 +0200, Dmitry Kasatkin wrote: > diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c > index 9d65611..04cab70 100644 > --- a/drivers/crypto/omap-aes.c > +++ b/drivers/crypto/omap-aes.c > @@ -99,7 +99,7 @@ struct omap_aes_reqctx { > struct omap_aes_dev

Re: [PATCH 1/2] sec: omap sha1 & md5 driver

2010-03-17 Thread Felipe Balbi
On Wed, Mar 17, 2010 at 03:12:50PM +0200, Dmitry Kasatkin wrote: > Earlier kernel contained omap sha1 and md5 driver, which was not maintained, > was not ported to new crypto APIs and removed from the source tree. > > This driver implements async and sync crypto API. > > Signed-off-by: Dmitry Kas

Re: Crypto API Weirdnesses

2007-07-31 Thread Felipe Balbi
On 7/31/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: > Hi, > > > On Tue, 31 Jul 2007, Felipe Balbi wrote: > > > On 7/31/07, Akinobu Mita <[EMAIL PROTECTED]> wrote: > > > > > "Failed to setup dm-crypt key mapping. > > > > > C

Re: Crypto API Weirdnesses

2007-07-31 Thread Felipe Balbi
enu and not in "Cryptographic Options"? > > We should improve cryptsetup error message. > -- Best Regards, Felipe Balbi [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html