> Tested-by: Fabien Dessenne
Tested-by: Fabien Dessenne
> ---
> crypto/crypto_engine.c | 301
> ++--
> include/crypto/engine.h | 68 ++-
> 2 files changed, 203 insertions(+), 166 deletions(-)
>
> diff --g
This patchset depends on "crypto: engine - Permit to enqueue all async requests"
proposed by Corentin Labbe [https://lkml.org/lkml/2018/1/26/608].
stm32-cryp uses this updated crpyto engine to handle AEAD cipher algortihms.
Fabien Dessenne (2):
crypto: stm32/cryp - add aes gcm / c
Add AEAD cipher algorithms for aes gcm and ccm.
Signed-off-by: Fabien Dessenne
---
drivers/crypto/stm32/stm32-cryp.c | 931 --
1 file changed, 902 insertions(+), 29 deletions(-)
diff --git a/drivers/crypto/stm32/stm32-cryp.c
b/drivers/crypto/stm32/stm32
stm32mp1 differs from stm32f7 in the way it handles byte ordering and
padding for aes gcm & ccm algo.
Signed-off-by: Fabien Dessenne
---
drivers/crypto/stm32/stm32-cryp.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/crypto/stm32/stm32-cryp.c
b/drivers/crypto/stm32/s
Hi,
Thank you for the patch.
On 17/01/18 12:40, Wei Yongjun wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun
Reviewed-by: Fabien Dessenne
> ---
>
(Adding my tested by)
On 10/01/18 15:25, Fabien DESSENNE wrote:
>
> On 03/01/18 21:11, Corentin Labbe wrote:
>> This patch convert the stm32-cryp driver to the new crypto engine API.
>> Signed-off-by: Corentin Labbe
Tested-by: Fabien Dessenne
>> ---
>>dri
(adding my tested by)
On 10/01/18 15:19, Fabien DESSENNE wrote:
> On 03/01/18 21:11, Corentin Labbe wrote:
>> The crypto engine could actually only enqueue hash and ablkcipher request.
>> This patch permit it to enqueue any type of crypto_async_request.
>>
>> Si
(adding my tested my)
On 10/01/18 15:24, Fabien DESSENNE wrote:
>
> On 03/01/18 21:11, Corentin Labbe wrote:
>> This patch convert the stm32-hash driver to the new crypto engine API.
>>
>> Signed-off-by: Corentin Labbe
Tested-by: Fabien Dessenne
>> ---
>>
On 03/01/18 21:11, Corentin Labbe wrote:
> This patch convert the stm32-cryp driver to the new crypto engine API.
> Signed-off-by: Corentin Labbe
> ---
> drivers/crypto/stm32/stm32-cryp.c | 21 -
> 1 file changed, 16 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/c
On 03/01/18 21:11, Corentin Labbe wrote:
> This patch convert the stm32-hash driver to the new crypto engine API.
>
> Signed-off-by: Corentin Labbe
> ---
> drivers/crypto/stm32/stm32-hash.c | 18 +-
> 1 file changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/cr
On 03/01/18 21:11, Corentin Labbe wrote:
> The crypto engine could actually only enqueue hash and ablkcipher request.
> This patch permit it to enqueue any type of crypto_async_request.
>
> Signed-off-by: Corentin Labbe
> ---
> crypto/crypto_engine.c | 230
> --
Hi Corentin,
Thank you for this new version which I have testes successfully with the
stm32 hash & cryp drivers.
As a general comment on this patchset, I would say that it does not
cover all async requests: typically I need (for the pending stm32 cryp
driver uprade) to use CryptoEngine to pro
entin Labbe
Reviewed-by: Fabien Dessenne
> ---
> drivers/crypto/stm32/Kconfig | 6 +++---
> drivers/crypto/stm32/Makefile | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/crypto/stm32/Kconfig b/drivers/crypto/stm32/Kconfig
> index
Hi Arnd,
This issue was reported a few days ago, and Herbert applied the patch 2
minutes before you send the mail (see
[https://www.mail-archive.com/linux-crypto@vger.kernel.org/msg29762.html]).
Anyway, thank you for reporting this.
Fabien
On 11/12/17 12:47, Arnd Bergmann wrote:
> Building t
Hi,
On 29/11/17 09:41, Corentin Labbe wrote:
> This patch convert the driver to the new crypto engine API.
>
> Signed-off-by: Corentin Labbe
Tested-by: Fabien Dessenne
> ---
> drivers/crypto/stm32/stm32-hash.c | 22 +++---
> 1 file changed, 15 insertio
On 29/11/17 09:41, Corentin Labbe wrote:
> The crypto engine could actually only enqueue hash and ablkcipher request.
> This patch permit it to enqueue any type of crypto_async_request.
>
> Signed-off-by: Corentin Labbe
> ---
> crypto/crypto_engine.c | 188
> +++--
Hi Corentin,
I am fine with this proposal: it is generic enough and I have been able
to test and run the crypto engine with aead_request without changing any
single line of code.
This is what I need to be able to send the AEAD extension of the
stm32-cryp driver (successfully tested with your
49:25: error: 'sti_dt_ids' undeclared
> here (not in a function)
> MODULE_DEVICE_TABLE(of, sti_dt_ids);
>
> Let's replace sti_dt_ids with stm32_dt_ids which is just declared
> before.
>
> Signed-off-by: Corentin Labbe
Reviewed-by: Fabien Dessenne
> ---
>
Just a gentle ping ... or have I missed out on a reply?
On 13/11/17 11:30, Fabien DESSENNE wrote:
> Hi Herbert,
>
> Can you check if this patchset (removed the AEAD part as you suggested +
> libkcapi test OK as suggested by Corentin) can be applied now?
>
> BR
>
> Fabien
Hi Herbert,
Can you check if this patchset (removed the AEAD part as you suggested +
libkcapi test OK as suggested by Corentin) can be applied now?
BR
Fabien
On 07/11/17 15:40, Fabien DESSENNE wrote:
>
> On 22/10/17 09:26, Corentin Labbe wrote:
>> On Thu, Oct 19, 2017 at 05:1
On 22/10/17 09:26, Corentin Labbe wrote:
> On Thu, Oct 19, 2017 at 05:10:30PM +0200, Fabien Dessenne wrote:
>> This module registers block cipher algorithms that make use of the
>> STMicroelectronics STM32 crypto "CRYP1" hardware.
>> The following algorithms ar
This module registers block cipher algorithms that make use of the
STMicroelectronics STM32 crypto "CRYP1" hardware.
The following algorithms are supported:
- aes: ecb, cbc, ctr
- des: ecb, cbc
- tdes: ecb, cbc
Signed-off-by: Fabien Dessenne
---
drivers/crypto/stm32/Kconfig
Document device tree bindings for the STM32 CRYP.
Signed-off-by: Fabien Dessenne
Acked-by: Rob Herring
---
.../devicetree/bindings/crypto/st,stm32-cryp.txt | 19 +++
1 file changed, 19 insertions(+)
create mode 100644 Documentation/devicetree/bindings/crypto/st,stm32
CCM algorithms
Changes since v3:
- update dt-bindings with Rob Herring remarks
Changes since v2:
- update dt-bindings (interrupts description)
- rebase on STM32 crypto patches (L. Debieve : update CRC32 + add HASH)
Fabien Dessenne (2):
dt-bindings: Document STM32 CRYP bindings
crypto: s
Fabien
On 19/10/17 12:34, Corentin Labbe wrote:
> Hello
>
> I have some minor comment below
>
> On Thu, Oct 19, 2017 at 11:03:59AM +0200, Fabien Dessenne wrote:
>> This module registers block cipher algorithms that make use of the
>> STMicroelectronics STM32 crypto "C
Document device tree bindings for the STM32 CRYP.
Signed-off-by: Fabien Dessenne
Acked-by: Rob Herring
---
.../devicetree/bindings/crypto/st,stm32-cryp.txt | 19 +++
1 file changed, 19 insertions(+)
create mode 100644 Documentation/devicetree/bindings/crypto/st,stm32
This module registers block cipher algorithms that make use of the
STMicroelectronics STM32 crypto "CRYP1" hardware.
The following algorithms are supported:
- aes: ecb, cbc, ctr
- des: ecb, cbc
- tdes: ecb, cbc
Signed-off-by: Fabien Dessenne
---
drivers/crypto/stm32/Kconfig
upts description)
- rebase on STM32 crypto patches (L. Debieve : update CRC32 + add HASH)
Fabien Dessenne (3):
crypto: engine - permit to enqueue aead_request
dt-bindings: Document STM32 CRYP bindings
crypto: stm32 - Support for STM32 CRYP crypto module
Fabien Dessenne (2):
dt-bindings: Docu
OK, I will send an initial version without the AEAD part.
On 05/10/17 05:39, Herbert Xu wrote:
> On Tue, Oct 03, 2017 at 07:48:08AM +0000, Fabien DESSENNE wrote:
>> It looks like there is no more activity around this "crypto_engine
>> interface clean up" task.
>&
On 22/09/17 11:09, Herbert Xu wrote:
> On Fri, Aug 18, 2017 at 11:19:04AM +0200, Fabien Dessenne wrote:
>> The current crypto engine allows ablkcipher_request and ahash_request to
>> be enqueued. Extend this to aead_request.
>>
>> Signed-off-by: Fabien Dessenne
> I&#
Just a gentle ping ... or have I missed out on a reply?
On 18/08/17 11:19, Fabien Dessenne wrote:
> This set of patches adds a new crypto driver for STMicroelectronics stm32 HW.
> This drivers uses the crypto API and provides with HW-enabled AEAD and block
> cipher algorithms.
> It
This module registers block and AEAD cipher algorithms that make use of
the STMicroelectronics STM32 crypto "CRYP1" hardware.
The following algorithms are supported:
- aes: ecb, cbc, ctr, gcm, ccm
- des: ecb, cbc
- tdes: ecb, cbc
Signed-off-by: Fabien Dessenne
---
drivers/crypto/stm
Document device tree bindings for the STM32 CRYP.
Signed-off-by: Fabien Dessenne
Acked-by: Rob Herring
---
.../devicetree/bindings/crypto/st,stm32-cryp.txt | 19 +++
1 file changed, 19 insertions(+)
create mode 100644 Documentation/devicetree/bindings/crypto/st,stm32
The current crypto engine allows ablkcipher_request and ahash_request to
be enqueued. Extend this to aead_request.
Signed-off-by: Fabien Dessenne
---
crypto/crypto_engine.c | 101
include/crypto/engine.h | 16
2 files changed, 117
with tcrypt / testmgr.
Changes since v3:
- update dt-bindings with Rob Herring remarks
Changes since v2:
- update dt-bindings (interrupts description)
- rebase on STM32 crypto patches (L. Debieve : update CRC32 + add HASH)
Fabien Dessenne (3):
crypto: engine - permit to enqueue aead_request
Hi Corentin,
Since I have just sent a patch to add the support of "aead_request" to crypto
engine, I am wondering if your proposed change (checking cra_type instead of
crypto_tfm_alg_type) and mine are compatible.
It looks like they are (assuming we export crypto_aead_type): can you confirm?
BR
The current crypto engine allows ablkcipher_request and ahash_request to
be enqueued. Extend this to aead_request.
Signed-off-by: Fabien Dessenne
---
crypto/crypto_engine.c | 101
include/crypto/engine.h | 16
2 files changed, 117
This module registers block and AEAD cipher algorithms that make use of
the STMicroelectronics STM32 crypto "CRYP1" hardware.
The following algorithms are supported:
- aes: ecb, cbc, ctr, gcm, ccm
- des: ecb, cbc
- tdes: ecb, cbc
Signed-off-by: Fabien Dessenne
---
drivers/crypto/stm
Document device tree bindings for the STM32 CRYP.
Signed-off-by: Fabien Dessenne
---
.../devicetree/bindings/crypto/st,stm32-cryp.txt | 20
1 file changed, 20 insertions(+)
create mode 100644 Documentation/devicetree/bindings/crypto/st,stm32-cryp.txt
diff --git a
with tcrypt / testmgr.
Changes since v2:
- update dt-bindings (interrupts description)
- rebase on STM32 crypto patches (L. Debieve : update CRC32 + add HASH)
Fabien Dessenne (3):
crypto: engine - permit to enqueue aead_request
dt-bindings: Document STM32 CRYP bindings
crypto: stm32
This module registers block and AEAD cipher algorithms that make use of
the STMicroelectronics STM32 crypto "CRYP1" hardware.
The following algorithms are supported:
- aes: ecb, cbc, ctr, gcm, ccm
- des: ecb, cbc
- tdes: ecb, cbc
Signed-off-by: Fabien Dessenne
---
drivers/crypto/stm
Document device tree bindings for the STM32 CRYP.
Signed-off-by: Fabien Dessenne
---
.../devicetree/bindings/crypto/st,stm32-cryp.txt | 20
1 file changed, 20 insertions(+)
create mode 100644 Documentation/devicetree/bindings/crypto/st,stm32-cryp.txt
diff --git a
The current crypto engine allows ablkcipher_request and ahash_request to
be enqueued. Extend this to aead_request.
Signed-off-by: Fabien Dessenne
---
crypto/crypto_engine.c | 101
include/crypto/engine.h | 16
2 files changed, 117
with tcrypt / testmgr.
Note:
Since two other set of patches (update of STM32 CRC32 and addition of STM32
HASH) are being proposed, it may happen that there are some minor conflicts in
'Kconfig' and 'Makefile'. In that case, I will fix the issue in due course.
Fabien Dessenne (
list.lock);
>
> - ret = crypto_register_shashes(algs, ARRAY_SIZE(algs));
> + /* For F4 series only CRC32 algorithm will be used */
> + if (of_device_is_compatible(crc->dev->of_node, "st,stm32f4-crc"))
> + algs_size = 1;
> + else
> + algs_size = ARRAY_SIZE(algs);
> +
> + ret = crypto_register_shashes(algs, algs_size);
> if (ret) {
> dev_err(dev, "Failed to register\n");
> clk_disable_unprepare(crc->clk);
> @@ -304,6 +351,7 @@ static int stm32_crc_remove(struct platform_device *pdev)
>
> static const struct of_device_id stm32_dt_ids[] = {
> { .compatible = "st,stm32f7-crc", },
> + { .compatible = "st,stm32f4-crc", },
> {},
> };
> MODULE_DEVICE_TABLE(of, stm32_dt_ids);
Reviewed-by: Fabien Dessenne
On 24/03/17 05:28, PrasannaKumar Muralidharan wrote:
> On 21 March 2017 at 20:43, Fabien Dessenne wrote:
>> This module registers a CRC32 ("Ethernet") and a CRC32C (Castagnoli)
>> algorithm that make use of the STMicroelectronics STM32 crypto hardware.
>>
>>
Add STM32 crypto support in stm32_defconfig file.
Signed-off-by: Fabien Dessenne
---
arch/arm/configs/stm32_defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/configs/stm32_defconfig b/arch/arm/configs/stm32_defconfig
index a9d8e3c..03437f8 100644
--- a/arch/arm/configs
Add CRC (CRC32 crypto) support to stm32f746.
Signed-off-by: Fabien Dessenne
---
arch/arm/boot/dts/stm32f746.dtsi | 7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/stm32f746.dtsi b/arch/arm/boot/dts/stm32f746.dtsi
index f321ffe..755fb92 100644
--- a/arch/arm/boot/dts
Enable the CRC (CRC32 crypto) on stm32746g-eval board
Signed-off-by: Fabien Dessenne
---
arch/arm/boot/dts/stm32746g-eval.dts | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/stm32746g-eval.dts
b/arch/arm/boot/dts/stm32746g-eval.dts
index aa03fac..0dc18a0 100644
--- a
ed with ~0.
Using TCRYPT CRC32C speed test, this shows up to 900% speedup compared
to the crc32c-generic algorithm.
Signed-off-by: Fabien Dessenne
---
drivers/crypto/Kconfig | 2 +
drivers/crypto/Makefile| 1 +
drivers/crypto/stm32/Kconfig | 8 +
drivers/cr
Document device tree bindings for the STM32 CRC (crypto CRC32)
Signed-off-by: Fabien Dessenne
---
.../devicetree/bindings/crypto/st,stm32-crc.txt | 16
1 file changed, 16 insertions(+)
create mode 100644 Documentation/devicetree/bindings/crypto/st,stm32-crc.txt
diff
clk
- enable crypto in stm32 defconfig
- typo fix in dt-bindings
Fabien Dessenne (5):
dt-bindings: Document STM32 CRC bindings
crypto: stm32 - Support for STM32 CRC32 crypto module
ARM: dts: stm32: Add CRC support to stm32f746
ARM: dts: stm32: enable CRC on stm32746g-eval board
ARM: configs: st
Enable the CRC (CRC32 crypto) on stm32746g-eval board
Signed-off-by: Fabien Dessenne
---
arch/arm/boot/dts/stm32746g-eval.dts | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/stm32746g-eval.dts
b/arch/arm/boot/dts/stm32746g-eval.dts
index aa03fac..0dc18a0 100644
--- a
Document device tree bindings for the STM32 CRC (crypto CRC32)
Signed-off-by: Fabien Dessenne
---
.../devicetree/bindings/crypto/st,stm32-crc.txt | 16
1 file changed, 16 insertions(+)
create mode 100644 Documentation/devicetree/bindings/crypto/st,stm32-crc.txt
diff
ed with ~0.
Using TCRYPT CRC32C speed test, this shows up to 900% speedup compared
to the crc32c-generic algorithm.
Signed-off-by: Fabien Dessenne
---
drivers/crypto/Kconfig | 2 +
drivers/crypto/Makefile| 1 +
drivers/crypto/stm32/Kconfig | 8 +
drivers/cr
This set of patches adds a new crypto driver for STMicroelectronics stm32f746.
The drivers uses the crypto API and provides with an HW-enabled CRC32 algorithm.
It was developed and tested (tcrypt / testmgr) on evaluation board stm32746g.
Fabien Dessenne (4):
dt-bindings: Document STM32 CRC
Add CRC (CRC32 crypto) support to stm32f746.
Signed-off-by: Fabien Dessenne
---
arch/arm/boot/dts/stm32f746.dtsi | 7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/stm32f746.dtsi b/arch/arm/boot/dts/stm32f746.dtsi
index f321ffe..755fb92 100644
--- a/arch/arm/boot/dts
Add missing " " in api-samples.rst
Signed-off-by: Fabien Dessenne
---
Documentation/crypto/api-samples.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/crypto/api-samples.rst
b/Documentation/crypto/api-samples.rst
index 0a10819..d021fd9 10
58 matches
Mail list logo
