[PATCH] arm64 sha2-ce finup: correct digest for empty data

2019-05-28 Thread Elena Petrova
round. However, in sha256_base_do_update, the block function will not be called when len == 0. Fix it by setting finalize to 0 if data is empty. Fixes: 03802f6a80b3a ("crypto: arm64/sha2-ce - move SHA-224/256 ARMv8 implementation to base layer") Cc: sta...@vger.kernel.org Signed-off

Re: [PATCH] arm64 sha1-ce finup: correct digest for empty data

2019-05-28 Thread Elena Petrova
Yep, sha2 also has the bug, I'll be sending the fix soon, thanks! On Tue, 28 May 2019 at 14:03, Ard Biesheuvel wrote: > > On Tue, 28 May 2019 at 14:42, Elena Petrova wrote: > > > > The sha1-ce finup implementation for ARM64 produces wrong digest > > for empty inpu

[PATCH] arm64 sha1-ce finup: correct digest for empty data

2019-05-28 Thread Elena Petrova
final round. However, in sha1_base_do_update, the block function will not be called when len == 0. Fix it by setting finalize to 0 if data is empty. Fixes: 07eb54d306f4 ("crypto: arm64/sha1-ce - move SHA-1 ARMv8 implementation to base layer") Cc: sta...@vger.kernel.org Signed-off-by: Ele