Re: [PATCH v2] crypto: Fix divide error in do_xor_speed()

2021-01-05 Thread Doug Anderson
Hi, On Wed, Dec 30, 2020 at 1:34 PM Kirill Tkhai wrote: > > crypto: Fix divide error in do_xor_speed() > > From: Kirill Tkhai > > Latest (but not only latest) linux-next panics with divide > error on my QEMU setup. > > The patch at the bottom of this message fixes the problem. > > xor: measuring

Re: [PATCH] crypto: xor - Remove unused variable count in do_xor_speed

2020-10-06 Thread Doug Anderson
Hi, On Tue, Oct 6, 2020 at 12:59 PM Nathan Chancellor wrote: > > Clang warns: > > crypto/xor.c:101:4: warning: variable 'count' is uninitialized when used > here [-Wuninitialized] > count++; > ^ > crypto/xor.c:86:17: note: initialize the variabl

Re: [PATCH v2 2/2] crypto: xor - use ktime for template benchmarking

2020-09-28 Thread Doug Anderson
Hi, On Sat, Sep 26, 2020 at 3:27 AM Ard Biesheuvel wrote: > > Currently, we use the jiffies counter as a time source, by staring at > it until a HZ period elapses, and then staring at it again and perform > as many XOR operations as we can at the same time until another HZ > period elapses, so th

Re: [PATCH 2/2] crypto: xor - use ktime for template benchmarking

2020-09-24 Thread Doug Anderson
Hi, On Thu, Sep 24, 2020 at 11:40 AM Ard Biesheuvel wrote: > > On Thu, 24 Sep 2020 at 20:22, Doug Anderson wrote: > > > > Hi, > > > > On Thu, Sep 24, 2020 at 8:36 AM Ard Biesheuvel wrote: > > > > > > On Thu, 24 Sep 2020 at 17:28, Doug Anderson

Re: [PATCH 2/2] crypto: xor - use ktime for template benchmarking

2020-09-24 Thread Doug Anderson
Hi, On Thu, Sep 24, 2020 at 8:36 AM Ard Biesheuvel wrote: > > On Thu, 24 Sep 2020 at 17:28, Doug Anderson wrote: > > > > On Thu, Sep 24, 2020 at 1:32 AM Ard Biesheuvel wrote: > > > > ... > > > > > +#define REPS 100 > > > >

Re: [PATCH 2/2] crypto: xor - use ktime for template benchmarking

2020-09-24 Thread Doug Anderson
Hi, On Thu, Sep 24, 2020 at 1:32 AM Ard Biesheuvel wrote: > > On Thu, 24 Sep 2020 at 02:36, Doug Anderson wrote: > > > > Hi, > > > > On Wed, Sep 23, 2020 at 11:22 AM Ard Biesheuvel wrote: > > > > > > Currently, we use the jiffies counter as

Re: [PATCH 1/2] crypto: xor - defer load time benchmark to a later time

2020-09-23 Thread Doug Anderson
Hi, On Wed, Sep 23, 2020 at 11:22 AM Ard Biesheuvel wrote: > > Currently, the XOR module performs its boot time benchmark at core > initcall time when it is built-in, to ensure that the RAID code can > make use of it when it is built-in as well. > > Let's defer this to a later stage during the bo

Re: [PATCH 2/2] crypto: xor - use ktime for template benchmarking

2020-09-23 Thread Doug Anderson
Hi, On Wed, Sep 23, 2020 at 11:22 AM Ard Biesheuvel wrote: > > Currently, we use the jiffies counter as a time source, by staring at > it until a HZ period elapses, and then staring at it again and perform > as many XOR operations as we can at the same time until another HZ > period elapses, so t