Hi Herbert,
I've tried the following builds and both fail:
make mrproper
make defconfig
make drivers/crypto/qat/qat_common/qat_asym_algs.o
drivers/crypto/qat/qat_common/qat_asym_algs.c:55:32: fatal error:
qat_rsapubkey-asn1.h: No such file or directory
#include "qat_rsapubkey-asn1.h"
mak
t; Signed-off-by: Tudor Ambarus
Acked-by: Cristian Stoica
> ---
> crypto/rsa.c | 15
> crypto/rsa_helper.c | 182
> ++
> include/crypto/internal/rsa.h | 28 +++
> 3 files changed, 210 insertions(+), 1
MPI or raw integer keys), followed by a key representation
> structure (for MPI or raw integers).
>
> This approach has the advantage that users can select specific parser actions
> by using a general parser with function pointers to specific actions.
>
> Signed-off-by: Tudor Ambar
> It will be used by caam driver to remove the leading zeros of RSA's algorithm
> output.
>
> Signed-off-by: Tudor Ambarus
Acked-by: Cristian Stoica
> ---
> crypto/scatterwalk.c | 26 ++
> include/crypto/scatterwalk.h | 2 ++
ernel.org;
> smuel...@chronox.de; Horia Ioan Geanta Neag ;
> Tudor-Dan Ambarus
> Subject: [PATCH v2 2/3] crypto: scatterwalk - export scatterwalk_pagedone
>
> Used in caam driver. Export the symbol since the caam driver can be built as a
> module.
>
> Signed-off-by:
ernel.org;
> smuel...@chronox.de; Horia Ioan Geanta Neag ;
> Tudor-Dan Ambarus
> Subject: [PATCH v2 3/3] crypto: caam - add support for RSA algorithm
>
> Add RSA support to caam driver.
>
> Coauthored-by: Yashpal Dutta
>
> Signed-off-by: Tudor Ambarus
Acked-by: Cristian
.kernel.org; smuel...@chronox.de; Horia Ioan Geanta
> Neag ; Tudor-Dan Ambarus dan.amba...@nxp.com>
> Subject: [PATCH v2 3/4] crypto: add CONFIG_ symbol for rsa helper
>
> All RSA implementations can now use the key extract symbols by selecting
> CRYPTO_RSA_HELPER.
>
> Signed-
aam and qat drivers.
>
> Signed-off-by: Tudor Ambarus
Acked-by: Cristian Stoica
> ---
> crypto/rsa_helper.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/crypto/rsa_helper.c b/crypto/rsa_helper.c index df1f480..d81a0ec
> 100644
> --- a/crypto/rsa_he
Hi Tadeusz,
>> SSL/TLS is prone to this implementation issue and many user-space libraries
>> got this wrong. It would be good to see >>some numbers to back-up the claim
>> of timing differences as not being an issue for this one.
>It is hard to get the implementation right when the protocol de
mentation issue and many user-space libraries got
this wrong. It would be good to see some numbers to back-up the claim of timing
differences as not being an issue for this one.
Cristian S.
From: Tadeusz Struk
Sent: Monday, March 7, 2016 4:31 PM
To:
Hi Tadeusz,
+static int crypto_encauth_dgst_verify(struct aead_request *req,
+ unsigned int flags)
+{
+ struct crypto_aead *tfm = crypto_aead_reqtfm(req);
+ unsigned int authsize = crypto_aead_authsize(tfm);
+ struct aead_instance *inst = aead
On 03/04/2015 08:34 PM, Kim Phillips wrote:
> I don't see how, e.g., for one, dma_map_sg is I/O TLB
> implementation-dependent.
I'll need some remedial classes on this topic, but for the moment I
don't see how this matters for mapping sg chains. Can you share some
pointers?
Thanks,
Cristian S.
Hi Yanjiang,
On 03/04/2015 04:32 AM, yjin wrote:
>
> On 2015年03月04日 02:59, Kim Phillips wrote:
>> On Tue, 3 Mar 2015 14:50:51 +0800
>> wrote:
>>
>>> This commit is to avoid the below warnings:
>>>
>>> drivers/crypto/caam/sg_sw_sec4.h:88:12: warning:
>>> 'dma_map_sg_chained' defined but not used
Hi Yanjiang,
On 03/04/2015 04:32 AM, yjin wrote:
>
> On 2015年03月04日 02:59, Kim Phillips wrote:
>> On Tue, 3 Mar 2015 14:50:51 +0800
>> wrote:
>>
>>> This commit is to avoid the below warnings:
>>>
>>> drivers/crypto/caam/sg_sw_sec4.h:88:12: warning:
>>> 'dma_map_sg_chained' defined but not used [
On 03/04/2015 06:57 AM, yjin wrote:
> An alternative is moving the definitions to a ".c" file, but I don't
> think it will be fundamental different.
> I know I am fixing a potential error which doesn't exist now, it seems
> useless for the current upstream version, we can abandon my patch. But I
>
Hi Herbert,
On 02/27/2015 11:25 AM, Herbert Xu wrote:
> On Tue, Feb 03, 2015 at 03:59:48PM +0200, Cristian Stoica wrote:
>> test_aead_speed is written for sync algorithms without specifically
[...]
> Please fix it to test asynchronously instead.
Thanks for review.
I think that a f
test_aead_speed is written for sync algorithms without specifically
requiring them. The effect is that an async algorithm may be used without
setting up the request callback, this leading to a kernel panic.
Signed-off-by: Cristian Stoica
---
crypto/tcrypt.c | 3 ++-
1 file changed, 2 insertions
See also: 9bac019dad8098a77cce555d929f678e22111783
Signed-off-by: Cristian Stoica
---
crypto/tcrypt.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
index 2b2486a..4b9e23f 100644
--- a/crypto/tcrypt.c
+++ b/crypto/tcrypt.c
The working copy of IV is the same size as the transformation's IV.
It is not necessary to copy more than that from the template since
iv_len is usually less than MAX_IVLEN and the rest of the copied data
is garbage.
Signed-off-by: Cristian Stoica
---
crypto/testmgr.c | 7 ---
1
the first 'if' is never executed.
- Rearrange the second part of the code to remove the conditional from
the loop
Signed-off-by: Cristian Stoica
---
crypto/tcrypt.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/crypto/tcrypt.c b/crypto/tcry
Signed-off-by: Cristian Stoica
---
drivers/crypto/caam/jr.c | 31 ++-
1 file changed, 22 insertions(+), 9 deletions(-)
diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c
index bce2959..b8b5d47 100644
--- a/drivers/crypto/caam/jr.c
+++ b/drivers/crypto
irq_dispose_mapping is not called on all error paths from caam_jr_init.
This takes care of several clean-up issues by performing resource
clean-up and allocation at the same level.
Signed-off-by: Cristian Stoica
---
drivers/crypto/caam/jr.c | 6 +++---
1 file changed, 3 insertions(+), 3
Signed-off-by: Cristian Stoica
---
drivers/crypto/caam/ctrl.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
index 70f1e6f..efba4cc 100644
--- a/drivers/crypto/caam/ctrl.c
+++ b/drivers/crypto/caam/ctrl.c
- assoc_nents and src_nents are never zero when all_contig is false
- iv_contig is zero on the else branch
Signed-off-by: Cristian Stoica
Reviewed-by: Richard Schmitt
---
drivers/crypto/caam/caamalg.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers
Hi Kim,
On 01/20/2015 08:43 PM, Kim Phillips wrote:
> ICV check failures are part of normal operation;
> leave user notification up to the higher levels,
> as is done in s/w algorithm implementations.
>
Tested on P4080DS.
Tested-by: Cristian Stoica
Thanks,
Cristian S.
--
To unsu
Modify crypto drivers to use the generic SG helper since
both of them are equivalent and the one from crypto is redundant.
See also:
468577abe37ff7b453a9ac613e0ea155349203ae reverted in
b2ab4a57b018aafbba35bff088218f5cc3d2142e
Signed-off-by: Cristian Stoica
---
crypto/ablkcipher.c
On 01/20/2015 05:35 AM, Herbert Xu wrote:
> No, I'm not going to create spam in everybody's dmesg just so that
> you can make sense of the spam coming from one driver.
Indeed, I found that it makes things far worse for the rest of the
drivers and the clarity improvement is questionable.
It was a b
them as harmless.
Signed-off-by: Cristian Stoica
---
crypto/testmgr.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index 235b1ff..ec19e98 100644
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -573,9 +573,11 @@ static int
Hi Kim, Herbert,
On 11/05/2014 06:43 PM, Kim Phillips wrote:
> On Wed, 5 Nov 2014 11:21:24 +0200
> Cristian Stoica wrote:
>
>> The error code returned by hardware is four bits wide with an expected
>> zero MSB. A hardware error condition where the error code can get betwee
Hi Kim,
On 11/04/2014 06:57 PM, Kim Phillips wrote:
> On Tue, 4 Nov 2014 10:57:57 +0200
> Cristian Stoica wrote:
>> Do you want me to drop the patch and pretend there is nothing to see?
>
> no, fixing potential bugs preemptively is fine; I'd just like to
> know that&#
reports the condition.
Signed-off-by: Cristian Stoica
---
drivers/crypto/caam/error.c | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers/crypto/caam/error.c b/drivers/crypto/caam/error.c
index 6531054..66d73bf 100644
--- a/drivers/crypto/caam
Hi Kim,
>> Actually, our static code analyzer did not see this one.
>
> ok, so the patch technically isn't fixing anything broken, then.
Are you saying the code isn't broken _because_ a static tool analyser
did not see anything wrong here?
> the new code just added a new condition, which doesn
Hi Kim,
On 10/31/2014 08:22 PM, Kim Phillips wrote:
> On Fri, 31 Oct 2014 18:57:33 +0200
> Cristian Stoica wrote:
>
> If this issue was brought up by h/w, the appropriate new error codes
> should be being introduced.
If you have the new error codes please send them to me a
reports the condition.
Signed-off-by: Cristian Stoica
---
drivers/crypto/caam/error.c | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/drivers/crypto/caam/error.c b/drivers/crypto/caam/error.c
index 6531054..c4483ad 100644
--- a/drivers/crypto/caam
If dma mapping for dma_addr_out fails, the descriptor memory is freed
but the previous dma mapping for dma_addr_in remains.
This patch resolves the missing dma unmap and groups resource
allocations at function start.
Cc: # 3.13+
Signed-off-by: Cristian Stoica
---
drivers/crypto/caam/key_gen.c
trace a4a18a1094a0306c ]---
Cc: # 3.13+
Signed-off-by: Cristian Stoica
---
drivers/crypto/caam/caamhash.c | 22 ++--
drivers/crypto/caam/sg_sw_sec4.h | 54
2 files changed, 14 insertions(+), 62 deletions(-)
diff --git a/drivers/crypto/caam/caamha
buf_0 and buf_1 in caam_hash_state are not next to each other.
Accessing buf_1 is incorrect from &buf_0 with an offset of only
size_of(buf_0). The same issue is also with buflen_0 and buflen_1
Cc: # 3.13+
Signed-off-by: Cristian Stoica
---
drivers/crypto/caam/caamhash.c | 6 +++---
1
This is a set of two independent fixes for caamhash driver
drivers/crypto/caam/caamhash.c | 28 +---
drivers/crypto/caam/sg_sw_sec4.h | 54
--
2 files changed, 17 insertions(+), 65 deletions(-)
--
To unsubscribe from th
Hi Horia,
On 10.08.2014 11:57, Horia Geantă wrote:
> On 8/8/2014 2:27 PM, Cristian Stoica wrote:
> Don't add more checkpatch warnings on top of existing ones.
I've weighted all the checkpatch warnings and errors introduced by these
patches and I've found them fair versus Lin
Prepare IV array only if the dependent code is executed.
Signed-off-by: Cristian Stoica
---
crypto/testmgr.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index 36f45ff..365f8a3 100644
--- a/crypto/testmgr.c
+++ b/crypto
This patch inverts two if conditions to remove code blocks
indentation. Several white space clean-ups follow.
Signed-off-by: Cristian Stoica
---
crypto/testmgr.c | 283 ++-
1 file changed, 136 insertions(+), 147 deletions(-)
diff --git a
This patch inverts one if condition to remove code block indentation.
Several white space clean-ups follow.
Signed-off-by: Cristian Stoica
---
crypto/testmgr.c | 123 +++
1 file changed, 60 insertions(+), 63 deletions(-)
diff --git a/crypto
The argument "req" of do_one_async_hash_op is not used by the
function. This patch removes this argument and renames the
function to match more closely its purpose.
Signed-off-by: Cristian Stoica
---
crypto/testmgr.c | 16 +---
1 file changed, 5 insertions(+), 11 deletion
Hi Andy,
On 01.08.2014 17:44, Andy Lutomirski wrote:
> If I understand it correctly, the issue is that cryptlen depends on
> the padding. I added some notes inline above. See here, too:
>
> https://www.imperialviolet.org/2013/02/04/luckythirteen.html
Thanks for review. We'll address this issue
Hi Andy
On 31.07.2014 23:01, Andy Lutomirski wrote:
> On 07/29/2014 02:32 AM, Cristian Stoica wrote:
...
>> + * crypto_tls_genicv - Calculate hmac digest for a TLS record
>> + * @hash: (output) buffer to save the digest into
>> + * @src:(input) scatterlist
>> This set of patches introduces support for TLS 1.0 record layer
>> encryption/decryption with a corresponding algorithm called
>> tls10(hmac(),cbc()).
>>
>> Similarly to authenc.c on which it is based, this module mixes the base
>> algorithms in software to produce an algorithm that does record
platforms
that have acceleration for AES/SHA1 but do not have direct support for TLS
record layer.
(minor dependency on pending patch
crypto: testmgr.c: white space fix-ups on test_aead)
Cristian Stoica (2):
crypto: add support for TLS 1.0 record encryption
crypto: add TLS 1.0 test vectors for AES
(hmac(),cbc())". The cipher and
hmac keys are wrapped in the same format used by authenc.c
Signed-off-by: Cristian Stoica
---
crypto/Kconfig | 20 ++
crypto/Makefile | 1 +
crypto/authenc.c | 5 +-
crypto/tls.c
Signed-off-by: Cristian Stoica
---
crypto/tcrypt.c | 5 ++
crypto/testmgr.c | 41 ---
crypto/testmgr.h | 217 +++
3 files changed, 253 insertions(+), 10 deletions(-)
diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
index c48d078
This patch inverts two if conditions and allows removal of one
tab-stop in their code-blocks. Only white-space clean-up follows.
Signed-off-by: Cristian Stoica
---
crypto/testmgr.c | 498 +++
1 file changed, 242 insertions(+), 256 deletions
This patch fixes a memory leak that appears when caam_jr module is unloaded.
Cc: # 3.13+
Signed-off-by: Cristian Stoica
---
drivers/crypto/caam/jr.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c
index 1d80bd3
This patch fixes a memory leak that appears when caam_jr module is unloaded.
Cc: # 3.13+
Signed-off-by: Cristian Stoica
---
drivers/crypto/caam/jr.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c
index 1d80bd3
This patch fixes a memory leak that appears when caam_jr module is unloaded.
Cc: # 3.13+
Signed-off-by: Cristian Stoica
---
drivers/crypto/caam/jr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c
index 1d80bd3..f127f86 100644
--- a
> If you can't work out why authenc.c needs slab.h I don't think
> you should be submitting patches removing unnecessary header
> files.
[]
You left out "kernel.h".
I really hoped this would not be your answer.
Yes, I'm an ignorant and yes, I ask questions. But if all you got is this type
of a
Hi Herbert,
Your original response was terse and left me more puzzled. Do you have a
sensible explanation why some includes should be kept in the source even they
serve no purpose during the build?
Thanks,
Cristian S.
> > Just because it compiles it doesn't meant that the files you
> > remo
> On Fri, Nov 29, 2013 at 08:49:42AM +0000, Cristian Stoica wrote:
> > >From what I could see there is nothing from those includes that is
> used inside authenc.c.
> > The build passes without them.
>
> Just because it compiles it doesn't meant that the fil
>From what I could see there is nothing from those includes that is used inside
>authenc.c.
The build passes without them.
Cristian S.
> > diff --git a/crypto/authenc.c b/crypto/authenc.c
> > index 1875e70..7d4bfaa 100644
> > --- a/crypto/authenc.c
> > +++ b/crypto/authenc.c
> > @@ -17,11 +17,8
Signed-off-by: Cristian Stoica
---
crypto/authenc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/crypto/authenc.c b/crypto/authenc.c
index 1875e70..7d4bfaa 100644
--- a/crypto/authenc.c
+++ b/crypto/authenc.c
@@ -17,11 +17,8 @@
#include
#include
#include
-#include
#include
This patch removes redundant execution of the same test suite in cases
where alg and driver variables are the same (e.g. when alg_test is
called from tcrypt_test)
Signed-off-by: Cristian Stoica
---
crypto/testmgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto
Signed-off-by: Cristian Stoica
---
crypto/api.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/api.c b/crypto/api.c
index 033a714..733e4ef 100644
--- a/crypto/api.c
+++ b/crypto/api.c
@@ -397,7 +397,7 @@ EXPORT_SYMBOL_GPL(__crypto_alloc_tfm);
* @mask: Mask for
60 matches
Mail list logo
