Re: [PATCH] crypto: xts: use memmove to avoid overlapped memory copy

2020-07-16 Thread Colin Ian King
On 16/07/2020 16:56, Ard Biesheuvel wrote: > On Thu, 16 Jul 2020 at 18:29, Colin King wrote: >> >> From: Colin Ian King >> >> There is a memcpy that performs a potential overlapped memory copy >> from source b to destination b + 1. Fix this by using the safer &g

Re: [PATCH -next] hwrng: make symbol 'optee_rng_id_table' static

2019-02-20 Thread Colin Ian King
On 20/02/2019 10:37, Ard Biesheuvel wrote: > On Wed, 20 Feb 2019 at 11:34, Sumit Garg wrote: >> >> On Wed, 20 Feb 2019 at 14:51, Wei Yongjun wrote: >>> >>> Fixes the following sparse warning: >>> >>> drivers/char/hw_random/optee-rng.c:265:35: warning: >>> symbol 'optee_rng_id_table' was not decl

Re: [PATCH] crypto/nx: fix spelling mistake: "availavle" -> "available"

2017-11-14 Thread Colin Ian King
On 14/11/17 13:45, Julia Lawall wrote: > > > On Tue, 14 Nov 2017, Colin King wrote: > >> From: Colin Ian King >> >> Trivial fix to spelling mistake in pr_err error message text >> >> Signed-off-by: Colin Ian King >> --- >> drivers/c

Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision"

2017-06-13 Thread Colin Ian King
On 13/06/17 11:36, Joe Perches wrote: > On Tue, 2017-06-13 at 09:52 +0100, Colin King wrote: >> From: Colin Ian King >> >> Trivial fix to spelling mistake in seq_printf message > > Hey Colin. > > Fixing spelling typos is a good thing, but is it a > good th