Re: [PATCH 1/3] crypto: Fix potential leak in test_aead_speed() if aad_size is too big

On Wed, 23 Apr 2014 01:33:05 +0200, Marek Vasut wrote: > On Monday, April 21, 2014 at 08:45:59 PM, Christian Engelmayer wrote: > > + if (aad_size >= PAGE_SIZE) { > > On an unrelated note ... Won't if (aad_size > PAGE_SIZE) be sufficient here? From what I hav

[PATCH 2/3] crypto: Fix potential leak in test_aead_speed() if crypto_alloc_aead() fails

Fix a potential memory leak in the error handling of test_aead_speed(). In case crypto_alloc_aead() fails, the function returns without going through the centralized cleanup path. Reported by Coverity - CID 1163870. Signed-off-by: Christian Engelmayer --- crypto/tcrypt.c | 3 ++- 1 file changed

[PATCH 3/3] crypto: Fix leak of struct aead_request in test_aead_speed()

Fix leakage of memory for struct aead_request that is allocated via aead_request_alloc() but not released via aead_request_free(). Reported by Coverity - CID 1163869. Signed-off-by: Christian Engelmayer --- crypto/tcrypt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a

[PATCH 1/3] crypto: Fix potential leak in test_aead_speed() if aad_size is too big

Fix a potential memory leak in the error handling of test_aead_speed(). In case the size check on the associate data length parameter fails, the function goes through the wrong exit label. Reported by Coverity - CID 1163870. Signed-off-by: Christian Engelmayer --- crypto/tcrypt.c | 14

[PATCH 0/3] Cleanup ressource leaks in test_aead_speed()

ries applies against v3.15-rc2 as well as branch master in tree git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git and is compile tested only. Christian Engelmayer (3): crypto: Fix potential leak in test_aead_speed() if aad_size is too big crypto: Fix potential leak in test_aead_s