Re: [PATCH 1/3] crypto: caam/jr - Remove spinlock for output job ring

2019-03-15 Thread Chris Spencer
Hi Vakul, On Fri, 15 Mar 2019 at 04:05, Vakul Garg wrote: > For each job ring pair, the output ring is processed exactly by one cpu > at a time under a tasklet context (one per ring). Therefore, there is no > need to protect a job ring's access & its private data structure using a > lock. Hence t

Re: [RFC 4/4] crypto: caam - use job ring for RNG instantiation instead of DECO

2019-03-05 Thread Chris Spencer
Hi Horia, On Mon, 4 Mar 2019 at 18:13, Horia Geanta wrote: > > I don't have the i.MX8 security reference manual so there's only so > RM should be available from here: > https://www.nxp.com/webapp/sps/download/mod_download.jsp?colCode=IMX8MDQLQSRM&location=null&appType=moderated Unfortunately thi

Re: [RFC 4/4] crypto: caam - use job ring for RNG instantiation instead of DECO

2019-02-28 Thread Chris Spencer
On Tue, 26 Feb 2019 at 16:24, Chris Spencer wrote: > > > The original commit which added the run_descriptor_deco0 function [3] > > > states "[...] and another function that performs the running of the > > > said descriptor using the DECO debug mechanism."

Re: [RFC 4/4] crypto: caam - use job ring for RNG instantiation instead of DECO

2019-02-26 Thread Chris Spencer
On Tue, 26 Feb 2019 at 14:53, Horia Geanta wrote: > On 2/25/2019 4:37 PM, Chris Spencer wrote: > > On Mon, 25 Feb 2019 at 14:22, Horia Geanta wrote: > >> > >> On 2/22/2019 12:07 PM, spence...@gmail.com wrote: > >>> From: Chris Spencer > >&

Re: [RFC 0/4] crypto: caam - Add i.MX8MQ support

2019-02-25 Thread Chris Spencer
On Mon, 25 Feb 2019 at 14:17, Chris Spencer wrote: > On Mon, 25 Feb 2019 at 14:03, Horia Geanta wrote: > > The code looks *very* similar to what was developed by NXP. > > Why have you stripped off the S-O-Bs? > > Hi Horia, > > Apologies, I was struggling to find an

Re: [RFC 4/4] crypto: caam - use job ring for RNG instantiation instead of DECO

2019-02-25 Thread Chris Spencer
On Mon, 25 Feb 2019 at 14:22, Horia Geanta wrote: > > On 2/22/2019 12:07 PM, spence...@gmail.com wrote: > > From: Chris Spencer > > > > This is required to support the i.MX8. > > > Why exactly is this required? > You should provide more details. I don'

Re: [RFC 0/4] crypto: caam - Add i.MX8MQ support

2019-02-25 Thread Chris Spencer
On Mon, 25 Feb 2019 at 14:03, Horia Geanta wrote: > The code looks *very* similar to what was developed by NXP. > Why have you stripped off the S-O-Bs? Hi Horia, Apologies, I was struggling to find any guidance about what to do with the tags when upstreaming changes. I will add them in the next

Re: [RFC 1/4] crypto: caam - fix detection of i.MX8 SoC

2019-02-24 Thread Chris Spencer
On Fri, 22 Feb 2019 at 10:07, wrote: > From: Chris Spencer > > The i.MX8 does not currently have an SoC driver so soc_device_match does > not recognise it. Check the machine compatible instead. > > Signed-off-by: Chris Spencer Turns out there is already an outstanding pa