On 01/02/18 12:16, Horia Geantă wrote:
If the loop cannot exit based on value of "ret" != -EAGAIN, then it means
caam_probe() will eventually fail due to ret == -EAGAIN:
if (ret) {
dev_err(dev, "failed to instantiate RNG");
goto caam_remove;
}
For
ag]
Fixes: 67c2315def06 ("crypto: caam - add Queue Interface (QI) backend
support")
Tested-by: Ryan Harkin
Signed-off-by: Rui Miguel Silva
Cc: "Horia Geantă"
Cc: Aymen Sghaier
Cc: Fabio Estevam
Cc: Peng Fan
Cc: "David S. Miller"
Cc: Lukas Auer
Cc: # 4.12+
Reviewe
t #1 is not then it's a NOP as Linux has full permission to rewrite the
deco registers in the first page of CAAM registers.
Finally then if #1 and #2 are true, the fixes here allow the CAAM to come
up and for the RNG to be useable again.
Bryan O'Donoghue (1):
crypto: caam: Fix endless lo
Sghaier
Cc: Fabio Estevam
Cc: Peng Fan
Cc: "David S. Miller"
Cc: Lukas Auer
Cc: # 4.12+
Signed-off-by: Bryan O'Donoghue
---
drivers/crypto/caam/ctrl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
index 98986d3..0a
Cc: Aymen Sghaier
Cc: Fabio Estevam
Cc: Peng Fan
Cc: "David S. Miller"
Cc: Lukas Auer
Signed-off-by: Bryan O'Donoghue
---
drivers/crypto/caam/ctrl.c | 39 ---
1 file changed, 24 insertions(+), 15 deletions(-)
diff --git a/drivers/crypto/caa
io Estevam
Cc: Peng Fan
Cc: "David S. Miller"
Cc: Lukas Auer
Signed-off-by: Bryan O'Donoghue
---
drivers/clk/imx/clk-imx7d.c | 1 +
include/dt-bindings/clock/imx7d-clock.h | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-imx7
: Lukas Auer
Signed-off-by: Bryan O'Donoghue
---
arch/arm/boot/dts/imx7s.dtsi | 31 +++
1 file changed, 31 insertions(+)
diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
index 82ad26e..e38c159 100644
--- a/arch/arm/boot/dts/imx7s.dts
uot;
Cc: Lukas Auer
Signed-off-by: Bryan O'Donoghue
---
drivers/clk/imx/clk-imx7d.c | 1 +
include/dt-bindings/clock/imx7d-clock.h | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-imx7d.c b/drivers/clk/imx/clk-imx7d.c
index 80dc211..52ab096
Sghaier
Cc: Fabio Estevam
Cc: Peng Fan
Cc: Herbert Xu
Cc: "David S. Miller"
Cc: Lukas Auer
Cc: # 4.12+
Signed-off-by: Bryan O'Donoghue
---
drivers/crypto/caam/ctrl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.
Cc: Aymen Sghaier
Cc: Fabio Estevam
Cc: Peng Fan
Cc: Herbert Xu
Cc: "David S. Miller"
Cc: Lukas Auer
Signed-off-by: Bryan O'Donoghue
---
drivers/crypto/caam/ctrl.c | 39 ---
1 file changed, 24 insertions(+), 15 deletions(-)
diff --git a/d
From: Rui Miguel Silva
Add CAAM device node to the i.MX7s device tree.
Signed-off-by: Rui Miguel Silva
Cc: "Horia Geantă"
Cc: Aymen Sghaier
Cc: Fabio Estevam
Cc: Peng Fan
Cc: Herbert Xu
Cc: "David S. Miller"
Cc: Lukas Auer
Signed-off-by: Bryan O'Donoghu
2+
Reviewed-by: Horia Geantă
Signed-off-by: Bryan O'Donoghue
---
drivers/crypto/caam/ctrl.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
index 027e121..98986d3 100644
--- a/drivers/crypto/caam/ctrl.c
+++ b/drivers/cryp
, the fixes here allow the CAAM to come
up and for the RNG to be useable again.
Bryan O'Donoghue (1):
crypto: caam: Fix endless loop when RNG is already initialized
Rui Miguel Silva (4):
crypto: caam: Fix null dereference at error path
crypto: caam: do not use mem and emi_slow clock f
2+
Reviewed-by: Horia Geantă
Signed-off-by: Bryan O'Donoghue
---
drivers/crypto/caam/ctrl.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
index 027e121..98986d3 100644
--- a/drivers/crypto/caam/ctrl.c
+++ b/drivers/cryp
From: Rui Miguel Silva
Add CAAM device node to the i.MX7s device tree.
Signed-off-by: Rui Miguel Silva
Cc: "Horia Geantă"
Cc: Aymen Sghaier
Cc: Fabio Estevam
Cc: Peng Fan
Cc: Herbert Xu
Cc: "David S. Miller"
Cc: Lukas Auer
Signed-off-by: Bryan O'Donoghu
Cc: Aymen Sghaier
Cc: Fabio Estevam
Cc: Peng Fan
Cc: Herbert Xu
Cc: "David S. Miller"
Cc: Lukas Auer
Signed-off-by: Bryan O'Donoghue
---
drivers/crypto/caam/ctrl.c | 39 ---
1 file changed, 24 insertions(+), 15 deletions(-)
diff --git a/d
uot;
Cc: Lukas Auer
Signed-off-by: Bryan O'Donoghue
---
drivers/clk/imx/clk-imx7d.c | 1 +
include/dt-bindings/clock/imx7d-clock.h | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-imx7d.c b/drivers/clk/imx/clk-imx7d.c
index 80dc211..52ab096
Sghaier
Cc: Fabio Estevam
Cc: Peng Fan
Cc: Herbert Xu
Cc: "David S. Miller"
Cc: Lukas Auer
Cc: # 4.12+
Signed-off-by: Bryan O'Donoghue
---
drivers/crypto/caam/ctrl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.
atch
for the NULL pointer dereference fixes a cash on this path). If #2 is true
but #1 is not then it's a NOP as Linux has full permission to rewrite the
deco registers in the first page of CAAM registers.
Finally then if #1 and #2 are true, the fixes here allow the CAAM to come
up and for
On 25/01/18 17:50, Horia Geantă wrote:
If the first ("global") caam register page is not accessible, RNG init is not
the only problem. For e.g. device endianness detection won't work.
Hi Horia,
Yes I had that thought that there were other gotchas lurking once the
CAAM was in a more restricted
On 25/01/18 13:20, Auer, Lukas wrote:
On Wed, 2018-01-24 at 14:50 +, Bryan O'Donoghue wrote:
When TrustZone is enabled on sec4 compatible silicon the first page
of the
CAAM is reserved for TrustZone only, this means that access to the
deco
registers is restricted and will return zero
On 24/01/18 22:48, Bryan O'Donoghue wrote:
The clock configuration has changed to just one CAAM-specific clock in
addition to the ahb clock. This also means that additional
modifications to the CAAM driver are necessary or it will complain that
it doesn't find all clocks.
Sure -
On 24/01/18 18:12, Auer, Lukas wrote:
On Wed, 2018-01-24 at 14:50 +, Bryan O'Donoghue wrote:
From: Rui Miguel Silva
Add CAAM device node to the i.MX7s device tree.
Signed-off-by: Rui Miguel Silva
Cc: "Horia Geantă"
Cc: Aymen Sghaier
Cc: Fabio Estevam
Cc: Peng Fan
Cc:
ag]
Fixes: 67c2315def06 ("crypto: caam - add Queue Interface (QI) backend
support")
Tested-by: Ryan Harkin
Signed-off-by: Rui Miguel Silva
Cc: "Horia Geantă"
Cc: Aymen Sghaier
Cc: Fabio Estevam
Cc: Peng Fan
Cc: Herbert Xu
Cc: "David S. Miller"
Cc: Lukas Auer
Signe
From: Rui Miguel Silva
Add CAAM device node to the i.MX7s device tree.
Signed-off-by: Rui Miguel Silva
Cc: "Horia Geantă"
Cc: Aymen Sghaier
Cc: Fabio Estevam
Cc: Peng Fan
Cc: Herbert Xu
Cc: "David S. Miller"
Cc: Lukas Auer
Signed-off-by: Bryan O'Donoghu
uot;
Cc: Lukas Auer
Signed-off-by: Bryan O'Donoghue
---
drivers/clk/imx/clk-imx7d.c | 3 +++
include/dt-bindings/clock/imx7d-clock.h | 5 -
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-imx7d.c b/drivers/clk/imx/clk-imx7d.c
index 80dc
handle the case of determining if the block is usable
when ctrlpriv->trustzone is true.
Signed-off-by: Bryan O'Donoghue
Cc: "Horia Geantă"
Cc: Aymen Sghaier
Cc: Fabio Estevam
Cc: Peng Fan
Cc: Herbert Xu
Cc: "David S. Miller"
Cc: Lukas Auer
---
drive
fix between u-boot and
Linux is available in these two threads
Link: https://github.com/OP-TEE/optee_os/issues/1408
Link: https://tinyurl.com/yam5gv9a
Link: https://patchwork.ozlabs.org/cover/865042
Signed-off-by: Bryan O'Donoghue
Cc: "Horia Geantă"
Cc: Aymen Sghaier
Cc: Fabio Es
eported-by: Ryan Harkin
Signed-off-by: Bryan O'Donoghue
Cc: "Horia Geantă"
Cc: Aymen Sghaier
Cc: Fabio Estevam
Cc: Peng Fan
Cc: Herbert Xu
Cc: "David S. Miller"
Cc: Lukas Auer
---
drivers/crypto/caam/ctrl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
rs.
Finally then if #1 and #2 are true, the fixes here allow the CAAM to come
up and for the RNG to be useable again.
Bryan O'Donoghue (3):
crypto: caam: Fix endless loop when RNG is already initialized
crypto: caam: add logic to detect when running under TrustZone
crypto: caam: detec
crap - looks like just the cover note got sent.
sorry folks
rs.
Finally then if #1 and #2 are true, the fixes here allow the CAAM to come
up and for the RNG to be useable again.
Bryan O'Donoghue (3):
crypto: caam: Fix endless loop when RNG is already initialized
crypto: caam: add logic to detect when running under TrustZone
crypto: caam: detec
32 matches
Mail list logo
