[PATCH] crypto: qat - do not duplicate string containing firmware name

Use ADF_DH895XCC_FW instead of duplicating the string "qat_895xcc.bin" when referring to the DH895xCC firmware. Signed-off-by: Bruce Allan --- drivers/crypto/qat/qat_dh895xcc/adf_drv.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/qat/qa

[PATCH] crypto: qat - fix checkpatch CODE_INDENT issue

ERROR:CODE_INDENT: code indent should use tabs where possible Signed-off-by: Bruce Allan --- drivers/crypto/qat/qat_dh895xcc/adf_drv.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/qat/qat_dh895xcc/adf_drv.c b/drivers/crypto/qat/qat_dh895xcc/adf_drv.c

[PATCH] crypto: qat - checkpatch PARENTHESIS_ALIGNMENT and LOGICAL_CONTINUATIONS

Cleanup code to fix the subject checkpatch warnings Signed-off-by: Bruce Allan --- drivers/crypto/qat/qat_common/qat_crypto.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/qat/qat_common/qat_crypto.c b/drivers/crypto/qat/qat_common/qat_crypto.c index

[PATCH] crypto: qat - fix checkpatch COMPARISON_TO_NULL issue

CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!device_reset_wq" Signed-off-by: Bruce Allan --- drivers/crypto/qat/qat_common/adf_aer.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/qat/qat_common/adf_aer.c b/drivers/crypto/qat/

[PATCH] crypto: qat - fix checkpatch BIT_MACRO issues

CHECK:BIT_MACRO: Prefer using the BIT macro Signed-off-by: Bruce Allan --- drivers/crypto/qat/qat_common/qat_hal.c|4 ++-- .../crypto/qat/qat_dh895xcc/adf_dh895xcc_hw_data.h |6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/qat

[PATCH] crypto: qat - fix checkpatch CONCATENATED_STRING issues

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements Signed-off-by: Bruce Allan --- drivers/crypto/qat/qat_common/adf_cfg_strings.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/qat/qat_common/adf_cfg_strings.h b

[PATCH] crypto: qat - fix typo

adt_ctl_drv should be adf_ctl_drv Signed-off-by: Bruce Allan --- drivers/crypto/qat/qat_common/adf_ctl_drv.c | 28 ++- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/crypto/qat/qat_common/adf_ctl_drv.c b/drivers/crypto/qat/qat_common

[PATCH] crypto: qat - fix checkpatch CHECK_SPACING issues

Signed-off-by: Bruce Allan --- drivers/crypto/qat/qat_common/icp_qat_hw.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/qat/qat_common/icp_qat_hw.h b/drivers/crypto/qat/qat_common/icp_qat_hw.h index 68f191b..121d5e6 100644 --- a/drivers/crypto/qat

[PATCH] crypto: qat - make error and info log messages more descriptive

these log messages have additional spelling/contextual fixes. Signed-off-by: Bruce Allan --- drivers/crypto/qat/qat_common/adf_accel_engine.c | 21 +++-- drivers/crypto/qat/qat_common/adf_aer.c| 19 +++-- drivers/crypto/qat/qat_common/adf_cfg.c|5 + drivers/crypto/qat/

[PATCH] crypto: qat - remove duplicate definition of Intel PCI vendor id

This define is a duplicate of the one in ./include/linux/pci_ids.h Signed-off-by: Bruce Allan --- drivers/crypto/qat/qat_common/adf_accel_devices.h |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/crypto/qat/qat_common/adf_accel_devices.h b/drivers/crypto/qat/qat_common

[PATCH] crypto: qat - fix typo in string

Signed-off-by: Bruce Allan --- drivers/crypto/qat/qat_common/adf_cfg_strings.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/qat/qat_common/adf_cfg_strings.h b/drivers/crypto/qat/qat_common/adf_cfg_strings.h index c7ac758..0d1a77e 100644 --- a/drivers

[PATCH] crypto: qat - remove unnecessary include of atomic.h header file

Signed-off-by: Bruce Allan --- drivers/crypto/qat/qat_common/adf_accel_devices.h |1 - .../crypto/qat/qat_common/adf_transport_internal.h |1 - 2 files changed, 2 deletions(-) diff --git a/drivers/crypto/qat/qat_common/adf_accel_devices.h b/drivers/crypto/qat/qat_common

[PATCH] crypto: qat - fix device reset flow

configured (when resetting the device the configuration remains across the reset so the bit should not be cleared, otherwise, the necessary services will not be re-started in adf_dev_start() after the reset - clear the bit only when actually deleting the configuration). Signed-off-by: Bruce Allan

[PATCH] crypto: qat - adf_ae_stop() is never called

In adf_dev_stop(), adf_ae_stop() is never called because adf_dev_started() will always return false since the ADF_STATUS_STARTED bit is cleared earlier in the function. Signed-off-by: Bruce Allan Acked-by: Tadeusz Struk --- drivers/crypto/qat/qat_common/adf_init.c |2 +- 1 file changed, 1

[PATCH] crypto: qat - use pci_wait_for_pending_transaction()

Prior to resetting the hardware, use pci_wait_for_pending_transaction() instead of open coding similar functionality. Signed-off-by: Bruce Allan Acked-by: Tadeusz Struk --- drivers/crypto/qat/qat_common/adf_aer.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff

[PATCH] crypto: qat - correctly type a boolean

Signed-off-by: Bruce Allan --- drivers/crypto/qat/qat_common/adf_init.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/qat/qat_common/adf_init.c b/drivers/crypto/qat/qat_common/adf_init.c index a3afa0f..edbf85a 100644 --- a/drivers/crypto/qat

[cryptodev PATCH] qat: misspelling typo - "reseting" should be "resetting"

Signed-off-by: Bruce Allan --- drivers/crypto/qat/qat_common/adf_aer.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/qat/qat_common/adf_aer.c b/drivers/crypto/qat/qat_common/adf_aer.c index c29d4c3..10ce4a2 100644 --- a/drivers/crypto/qat/qat_common

[cryptodev PATCH] qat: cleanup unnecessary break checkpatch warning

WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return #472: FILE: drivers/crypto/qat/qat_common/qat_algs.c:472: + goto bad_key; + break; Signed-off-by: Bruce Allan --- drivers/crypto/qat/qat_common/qat_algs.c |1 - 1 file changed, 1 deletion

[cryptodev PATCH] qat: fix bad unlock balance

The mutex table_lock is unlocked in two functions without first being locked. Fix the functions to properly protect the accel_table with the table_lock. Also, fix a spelling error in one of the function's header comment. Signed-off-by: Bruce Allan --- drivers/crypto/qat/qat_c

[cryptodev PATCH] qat: cleanup coccicheck warning - NULL check before freeing functions

cursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. Signed-off-by: Bruce Allan --- drivers/crypto/qat/qat_dh895xcc/adf_isr.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/qat/qat_dh895xcc