Re: Fixing gave up waiting for init of module libcrc32c.

2010-03-31 Thread Brandon Philips
ne. > > So we change use_module() to return an errno rather than a bool, and if > it's -EBUSY we drop the lock and wait in the caller, then reaquire the > lock. > > Reported-by: Brandon Philips > Signed-off-by: Rusty Russell Reviewed the patch and it looks good and I

Re: Fixing gave up waiting for init of module libcrc32c.

2010-03-30 Thread Brandon Philips
On 20:29 Sat 20 Mar 2010, Herbert Xu wrote: > On Fri, Mar 19, 2010 at 10:23:25PM -0700, David Miller wrote: > > > > I hear what you're saying Herbert, but thinking about this a bit I > > really think we should make this situation work instead of fail. > > I think the initial report perhaps painted

Re: Fixing gave up waiting for init of module libcrc32c.

2010-03-19 Thread Brandon Philips
On 09:08 Sat 20 Mar 2010, Herbert Xu wrote: > On Sat, Mar 20, 2010 at 09:01:15AM +0800, Herbert Xu wrote: > > > > IIRC modprobe(8) in user-space is supposed to load all dependencies > > prior to loading the main module. So something must've gone wrong > > before bnx2/bnx2x was loaded. Please stra

Fixing gave up waiting for init of module libcrc32c.

2010-03-19 Thread Brandon Philips
Hello Herbert, Dave- I have a little "lockup" in libcrc32c on boot and I don't know how to solve it correctly but there are a few ideas. First, note this bug is happening with bnx2x. But, since I didn't have the hardware I added usage of crc32c to bnx2 to reproduce. Here are backtraces of the tw