Re: Crypto oops in async_chainiv_do_postponed

2009-09-02 Thread Brad Bosch
Herbert Xu writes: > On Wed, Sep 02, 2009 at 09:08:38AM -0500, Brad Bosch wrote: > > > > Assume the worker thread is executing between the dequeue in > > async_chainiv_do_postponed and the clear_bit call in > > async_chainiv_schedule_work. Further assume that

Re: Crypto oops in async_chainiv_do_postponed

2009-09-02 Thread Brad Bosch
(resent due to bounce notification for vger) Herbert Xu writes: > On Tue, Sep 01, 2009 at 10:42:44AM -0500, Brad Bosch wrote: > > > > Now, ctx-err may be used by both async_chainiv_postpone_request to > > store the return value from skcipher_en

Re: Crypto oops in async_chainiv_do_postponed

2009-09-02 Thread Brad Bosch
Herbert Xu writes: > On Tue, Sep 01, 2009 at 10:42:44AM -0500, Brad Bosch wrote: > > > > Now, ctx-err may be used by both async_chainiv_postpone_request to > > store the return value from skcipher_enqueue_givcrypt and by > > async_chainiv_givencrypt_tail to

Re: Crypto oops in async_chainiv_do_postponed

2009-09-01 Thread Brad Bosch
Herbert Xu writes: > On Mon, Aug 31, 2009 at 11:11:42AM -0500, Brad Bosch wrote: > > > > OK. I was looking for something subtle because the crash takes a long > > time to happen. But do you agree that the race I described above also > > a real bug? &

Re: Crypto oops in async_chainiv_do_postponed

2009-08-31 Thread Brad Bosch
eue is depleted. > > This patch fixes it by doing the pointer conversion only when the > return value is non-NULL. In particular, we create a new function > __crypto_dequeue_request that does the pointer conversion. > > Reported-by: Brad Bosch >

Crypto oops in async_chainiv_do_postponed

2009-08-27 Thread Brad Bosch
Herbert, I seem to have found a bug in chainiv.c. The following oops occured while using blowfish and hmac-sha with UDP. The patch (against 2.6.27.30) after the oops output below is an completely untested possible fix. We will be testing this fix starting tomorrow. The null dereference occurs