[PATCH 1/3] crypto: hash - Remove legacy hash/digest code

2009-10-08 Thread Benjamin Gilbert
6941c3a0 disabled compilation of the legacy digest code but didn't actually remove it. Rectify this. Also, remove the crypto_hash_type extern declaration from algapi.h now that the struct is gone. Signed-off-by: Benjamin Gilbert --- crypto/digest.c |

[PATCH 3/3] crypto: hash - Remove cra_u.{digest,hash}

2009-10-08 Thread Benjamin Gilbert
Remove unused digest_alg and hash_alg structs from crypto_alg union and kill their definitions. This also ensures that old-style digest/hash algorithms maintained out of tree will break at build time rather than oopsing at runtime. Signed-off-by: Benjamin Gilbert --- include/linux/crypto.h

[PATCH 2/3] crypto: api - Remove digest case from procfs show handler

2009-10-08 Thread Benjamin Gilbert
Remove special handling of old-style digest algorithms from the procfs show handler. Signed-off-by: Benjamin Gilbert --- crypto/proc.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/crypto/proc.c b/crypto/proc.c index 5dc07e4..ff4cb4a 100644 --- a/crypto/proc.c

[PATCH 0/3] Remove dangling pieces of old digest/hash implementation

2009-10-08 Thread Benjamin Gilbert
/3 causes such modules to FTBFS instead. Compile-tested with allmodconfig. --Benjamin Gilbert -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] [CRYPTO] Add optimized SHA-1 implementation for x86_64

2007-06-11 Thread Benjamin Gilbert
Add optimized implementation of the SHA-1 hash function for x86_64, ported from the x86 implementation in Nettle (which is LGPLed). The code has been tested with tcrypt and the NIST test vectors. Signed-off-by: Benjamin Gilbert <[EMAIL PROTECTED]> --- arch/x86_64/kernel/x8664_ksyms.c

[PATCH] [CRYPTO] Add optimized SHA-1 implementation for i486+

2007-06-11 Thread Benjamin Gilbert
left this situation alone since I'm not familiar with the ARM code, but a !ARM condition could be added to CONFIG_SHA1_GENERIC if it makes sense. The code has been tested with tcrypt and the NIST test vectors. Signed-off-by: Benjamin Gilbert <[EMAIL PROTECTED]> --- arch/i386/kernel/i38

Re: [PATCH 2/3] [CRYPTO] Add optimized SHA-1 implementation for i486+

2007-06-11 Thread Benjamin Gilbert
Benjamin Gilbert wrote: Jan Engelhardt wrote: UTF-8 please. Hint: it should most likely be an รถ. Whoops, I had thought I had gotten that right. I'll get updates for parts 2 and 3 sent out on Monday. I'm sending the corrected parts 2 and 3 as replies to this email. The UTF-8

Re: [PATCH 3/3] [CRYPTO] Add optimized SHA-1 implementation for x86_64

2007-06-11 Thread Benjamin Gilbert
Andi Kleen wrote: Benjamin Gilbert <[EMAIL PROTECTED]> writes: +#define EXPAND(i) \ + movlOFFSET(i % 16)(DATA), TMP; \ + xorlOFFSET((i + 2) % 16)(DATA), TMP;\ Such overlapping memory ac

Re: [PATCH 2/3] [CRYPTO] Add optimized SHA-1 implementation for i486+

2007-06-11 Thread Benjamin Gilbert
iff;h=374f167dfb97c1785515a0c41e32a66b414859a8 With. I just tried 2.6.11 (the oldest that will boot) on the Pentium IV box and got 3.7 MB/s, so if it's a regression it's been around for a while. --Benjamin Gilbert - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a me

Re: [PATCH 2/3] [CRYPTO] Add optimized SHA-1 implementation for i486+

2007-06-10 Thread Benjamin Gilbert
Matt Mackall wrote: On Sat, Jun 09, 2007 at 08:33:25PM -0400, Benjamin Gilbert wrote: It's not just the loop unrolling; it's the register allocation and spilling. For comparison, I built SHATransform() from the drivers/char/random.c in 2.6.11, using gcc 3.3.5 with -O2 and SHA_CODE

Re: [PATCH 2/3] [CRYPTO] Add optimized SHA-1 implementation for i486+

2007-06-09 Thread Benjamin Gilbert
Jan Engelhardt wrote: On Jun 8 2007 17:42, Benjamin Gilbert wrote: @@ -0,0 +1,299 @@ +/* + * x86-optimized SHA1 hash algorithm (i486 and above) + * + * Originally from Nettle + * Ported from M4 to cpp by Benjamin Gilbert <[EMAIL PROTECTED]> + * + * Copyright (C) 2004, Niels M?ller + * Cop

Re: [PATCH 2/3] [CRYPTO] Add optimized SHA-1 implementation for i486+

2007-06-09 Thread Benjamin Gilbert
56 28 22 21% 1981921024 28 21 25% 2081924096 27 21 22% 2181928192 27 21 22% The improvement isn't as good, but it's still noticeable. --Benjamin Gilbert - To unsubscribe from this list: send the line &qu

[PATCH 2/3] [CRYPTO] Add optimized SHA-1 implementation for i486+

2007-06-08 Thread Benjamin Gilbert
left this situation alone since I'm not familiar with the ARM code, but a !ARM condition could be added to CONFIG_SHA1_GENERIC if it makes sense. The code has been tested with tcrypt and the NIST test vectors. Signed-off-by: Benjamin Gilbert <[EMAIL PROTECTED]> --- arch/i386/kernel/i38

[PATCH 3/3] [CRYPTO] Add optimized SHA-1 implementation for x86_64

2007-06-08 Thread Benjamin Gilbert
Add optimized implementation of the SHA-1 hash function for x86_64, ported from the x86 implementation in Nettle (which is LGPLed). The code has been tested with tcrypt and the NIST test vectors. Signed-off-by: Benjamin Gilbert <[EMAIL PROTECTED]> --- arch/x86_64/kernel/x8664_ksyms.c

[PATCH 0/3] Add optimized SHA-1 implementations for x86 and x86_64

2007-06-08 Thread Benjamin Gilbert
oes from 3.7 MB/s to 5.6 MB/s with the patches; on the Core 2, it increases from 5.5 MB/s to 8.1 MB/s. Signed-off-by: Benjamin Gilbert <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to [EMAIL PROTECTE

[PATCH 1/3] [CRYPTO] Move sha_init() into cryptohash.h

2007-06-08 Thread Benjamin Gilbert
longer needs to reimplement sha_init() in assembly Signed-off-by: Benjamin Gilbert <[EMAIL PROTECTED]> --- arch/arm/lib/sha1.S | 16 arch/s390/crypto/sha1_s390.c |6 +- drivers/crypto/padlock-sha.c |8 ++-- include/linux/cryptohash.h

[RFC][PATCH] x86-optimized SHA1 hash for CryptoAPI

2006-10-23 Thread Benjamin Gilbert
cation and clearing for nothing. (Note: the only direct users of lib/sha1.c right now are /dev/random and syncookies.) Which (if any) is the preferred approach? Suggestions and comments appreciated. --Benjamin Gilbert Signed-off-by: Benjamin Gilbert <[EMAIL PROTECTED]> --- arch/i386