Re: [stable-4.4 1/5] padata: set cpu_index of unused CPUs to -1

2020-05-21 Thread Ben Hutchings
le_cpu(cpu) { > pqueue = per_cpu_ptr(pd->pqueue, cpu); > + > + if (!cpumask_test_cpu(cpu, pd->cpumask.pcpu)) { > + pqueue->cpu_index = -1; > + continue; > + } > + > pqueue->pd = pd; >

Re: Backporting "padata: Remove broken queue flushing"

2020-05-20 Thread Ben Hutchings
On Tue, 2020-05-19 at 16:00 -0400, Daniel Jordan wrote: > Hello Ben, > > On Tue, May 19, 2020 at 02:53:05PM +0100, Ben Hutchings wrote: > > I noticed that commit 07928d9bfc81 "padata: Remove broken queue > > flushing" has been backported to most stable branch

[PATCH 3.16 12/99] padata: purge get_cpu and reorder_via_wq from padata_do_serial

2020-05-20 Thread Ben Hutchings
-by: Daniel Jordan Cc: Herbert Xu Cc: Steffen Klassert Cc: linux-crypto@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Herbert Xu Signed-off-by: Ben Hutchings --- kernel/padata.c | 23 +++ 1 file changed, 3 insertions(+), 20 deletions(-) --- a/kernel

[PATCH 3.16 10/99] padata: initialize pd->cpu with effective cpumask

2020-05-20 Thread Ben Hutchings
rg Cc: linux-ker...@vger.kernel.org Signed-off-by: Herbert Xu Signed-off-by: Ben Hutchings --- kernel/padata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/kernel/padata.c +++ b/kernel/padata.c @@ -435,7 +435,7 @@ static struct parallel_data *padata_allo atomic_set(

[PATCH 3.16 15/99] padata: always acquire cpu_hotplug_lock before pinst->lock

2020-05-20 Thread Ben Hutchings
-by: Daniel Jordan Cc: Eric Biggers Cc: Herbert Xu Cc: Steffen Klassert Cc: linux-crypto@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Herbert Xu Signed-off-by: Ben Hutchings --- kernel/padata.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/kernel/pada

Backporting "padata: Remove broken queue flushing"

2020-05-19 Thread Ben Hutchings
_data ref-count from dropping to 0 while the timer is scheduled? Ben. -- Ben Hutchings Larkinson's Law: All laws are basically false. signature.asc Description: This is a digitally signed message part

[PATCH] crypto: padlock-aes: Add ecx to outputs for rep instructions

2018-09-06 Thread Ben Hutchings
) Fixes: 46d8c4b28652 ("crypto: padlock-aes - Fix Nano workaround data ...") Signed-off-by: Ben Hutchings --- This is totally untested, so don't assume I know what I'm talking about. :-) Ben. drivers/crypto/padlock-aes.c | 25 + 1 file changed, 13 insertion

Re: [PATCH] crypto: gcm - Fix rfc4543 decryption crash

2016-05-15 Thread Ben Hutchings
On Wed, 2016-04-27 at 12:17 +0800, Herbert Xu wrote: > On Tue, Apr 26, 2016 at 01:42:56PM +0200, Ben Hutchings wrote: > > > > > > It looks like the bug was introduced in 3.10 by: > > > > d733ac90f9fe8ac284e523f9920b507555b12f6d > > Author: Jussi Kivilin

Re: [PATCH] crypto: gcm - Fix rfc4543 decryption crash

2016-04-26 Thread Ben Hutchings
q->base.flags, > +   req->base.complete, req->base.data); >   aead_request_set_crypt(subreq, cipher, cipher, enc ? 0 : authsize, iv); >   aead_request_set_assoc(subreq, assoc, assoclen); >   -- Ben Hutchings The generation of random numbers is

Re: [PATCH] crypto: gcm - Fix rfc4543 decryption crash

2016-04-26 Thread Ben Hutchings
f9920b507555b12f6d Author: Jussi Kivilinna Date:   Sun Apr 7 16:43:46 2013 +0300 crypto: gcm - fix rfc4543 to handle async crypto correctly      So 3.2.y and 3.4.y don't need this fix - or should they get both fixes? Ben. -- Ben Hutchings The generation of random numbers is too im

[PATCH] crypto x86/camellia_aesni_avx: Fix CPU feature checks

2015-10-06 Thread Ben Hutchings
00934 Fixes: ce4f5f9b65ae ("x86/fpu, crypto x86/camellia_aesni_avx: Simplify...") Signed-off-by: Ben Hutchings Cc: stable # 4.2 --- arch/x86/crypto/camellia_aesni_avx_glue.c | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/x86/crypto/camellia_aesni_avx_glue.c b/

Re: crypto: algif - avoid excessive use of socket buffer in skcipher

2014-12-11 Thread Ben Hutchings
AGE_SIZE >= > 32 KiB (I have a typo in original changelog). > > Some background for the bug (with reproducer and report from users) > - http://www.mail-archive.com/linux-crypto@vger.kernel.org/msg11787.html > - http://bugzilla.redhat.com/show_bug.cgi?id=1160289 [...] I've

Re: [PATCH] firmware: Added fw for qat_dh895xxcc hw crypto accelerator

2014-06-03 Thread Ben Hutchings
| 6 ++ > qat_895xcc.bin| Bin 0 -> 453248 bytes > 3 files changed, 45 insertions(+) > create mode 100644 LICENCE.qat_dh895xcc_firmware > create mode 100755 qat_895xcc.bin [...] Applied, thanks. Ben. -- Ben Hutchings If more than one person is respo

Re: [PATCH v3] crypto: caam - power management support for caam job-ring

2014-03-22 Thread Ben Hutchings
his is too big for stable; is a simpler fix possible? Ben. -- Ben Hutchings I'm not a reverse psychological virus. Please don't copy me into your sig. signature.asc Description: This is a digitally signed message part

Re: [PATCH 01/51] DMA-API: provide a helper to set both DMA and coherent DMA masks

2013-09-19 Thread Ben Hutchings
f. I would suggest: "The coherent mask can always be set to the same or a smaller mask than the streaming mask." Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare pr

Re: [patch v3 01/11] netlink: add reference of module in netlink_dump_start

2012-10-04 Thread Ben Hutchings
is in progress... */ > if (nlk->cb) { > mutex_unlock(nlk->cb_mutex); > netlink_destroy_callback(cb); > - sock_put(sk); > - return -EBUSY; > + ret = -EBUSY; > + goto out; > } > +

Re: [PATCH 04/16] PGP: Add definitions (RFC 4880) and packet parser [ver #2]

2011-12-04 Thread Ben Hutchings
> +}; [...] I'm a little uneasy about these structure definitions. There have been C ABIs that set the structure alignment to at least 4 by default. It may be better to play safe by declaring them '__packed'. Ben. -- Ben Hutchings Klipstein's 4th Law of Prototyping and

Re: Bug#485070: cryptsetup: "FATAL" padlock_{aes,sha} error during boot

2011-07-30 Thread Ben Hutchings
Version: 3.7-pre2-1 On Sat, 2011-07-30 at 14:13 +0800, Herbert Xu wrote: > Ralf Jung wrote: > > Hi, > > > > as per request of Jonathan at http://bugs.debian.org/cgi- > > bin/bugreport.cgi?bug=485070, I am reporting the mentioned bug to this list > > as > > well: > > > > With current Debian te

Re: linux-image-2.6.24-1-686: airo hang when loading because of aes

2009-06-02 Thread Ben Hutchings
On Tue, 2009-06-02 at 15:12 +1000, Herbert Xu wrote: > Ben Hutchings wrote: > > > > I believe geode_aes can be fixed by either (1) removing the MODULE_ALIAS > > declaration or (2) making the module initialisation function fail if the > > device is not present. The la

Re: linux-image-2.6.24-1-686: airo hang when loading because of aes

2009-05-31 Thread Ben Hutchings
n't support.) I believe geode_aes can be fixed by either (1) removing the MODULE_ALIAS declaration or (2) making the module initialisation function fail if the device is not present. The latter behaviour is generally wrong for PCI drivers, but this device presumably cannot be hotplugged.