Re: [PATCH v2] crypto: aesni - add ccm(aes) algorithm implementation

2020-12-10 Thread Ben Greear
On 12/9/20 11:30 PM, Ard Biesheuvel wrote: On Thu, 10 Dec 2020 at 04:01, Ben Greear wrote: On 12/9/20 6:43 PM, Herbert Xu wrote: On Thu, Dec 10, 2020 at 01:18:12AM +0100, Ard Biesheuvel wrote: One thing I realized just now is that in the current situation, all the synchronous skciphers

Re: [PATCH v2] crypto: aesni - add ccm(aes) algorithm implementation

2020-12-09 Thread Ben Greear
e. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH v2] crypto: aesni - add ccm(aes) algorithm implementation

2020-12-01 Thread Ben Greear
nyway. I also suspect that general users may benefit from this aesni patch since many older wifi chipsets don't support wpa3 in hardware and wpa3 is the new hotness in wifi. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH v2] crypto: aesni - add ccm(aes) algorithm implementation

2020-12-01 Thread Ben Greear
py luck that it improves some other problems as well. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH v2] crypto: aesni - add ccm(aes) algorithm implementation

2020-12-01 Thread Ben Greear
existing in more general ccm_base(ctr(aes-aesni),aes-aesni) case in MAC calculation. Suggested-by: Ben Greear Co-developed-by: Steve deRosier Signed-off-by: Steve deRosier Signed-off-by: Ard Biesheuvel --- v2: avoid the SIMD helper, as it produces an CRYPTO_ALG_ASYNC aead, which is not usable

Re: [PATCH v2] crypto: aesni - add ccm(aes) algorithm implementation

2020-12-01 Thread Ben Greear
(ctr(aes-aesni),aes-aesni) case in MAC calculation. Suggested-by: Ben Greear Co-developed-by: Steve deRosier Signed-off-by: Steve deRosier Signed-off-by: Ard Biesheuvel --- v2: avoid the SIMD helper, as it produces an CRYPTO_ALG_ASYNC aead, which is not usable by the 802.11 ccmp driver

Re: [PATCH] crypto: aesni - add ccm(aes) algorithm implementation

2020-12-01 Thread Ben Greear
On 11/30/20 10:32 PM, Ard Biesheuvel wrote: On Mon, 30 Nov 2020 at 23:48, Ben Greear wrote: On 11/29/20 10:20 AM, Ard Biesheuvel wrote: From: Steve deRosier Add ccm(aes) implementation from linux-wireless mailing list (see http://permalink.gmane.org/gmane.linux.kernel.wireless.general

Re: [PATCH] crypto: aesni - add ccm(aes) algorithm implementation

2020-11-30 Thread Ben Greear
(aes-aesni),aes-aesni) case in MAC calculation. Suggested-by: Ben Greear Co-developed-by: Steve deRosier Signed-off-by: Steve deRosier Signed-off-by: Ard Biesheuvel --- Ben, This is almost a rewrite of the original patch, switching to the new skcipher API, using the existing SIMD helper, and

Re: [PATCH] crypto: x86/aesni - implement accelerated CBCMAC, CMAC and XCBC shashes

2020-09-23 Thread Ben Greear
On 8/4/20 12:45 PM, Ben Greear wrote: On 8/4/20 6:08 AM, Ard Biesheuvel wrote: On Tue, 4 Aug 2020 at 15:01, Ben Greear wrote: On 8/4/20 5:55 AM, Ard Biesheuvel wrote: On Mon, 3 Aug 2020 at 21:11, Ben Greear wrote: Hello, This helps a bit...now download sw-crypt performance is about

Re: [PATCH 0/5] crypto: Implement cmac based on cbc skcipher

2020-08-20 Thread Ben Greear
On 8/20/20 1:10 PM, Herbert Xu wrote: On Thu, Aug 20, 2020 at 06:54:58AM -0700, Ben Greear wrote: Here's a run on an: Intel(R) Core(TM) i7-7700T CPU @ 2.90GHz testing speed of async cmac(aes-aesni) (cmac(aes-aesni)) [ 259.397910] tcrypt: test 8 ( 1024 byte blocks,

Re: [PATCH 0/5] crypto: Implement cmac based on cbc skcipher

2020-08-20 Thread Ben Greear
byte blocks, 8192 bytes per update, 1 updates): 220232 cycles/operation, 26 cycle Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH 0/5] crypto: Implement cmac based on cbc skcipher

2020-08-18 Thread Ben Greear
On 8/18/20 3:33 PM, Herbert Xu wrote: On Tue, Aug 18, 2020 at 03:31:10PM -0700, Ben Greear wrote: I don't think it has been discussed recently, but mac80211 is already a complicated beast, so if this added any significant complexity it might not be worth it. Any bulk data path shou

Re: [PATCH 0/5] crypto: Implement cmac based on cbc skcipher

2020-08-18 Thread Ben Greear
On 8/18/20 3:27 PM, Herbert Xu wrote: On Wed, Aug 19, 2020 at 08:15:50AM +1000, Herbert Xu wrote: On Tue, Aug 18, 2020 at 07:17:35AM -0700, Ben Greear wrote: Is there any easy way to use your work to make shash fast for aesni? I basically just want it to perform as well as it used to with my

Re: [PATCH 0/5] crypto: Implement cmac based on cbc skcipher

2020-08-18 Thread Ben Greear
On 8/18/20 7:05 AM, Herbert Xu wrote: On Tue, Aug 18, 2020 at 06:56:12AM -0700, Ben Greear wrote: Herbert, thanks for working on this. If I apply the patches you posted, that is expected to provide wifi aes decryption speedup similar to what the original patch I sent does? Or, are additional

Re: [PATCH 0/5] crypto: Implement cmac based on cbc skcipher

2020-08-18 Thread Ben Greear
needed? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH] crypto: x86/aesni - implement accelerated CBCMAC, CMAC and XCBC shashes

2020-08-04 Thread Ben Greear
On 8/4/20 6:08 AM, Ard Biesheuvel wrote: On Tue, 4 Aug 2020 at 15:01, Ben Greear wrote: On 8/4/20 5:55 AM, Ard Biesheuvel wrote: On Mon, 3 Aug 2020 at 21:11, Ben Greear wrote: Hello, This helps a bit...now download sw-crypt performance is about 150Mbps, but still not as good as with my

Re: [PATCH] crypto: x86/aesni - implement accelerated CBCMAC, CMAC and XCBC shashes

2020-08-04 Thread Ben Greear
On 8/4/20 6:08 AM, Ard Biesheuvel wrote: On Tue, 4 Aug 2020 at 15:01, Ben Greear wrote: On 8/4/20 5:55 AM, Ard Biesheuvel wrote: On Mon, 3 Aug 2020 at 21:11, Ben Greear wrote: Hello, This helps a bit...now download sw-crypt performance is about 150Mbps, but still not as good as with my

Re: [PATCH] crypto: x86/aesni - implement accelerated CBCMAC, CMAC and XCBC shashes

2020-08-04 Thread Ben Greear
On 8/4/20 5:55 AM, Ard Biesheuvel wrote: On Mon, 3 Aug 2020 at 21:11, Ben Greear wrote: Hello, This helps a bit...now download sw-crypt performance is about 150Mbps, but still not as good as with my patch on 5.4 kernel, and fpu is still high in perf top: 13.89% libc-2.29.so

Re: [PATCH] crypto: x86/aesni - implement accelerated CBCMAC, CMAC and XCBC shashes

2020-08-03 Thread Ben Greear
IMD state after processing the whole input. Since cmac(aes) and xcbc(aes) can reuse most of the code, let's expose those as well. Cc: Ben Greear Signed-off-by: Ard Biesheuvel --- arch/x86/crypto/Makefile | 2 +- arch/x86/crypto/aesni-intel.h | 39 +++ arch/x86/crypto/aesn

Re: Help getting aesni crypto patch upstream

2020-07-31 Thread Ben Greear
On 7/31/20 3:00 AM, Ard Biesheuvel wrote: On Fri, 31 Jul 2020 at 01:57, Ben Greear wrote: On 7/29/20 1:06 PM, Ard Biesheuvel wrote: On Wed, 29 Jul 2020 at 22:29, Ben Greear wrote: On 7/29/20 12:09 PM, Ard Biesheuvel wrote: On Wed, 29 Jul 2020 at 15:27, Ben Greear wrote: On 7/28/20 11

Re: Help getting aesni crypto patch upstream

2020-07-30 Thread Ben Greear
On 7/29/20 1:06 PM, Ard Biesheuvel wrote: On Wed, 29 Jul 2020 at 22:29, Ben Greear wrote: On 7/29/20 12:09 PM, Ard Biesheuvel wrote: On Wed, 29 Jul 2020 at 15:27, Ben Greear wrote: On 7/28/20 11:06 PM, Ard Biesheuvel wrote: On Wed, 29 Jul 2020 at 01:03, Ben Greear wrote: Hello, As

Re: Help getting aesni crypto patch upstream

2020-07-29 Thread Ben Greear
On 7/29/20 12:09 PM, Ard Biesheuvel wrote: On Wed, 29 Jul 2020 at 15:27, Ben Greear wrote: On 7/28/20 11:06 PM, Ard Biesheuvel wrote: On Wed, 29 Jul 2020 at 01:03, Ben Greear wrote: Hello, As part of my wifi test tool, I need to do decrypt AES on the CPU, and the only way this performs

Re: Help getting aesni crypto patch upstream

2020-07-29 Thread Ben Greear
On 7/28/20 11:06 PM, Ard Biesheuvel wrote: On Wed, 29 Jul 2020 at 01:03, Ben Greear wrote: Hello, As part of my wifi test tool, I need to do decrypt AES on the CPU, and the only way this performs well is to use aesni. I've been using a patch for years that does this, but rec

Help getting aesni crypto patch upstream

2020-07-28 Thread Ben Greear
interested in getting this support upstream? I'd be happy to pay for the effort. Here is the patch in question: https://github.com/greearb/linux-ct-5.7/blob/master/wip/0001-crypto-aesni-add-ccm-aes-algorithm-implementation.patch Please keep me in CC, I'm not subscribed to this list.