Re: [RFC PATCH 4/8] x86/power: Restore Key Locker internal key from the ACPI S3/4 sleep states

2021-01-28 Thread Bae, Chang Seok
On Jan 28, 2021, at 02:34, Rafael J. Wysocki wrote: > On Wed, Dec 16, 2020 at 6:47 PM Chang S. Bae wrote: >> >> + keybackup_status = read_keylocker_backup_status(); >> + if (!(keybackup_status & BIT(0))) { >> + pr_err("x86/keylocker: internal key restoration failed with

Re: [RFC PATCH 0/8] x86: Support Intel Key Locker

2020-12-22 Thread Bae, Chang Seok
> On Dec 20, 2020, at 03:59, Andy Lutomirski wrote: > > On Wed, Dec 16, 2020 at 9:46 AM Chang S. Bae wrote: >> >> Key Locker [1][2] is a new security feature available in new Intel CPUs to >> protect data encryption keys for the Advanced Encryption Standard >> algorithm. The protection limits

Re: [RFC PATCH 6/8] selftests/x86: Test Key Locker internal key maintenance

2020-12-18 Thread Bae, Chang Seok
> On Dec 18, 2020, at 18:59, Peter Zijlstra wrote: > > On Wed, Dec 16, 2020 at 09:41:44AM -0800, Chang S. Bae wrote: >> +/* ENCODEKEY128 %EAX */ >> +asm volatile (".byte 0xf3, 0xf, 0x38, 0xfa, 0xc0"); > > This is lacking a binutils version number. I will add the version number when an

Re: [RFC PATCH 7/8] crypto: x86/aes-kl - Support AES algorithm using Key Locker instructions

2020-12-18 Thread Bae, Chang Seok
> On Dec 18, 2020, at 19:11, Peter Zijlstra wrote: > > *groan*, so what actual version of binutils is needed and why is this > driver important enough to build on ancient crud to warrant all this > gunk? The new Key Locker instructions look to be added a few month ago [1]. But the latest binuti

Re: [RFC PATCH 0/8] x86: Support Intel Key Locker

2020-12-17 Thread Bae, Chang Seok
> On Dec 18, 2020, at 04:10, Eric Biggers wrote: > > On Wed, Dec 16, 2020 at 09:41:38AM -0800, Chang S. Bae wrote: >> [1] Intel Architecture Instruction Set Extensions Programming Reference: >> >> https://software.intel.com/content/dam/develop/external/us/en/documents/architecture-instructi

Re: [RFC PATCH 4/8] x86/power: Restore Key Locker internal key from the ACPI S3/4 sleep states

2020-12-17 Thread Bae, Chang Seok
> On Dec 18, 2020, at 04:10, Eric Biggers wrote: > > On Wed, Dec 16, 2020 at 09:41:42AM -0800, Chang S. Bae wrote: >> When the system state switches to these sleep states, the internal key gets >> reset. Since this system transition is transparent to userspace, the >> internal key needs to be r