Re: [PATCH] scatterlist: Update size type to support greater then 4GB size.

2018-12-24 Thread Ashish Mhetre
We don't have a real use-case for this. Understanding the consequences, we are questioning the patch in downstream itself. Please ignore this patch for now. On 12/12/18 1:36 PM, Christoph Hellwig wrote: scatterlist elements longer than 4GB sound odd. Please submit it in a series with your actu

Re: [PATCH] scatterlist: Update size type to support greater then 4GB size.

2018-12-11 Thread Ashish Mhetre
On 12/12/18 12:19 PM, Sagi Grimberg wrote:   struct nvme_sgl_desc {   __le64    addr; -    __le32    length; +    __le64    length;   __u8    rsvd[3];   __u8    type;   }; Isn't this a device or protocol defined datastructure?  You can't just change it like this. You're corre

[PATCH] scatterlist: Update size type to support greater then 4GB size.

2018-12-11 Thread Ashish Mhetre
sizeof(struct scatterlist) has changed from 28 bytes to 40 bytes, so updating NVME_MAX_SEGS from 127 to 88 to correspond to original nvme alloc size value. Signed-off-by: Krishna Reddy Signed-off-by: Ashish Mhetre --- crypto/shash.c| 2 +- drivers/ata/libata-sff.c | 2 +-