On Tue, Apr 20, 2021 at 1:44 AM Dominique MARTINET
wrote:
> Arnd Bergmann wrote on Mon, Apr 19, 2021 at 02:16:36PM +0200:
> > For built-in drivers, load order depends on the initcall level and
> > link order (how things are lined listed in the Makefile hierarchy).
> >
>
On Tue, Apr 20, 2021 at 1:44 AM Dominique MARTINET
wrote:
> Arnd Bergmann wrote on Mon, Apr 19, 2021 at 02:16:36PM +0200:
> > For built-in drivers, load order depends on the initcall level and
> > link order (how things are lined listed in the Makefile hierarchy).
> >
>
On Mon, Apr 19, 2021 at 11:33 AM Dominique MARTINET
wrote:
> Geert Uytterhoeven wrote on Mon, Apr 19, 2021 at 11:03:24AM +0200:
>
> > soc_device_match() should only be used as a last resort, to identify
> > systems that cannot be identified otherwise. Typically this is used for
> > quirks, which
From: Arnd Bergmann
gcc-11 points out a mismatch between the declaration and the definition
of poly1305_core_setkey():
lib/crypto/poly1305-donna32.c:13:67: error: argument 2 of type ‘const u8[16]’
{aka ‘const unsigned char[16]’} with mismatched bound [-Werror=array-parameter=]
13 | void
On Thu, Feb 25, 2021 at 12:52 PM Michael Ellerman wrote:
>
> Uwe Kleine-König writes:
> > The driver core ignores the return value of struct bus_type::remove()
> > because there is only little that can be done. To simplify the quest to
> > make this function return void, let struct vio_driver::re
From: Arnd Bergmann
The OcteonTX2 CPT driver force-enables the OCTEONTX2_MBOX symbol,
which fails when network drivers are disabled globally
WARNING: unmet direct dependencies detected for OCTEONTX2_MBOX
Depends on [n]: NETDEVICES [=n] && ETHERNET [=n] && NET_VENDOR_MARVELL [=
From: Arnd Bergmann
When CONFIG_CPUMASK_OFFSTACK is disabled, clang reports a warning
about a bogus condition:
drivers/crypto/marvell/octeontx2/otx2_cptlf.c:334:21: error: address of array
'lfs->lf[slot].affinity_mask' will always evaluate to 'true'
[-Werror,-W
On Sat, Jan 16, 2021 at 2:59 AM Eric Biggers wrote:
> On Sat, Jan 16, 2021 at 08:59:50AM +0800, kernel test robot wrote
>
> Looks like the clang bug that causes large stack usage in this function
> (https://bugs.llvm.org/show_bug.cgi?id=45803 which is still unfixed) got
> triggered again. Note th
On Fri, Jan 8, 2021 at 11:44 AM Herbert Xu wrote:
>
> On Fri, Jan 08, 2021 at 11:42:53AM +0100, Arnd Bergmann wrote:
> >
> > How does this work for kernels with CONFIG_VMAP_STACK?
> > I remember some other subsystems (usb, hid) adding workarounds
> > for that, bu
On Fri, Jan 8, 2021 at 10:22 AM Herbert Xu wrote:
>
> On Fri, Jan 08, 2021 at 09:36:23AM +0100, Ard Biesheuvel wrote:
> >
> > scatterlists, and I don't think we permit pointing the scatterlist
> > into request structures)
>
> Not only do we allow that, we do that in lots of places.
How does this
From: Arnd Bergmann
The driver was converted to use the crypto engine helper
but is missing the corresponding Kconfig statement to ensure
it is available:
arm-linux-gnueabi-ld: drivers/crypto/omap-sham.o: in function `omap_sham_probe':
omap-sham.c:(.text+0x374): undefined referen
From: Arnd Bergmann
The bitreverse helper is almost always built into the kernel,
but in a rare randconfig build it is possible to hit a case
in which it is a loadable module while the atmel-i2c driver
is built-in:
arm-linux-gnueabi-ld: drivers/crypto/atmel-i2c.o: in function
From: Arnd Bergmann
When the SIMD portion of the driver is disabled, the compiler cannot
figure out in advance if it will be called:
ERROR: modpost: "crypto_aegis128_update_simd" [crypto/aegis128.ko] undefined!
Add a conditional to let the compiler use dead code elimination
as befo
On Mon, Nov 16, 2020 at 2:53 PM Corentin Labbe wrote:
>
> Ciphers produce invalid results on BE.
> Key and IV need to be written in LE.
>
> Fixes: 6298e948215f2 ("crypto: sunxi-ss - Add Allwinner Security System
> crypto accelerator")
> Cc:
> Signed-off-by: Corentin Labbe
> ---
> drivers/crypt
On Wed, Sep 23, 2020 at 8:08 PM LABBE Corentin wrote:
> On Wed, Sep 23, 2020 at 04:00:32PM +0200, Arnd Bergmann wrote:
> > On Sun, Sep 20, 2020 at 8:37 PM Corentin Labbe wrote:
> > > diff --git a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c
> > > b/drivers/cryp
On Sun, Sep 20, 2020 at 8:37 PM Corentin Labbe wrote:
>
> Ciphers produce invalid results on BE.
> Key and IV need to be written in LE.
>
> Fixes: 6298e948215f2 ("crypto: sunxi-ss - Add Allwinner Security System
> crypto accelerator")
> Cc:
> Signed-off-by: Corentin Labbe
> ---
> drivers/crypt
On Thu, Aug 27, 2020 at 7:55 PM Linus Torvalds
wrote:
>
> On Thu, Aug 27, 2020 at 10:34 AM Linus Torvalds
> wrote:
> >
> > How are you guys testing? I have UBSAN and GCOV on, and don't see
> > crazy frames on either i386 or x86-64.
>
> Oh, never mind. I also have COMPILE_TEST on, so it ends up di
On Thu, Aug 27, 2020 at 1:51 PM Herbert Xu wrote:
>
> On Thu, Aug 27, 2020 at 12:41:53PM +0200, Ard Biesheuvel wrote:
> >
> > That does not help, unfortunately.
> >
> > What does seem to work is
> >
> > struct chacha_state { u32 x[16]; };
> >
> > struct chacha_state chacha_permute(struct chacha_st
On Thu, Aug 27, 2020 at 10:42 AM Ard Biesheuvel wrote:
>
> In that case, I suppose we should simply disable instrumentation for
> chacha_permute()? It is a straight-forward arithmetic transformation
> on a u32[16] array, where ubsan has limited value afaict.
I guess that always works as a last re
On Thu, Aug 27, 2020 at 10:10 AM Ard Biesheuvel wrote:
> On Thu, 27 Aug 2020 at 10:06, Herbert Xu wrote:
> >
> > On Thu, Aug 27, 2020 at 11:52:50AM +0800, kernel test robot wrote:
> > >
> > > First bad commit (maybe != root cause):
> > >
> > > tree:
> > > https://git.kernel.org/pub/scm/linux/k
On Tue, Jul 14, 2020 at 2:39 PM Horia Geantă wrote:
> diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
> index 8478eb757f3c..98f95a09ce55 100644
> --- a/drivers/char/hw_random/Kconfig
> +++ b/drivers/char/hw_random/Kconfig
> @@ -255,7 +255,7 @@ config HW_RANDOM_MXC_RNGA
o - Constify id_table[]
> ipmi: watchdog: Constify ident
> virtio_console: Constify some static variables
I just realized it was a series rather than a single patch I received. They
all look correct, so
Acked-by: Arnd Bergmann
but if you do more of those, I would suggest not including the
gree this should be
.rodata anway.
> Signed-off-by: Rikard Falkeborn
Acked-by: Arnd Bergmann
> ---
> drivers/char/hw_random/nomadik-rng.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/hw_random/nomadik-rng.c
> b/drivers/char/hw_random/n
On Tue, Jun 9, 2020 at 6:02 AM Zhangfei Gao wrote:
> On 2020/6/9 上午12:41, Bjorn Helgaas wrote:
> > On Mon, Jun 08, 2020 at 10:54:15AM +0800, Zhangfei Gao wrote:
> >> On 2020/6/6 上午7:19, Bjorn Helgaas wrote:
> +++ b/drivers/iommu/iommu.c
> @@ -2418,6 +2418,10 @@ int iommu_fwspec_init(stru
On Wed, May 27, 2020 at 6:42 PM Nathan Chancellor
wrote:
>
> On Wed, May 27, 2020 at 04:17:40PM +0200, Arnd Bergmann wrote:
> > The clang integrated assembler complains about movzxw:
> >
> > arch/x86/crypto/crc32c-pcl-intel-asm_64.S:173:2: error: invalid instructi
8ce1ef3940 ("crypto: crc32c - Optimize CRC32C calculation with
PCLMULQDQ instruction")
Signed-off-by: Arnd Bergmann
---
arch/x86/crypto/crc32c-pcl-intel-asm_64.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/crypto/crc32c-pcl-intel-asm_64.S
b/arch/x86/cry
On Wed, May 27, 2020 at 11:00 AM Greg Kroah-Hartman
wrote:
>
> On Tue, May 26, 2020 at 07:49:07PM +0800, Zhangfei Gao wrote:
> > Some platform devices appear as PCI but are actually on the AMBA bus,
>
> Why would these devices not just show up on the AMBA bus and use all of
> that logic instead of
t Viper OEM boards.
>
> Signed-off-by: Olivier Sobrie
> Signed-off-by: Waleed Ziad
The driver looks good to me.
Acked-by: Arnd Bergmann
> drivers/char/hw_random/Kconfig | 10 ++
> drivers/char/hw_random/Makefile| 1 +
> drivers/char/hw_random/ba431-rng.c | 240 +
On Tue, May 12, 2020 at 10:08 PM Eric Biggers wrote:
> On Tue, May 12, 2020 at 06:08:01PM +0100, Mark Brown wrote:
>
> For later: if SHASH_DESC_ON_STACK is causing problems, we really ought to
> find a
> better solution, since lots of users are using this macro. A version of
> crypto_shash_tfm_d
On Wed, May 6, 2020 at 7:12 AM Nathan Chancellor
wrote:
> > -
> > +#ifdef CONFIG_CC_IS_CLANG
>
> Given your comment in the bug:
>
> "The code is written to assume no loops are unrolled"
>
> Does it make sense to make this unconditional and take compiler
> heuristics out of it?
>
> > +#pragma nounr
On Tue, May 5, 2020 at 10:07 PM Jason A. Donenfeld wrote:
> On Tue, May 5, 2020 at 8:13 AM Arnd Bergmann wrote:
> >
> > clang points out a harmless use of uninitialized variables that
> > get passed into a local function but are ignored there:
> >
> > In file in
g the variables are always initialized,
and make up for the loss of readability by changing the "#if IS_ENABLED()"
checks to regular "if (IS_ENABLED())".
Fixes: e7096c131e51 ("net: WireGuard secure network tunnel")
Signed-off-by: Arnd Bergmann
---
drivers/net/
Donenfeld
Signed-off-by: Arnd Bergmann
---
lib/crypto/curve25519-hacl64.c | 4
1 file changed, 4 insertions(+)
diff --git a/lib/crypto/curve25519-hacl64.c b/lib/crypto/curve25519-hacl64.c
index c7de61829a66..87adeb4f9276 100644
--- a/lib/crypto/curve25519-hacl64.c
+++ b/lib/crypto/curve2551
press'
[-Wframe-larger-than=]
Forcing it to not unroll the final loop avoids this problem.
Fixes: 91d689337fe8 ("crypto: blake2b - add blake2b generic implementation")
Signed-off-by: Arnd Bergmann
---
crypto/blake2b_generic.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
disabled -Wrestrict on gcc in my local test tree, but with
the patches from this series and the ones I have already sent,
I see no gcc-10 specific warnings in linux-next when doing
many randconfig builds for arm/arm64/x86.
Arnd
Arnd Bergmann (15):
crypto - Avoid free() namespace collision
to skcipher")
Fixes: 700cb3f5fe75 ("crypto: lrw - Convert to skcipher")
Signed-off-by: Arnd Bergmann
---
crypto/lrw.c | 6 +++---
crypto/xts.c | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/crypto/lrw.c b/crypto/lrw.c
index 376d7ed3f1f8..5b07a
nto a helper to make
it easier to understand by both humans and compilers, which avoids
the warning.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Arnd Bergmann
---
drivers/crypto/chelsio/chcr_ktls.c | 83 +-
1 file chan
On Tue, Oct 22, 2019 at 5:42 PM Pascal Van Leeuwen
wrote:
> > diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> > index 357e230769c8..1ca8d9a15f2a 100644
> > --- a/drivers/crypto/Kconfig
> > +++ b/drivers/crypto/Kconfig
> > @@ -753,6 +753,7 @@ config CRYPTO_DEV_SAFEXCEL
> > sel
r
authenc(hmac(sha*),rfc3686(ctr(aes))) suites")
Signed-off-by: Arnd Bergmann
---
v2: rebase against crypto/master
---
.../crypto/inside-secure/safexcel_cipher.c| 55 ---
1 file changed, 36 insertions(+), 19 deletions(-)
diff --git a/drivers/crypto/inside-secure/safexcel
t for basic SM3
ahash")
Signed-off-by: Arnd Bergmann
---
drivers/crypto/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 357e230769c8..1ca8d9a15f2a 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -75
_runtime_resume' [-Werror,-Wunused-function]
Mark these functions as __maybe_unused so gcc can drop them
silently.
Fixes: 8d9d4bdc495f ("hwrng: omap3-rom - Use runtime PM instead of custom
functions")
Signed-off-by: Arnd Bergmann
---
drivers/char/hw_random/omap3-rom-rng.c | 4 ++--
1 fi
On Thu, Oct 17, 2019 at 3:26 PM Pascal Van Leeuwen
wrote:
> > /* Register PCI driver */
> > - pcireg_rc = pci_register_driver(&safexcel_pci_driver);
> > -#endif
> > + ret = pci_register_driver(&safexcel_pci_driver);
> >
> > -#if IS_ENABLED(CONFIG_OF)
> > /* Register platform d
> as NULL pointer
>
> Signed-off-by: Ben Dooks
> ---
> Cc: Arnd Bergmann
> Cc: Greg Kroah-Hartman
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-ker...@vger.kernel.org
Acked-by: Arnd Bergmann
ed void volatile [noderef]
> *addr
> drivers/char/hw_random/ks-sa-rng.c:104:9:got unsigned int *
>
> Signed-off-by: Ben Dooks
> ---
> Cc: Arnd Bergmann
Acked-by: Arnd Bergmann
On Fri, Oct 11, 2019 at 7:21 PM René van Dorst wrote:
> Quoting Andy Polyakov :
> > On 10/8/19 1:38 PM, Andy Polyakov wrote:
> > As an example, MIPS 1004K manual discusses that that there are two
> > options for multiplier for this core, proper and poor-man's. Proper
> > multiplier unit can issue
On Fri, Oct 4, 2019 at 4:23 PM Ard Biesheuvel wrote:
>
> How is it relevant whether the boot CPU is A5 or A7? These are bL
> little cores that only implement NEON for feature parity with their bl
> big counterparts, but CPU intensive tasks are scheduled on big cores,
> where NEON performance is mu
On Mon, Sep 30, 2019 at 11:09 PM Pascal Van Leeuwen
wrote:
> > Subject: Re: [PATCH 2/3] crypto: inside-secure - Reduce stack usage
> >
> > On Mon, Sep 30, 2019 at 9:04 PM Pascal Van Leeuwen
> > wrote:
> >
> > > > Alternatively, it should be possible to shrink these allocations
> > > > as the extr
On Mon, Sep 30, 2019 at 9:04 PM Pascal Van Leeuwen
wrote:
> > Alternatively, it should be possible to shrink these allocations
> > as the extra buffers appear to be largely unnecessary, but doing
> > this would be a much more invasive change.
> >
> Actually, for HMAC-SHA512 you DO need all that b
best.
Fixes: 212ef6f29e5b ("crypto: inside-secure - Fix unused variable warning when
CONFIG_PCI=n")
Signed-off-by: Arnd Bergmann
---
drivers/crypto/inside-secure/safexcel.c | 49 ++---
include/linux/pci.h | 1 +
2 files changed, 13 insertions(+),
r
authenc(hmac(sha*),rfc3686(ctr(aes))) suites")
Signed-off-by: Arnd Bergmann
---
.../crypto/inside-secure/safexcel_cipher.c| 53 ---
1 file changed, 35 insertions(+), 18 deletions(-)
diff --git a/drivers/crypto/inside-secure/safexcel_cipher.c
b/drivers/crypto/inside-secu
is harmless as it is impossible to get into this case, but
the compiler has no way of knowing that. Add an explicit error
handling case to make it obvious to both compilers and humans
reading the source.
Fixes: 212ef6f29e5b ("crypto: inside-secure - Fix unused variable warning when
CONFIG_PC
On Fri, Sep 20, 2019 at 3:26 PM Arnd Bergmann wrote:
>
> On Fri, Sep 20, 2019 at 10:34 AM John Garry wrote:
>
> > > + if (!IS_ENABLED(CONFIG_ARM64)) {
> > > + memcpy_toio(fun_base, src, 16);
> > > +
On Fri, Sep 20, 2019 at 10:34 AM John Garry wrote:
> > + if (!IS_ENABLED(CONFIG_ARM64)) {
> > + memcpy_toio(fun_base, src, 16);
> > + wmb();
> > + return;
> > + }
> > +
> > asm volatile("ldp %0, %1, %3\n"
> >"stp %0, %1, %2\n"
the mmio store
(either one) is not endian-safe, this will only work on little-
endian configurations, so I also add a Kconfig dependency on
that, regardless of the architecture.
Finally, a depenndecy on CONFIG_64BIT is needed because of the
writeq().
Signed-off-by: Arnd Bergmann
---
v2: actually
On Thu, Sep 19, 2019 at 3:48 PM Herbert Xu wrote:
>
> On Thu, Sep 19, 2019 at 04:11:13PM +0800, Zhou Wang wrote:
> > On 2019/9/13 17:17, Herbert Xu wrote:
> > > On Fri, Sep 06, 2019 at 05:22:30PM +0200, Arnd Bergmann wrote:
> > >> The only caller of hisi_zip_vf_
the mmio store
(either one) is not endian-safe, this will only work on little-
endian configurations, so I also add a Kconfig dependency on
that, regardless of the architecture.
Finally, a depenndecy on CONFIG_64BIT is needed because of the
writeq().
Signed-off-by: Arnd Bergmann
---
drivers
IS_ENABLED() check that leads to the
function being dropped based on the configuration.
Fixes: 79e09f30eeba ("crypto: hisilicon - add SRIOV support for ZIP")
Signed-off-by: Arnd Bergmann
---
drivers/crypto/hisilicon/zip/zip_main.c | 7 ++-
1 file changed, 2 insertions(+), 5 deleti
On Fri, Sep 6, 2019 at 6:08 PM Pascal Van Leeuwen
wrote:
> >
> > config CRYPTO_DEV_SAFEXCEL
> > tristate "Inside Secure's SafeXcel cryptographic engine driver"
> > - depends on OF || PCI || COMPILE_TEST
> > + depends on OF || PCI
> >
>
> This seems like it just ignores the problem
ef.
Fixes: 79e09f30eeba ("crypto: hisilicon - add SRIOV support for ZIP")
Signed-off-by: Arnd Bergmann
---
drivers/crypto/hisilicon/zip/zip_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/crypto/hisilicon/zip/zip_main.c
b/drivers/crypto/hisilicon/zip/zip_main.
I and OF
are disabled.
Take care of all of the above by adding more checks for CONFIG_PCI
and CONFIG_OF.
Fixes: 625f269a5a7a ("crypto: inside-secure - add support for PCI based FPGA
development board")
Signed-off-by: Arnd Bergmann
---
drivers/crypto/Kconfig | 2 +-
ned-off-by: Herbert Xu
Acked-by: Arnd Bergmann
On Mon, Jul 29, 2019 at 12:45 PM Ard Biesheuvel
wrote:
> On Mon, 29 Jul 2019 at 13:32, Arnd Bergmann wrote:
> > It looks like there are a number of these that could be handled the
> > same way. Should we do that for the asm-generic tree afterwards?
> >
>
> I g
Looks good to me, if you want this to go through the crypto tree,
Acked-by: Arnd Bergmann
I noticed that this is the first such entry here, and went looking for
other candidates:
$ git grep -h generic-y arch/*/include/asm/Kbuild | sort | uniq -c |
sort -nr | head -n 30
24 generic-y +=
er buffers from the slab instead, caching the allocated
> packet crypto request memory used for DATA packet crypto in the rxrpc_call
> struct.
>
> Fixes: 17926a79320a ("[AF_RXRPC]: Provide secure RxRPC sockets for use by
> userspace and kernel both")
> Reported-by: Arnd Bergmann
> Signed-off-by: David Howells
> cc: Herbert Xu
Acked-by: Arnd Bergmann
-O0 anyway. Turning off just KASAN avoids the warning
already, but I suspect both of these have undesired side-effects
for jitterentropy.
Link: https://godbolt.org/z/fDcwZ5
Signed-off-by: Arnd Bergmann
---
crypto/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/crypto/Makefile b/c
On Thu, Jul 18, 2019 at 11:17 PM 'Nick Desaulniers' via Clang Built
Linux wrote:
> On Thu, Jul 18, 2019 at 6:50 AM Arnd Bergmann wrote:
> > diff --git a/crypto/aegis.h b/crypto/aegis.h
> > index 41a3090cda8e..efed7251c49d 100644
> > --- a/crypto/aegis.h
> &g
to_aegis128_crypt' [-Wframe-larger-than=]
crypto/aegis128.c:177:13: warning: stack frame size of 592 bytes in function
'crypto_aegis128_decrypt_chunk' [-Wframe-larger-than=]
Forcing the primitives to all get inlined avoids the issue and the
resulting code is similar to what gcc
On Wed, Jul 17, 2019 at 11:14 AM wrote:
>
> From: Anson Huang
>
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang
Both patches
Acked-by: Arnd Bergmann
at most 524 bytes for each of the other cases.
Fixes: 63b945091a07 ("crypto: ccp - CCP device driver and interface support")
Signed-off-by: Arnd Bergmann
---
drivers/crypto/ccp/ccp-ops.c | 52 +---
1 file changed, 31 insertions(+), 21 deletions(-)
diff --
7;
pkcs7_verify.c:(.text+0x3c1): undefined reference to `crypto_shash_update'
pkcs7_verify.c:(.text+0x411): undefined reference to `crypto_shash_finup'
This normally doesn't show up in randconfig tests because there is
a large number of other options that select CRYPTO_HASH.
Signed-off-b
ne' reduces the stack usage from 2112 bytes to
192 and 96 bytes, respectively, and seems to generate more
useful object code.
Fixes: c871c10e4ea7 ("crypto: serpent - improve __serpent_setkey with UBSAN")
Signed-off-by: Arnd Bergmann
---
v2: style improvements suggested by Eric Biggers
ers
Fixes: 9a8a6b3f0950 ("crypto: testmgr - fuzz hashes against their generic
implementation")
Signed-off-by: Arnd Bergmann
---
crypto/testmgr.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index 0e07f61f1a31..0ce28
o dynamic allocation.
Fixes: 40153b10d91c ("crypto: testmgr - fuzz AEADs against their generic
implementation")
Fixes: d435e10e67be ("crypto: testmgr - fuzz skciphers against their generic
implementation")
Fixes: 9a8a6b3f0950 ("crypto: testmgr - fuzz hashes against their
On Mon, Jun 17, 2019 at 7:20 PM Eric Biggers wrote:
> On Mon, Jun 17, 2019 at 03:23:02PM +0200, Arnd Bergmann wrote:
> > On arm32, we get warnings about high stack usage in some of the functions:
> >
> > @@ -1541,6 +1543,10 @@ static void generate_random_hash_testvec(str
On Mon, Jun 17, 2019 at 4:56 PM Herbert Xu wrote:
>
> On Mon, Jun 17, 2019 at 04:54:16PM +0200, Arnd Bergmann wrote:
> >
> > Just converting the three testvec_config variables is what I originally
> > had in my patch. It got some configurations below the warning level,
&
On Mon, Jun 17, 2019 at 4:24 PM Herbert Xu wrote:
>
> On Mon, Jun 17, 2019 at 04:10:44PM +0200, Arnd Bergmann wrote:
> >
> > In most cases, this ends up in favor of clang (concerning the stack
> > warning size limit) because most variables are small, but here we have
>
On Mon, Jun 17, 2019 at 4:04 PM Herbert Xu wrote:
>
> On Mon, Jun 17, 2019 at 03:23:02PM +0200, Arnd Bergmann wrote:
> > On arm32, we get warnings about high stack usage in some of the functions:
> >
> > crypto/testmgr.c:2269:12: error: stack frame size o
cksize")
Signed-off-by: Arnd Bergmann
---
drivers/crypto/sunxi-ss/sun4i-ss-cipher.c | 47 +++
1 file changed, 30 insertions(+), 17 deletions(-)
diff --git a/drivers/crypto/sunxi-ss/sun4i-ss-cipher.c
b/drivers/crypto/sunxi-ss/sun4i-ss-cipher.c
index 7b0c42882830..4ab14
o dynamic allocation.
Fixes: 40153b10d91c ("crypto: testmgr - fuzz AEADs against their generic
implementation")
Fixes: d435e10e67be ("crypto: testmgr - fuzz skciphers against their generic
implementation")
Fixes: 9a8a6b3f0950 ("crypto: testmgr - fuzz hashes against their
ne' reduces the stack usage from 2112 bytes to
192 and 96 bytes, respectively, and seems to generate more
useful object code.
Fixes: c871c10e4ea7 ("crypto: serpent - improve __serpent_setkey with UBSAN")
Signed-off-by: Arnd Bergmann
---
crypto/serpent_generic.c | 2 +-
1 file chang
On Wed, Feb 20, 2019 at 5:26 PM Sumit Garg wrote:
> On Wed, 20 Feb 2019 at 21:04, Arnd Bergmann wrote:
> Reviewed-by: Sumit Garg
>
> There are already fixes sent in upstream for these. Maybe you could
> pick those too.
>
> https://www.mail-archive.com/linux-kernel@vger.
On Wed, Feb 20, 2019 at 12:17 PM Sumit Garg wrote:
>
> On Wed, 20 Feb 2019 at 16:19, Colin Ian King wrote:
> >
> > On 20/02/2019 10:37, Ard Biesheuvel wrote:
> > > On Wed, 20 Feb 2019 at 11:34, Sumit Garg wrote:
> > >>
> > >> On Wed, 20 Feb 2019 at 14:51, Wei Yongjun wrote:
> > >>>
> > >>> Fixe
On Tue, Feb 19, 2019 at 6:11 AM Sumit Garg wrote:
> On Tue, 19 Feb 2019 at 08:52, Nathan Chancellor
> wrote:
> >
> > Fixes: 5fe8b1cc6a03 ("hwrng: add OP-TEE based rng driver")
> > Link: https://github.com/ClangBuiltLinux/linux/issues/369
> > Signed-off-by: Nathan Chancellor
>
> Reviewed-by: Sum
tions.
Overall, I'm still not happy with that dependency, but for now
it documents what the code requires.
Fixes: 52813ab24959 ("crypto: caam/qi2 - avoid double export")
Signed-off-by: Arnd Bergmann
---
drivers/crypto/caam/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a
~~~^
%ld
drivers/crypto/cavium/nitrox/nitrox_debugfs.c:65:31: error: format '%lld'
expects argument of type 'long long int', but argument 3 has type 'long int'
[-Werror=format=]
Add an explicit cast to 's64'
the
two drivers in a cleaner way.
Fixes: 8d818c105501 ("crypto: caam/qi2 - add DPAA2-CAAM driver")
Signed-off-by: Arnd Bergmann
---
drivers/crypto/caam/caamalg_qi2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/caam/caamalg_qi2.c
b/drivers/crypto/caam/ca
On Wed, Sep 26, 2018 at 5:43 PM Kees Cook wrote:
> On Wed, Sep 26, 2018 at 2:51 AM, Ard Biesheuvel
> wrote:
>
> I think the depth warning is minor (90 bytes over), so I don't think
> it's high priority to backport the fix. I'm fine either way, of
> course.
The way I see these warnings, anything
;
>From what I can tell, CONFIG_NETDEVICES is the correct dependency here,
and adding it fixes the randconfig failures.
Fixes: 8d818c105501 ("crypto: caam/qi2 - add DPAA2-CAAM driver")
Signed-off-by: Arnd Bergmann
---
drivers/crypto/caam/Kconfig | 1 +
1 file changed, 1 insertion(+)
On Wed, Sep 26, 2018 at 10:44 AM Ard Biesheuvel
wrote:
>
> On Tue, 25 Sep 2018 at 18:12, Arnd Bergmann wrote:
> >
> > On Tue, Aug 7, 2018 at 11:18 PM Kees Cook wrote:
> > >
> > > In the quest to remove all stack VLA usage from the kernel[1], this uses
>
On Tue, Aug 7, 2018 at 11:18 PM Kees Cook wrote:
>
> In the quest to remove all stack VLA usage from the kernel[1], this uses
> the new upper bound for the stack buffer. Also adds a sanity check.
>
> [1]
> https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qpxydaacu1rq...@mail.gmail.co
On Sat, Sep 22, 2018 at 6:11 PM Arnd Bergmann wrote:
>
> On Thu, Sep 20, 2018 at 5:12 PM Jason A. Donenfeld wrote:
> >
> > Hey Arnd,
> >
> > On Thu, Sep 20, 2018 at 6:02 PM Arnd Bergmann wrote:
> > > Right, if you hit a stack requirement like this
On Mon, Sep 24, 2018 at 10:35 PM Jason Gunthorpe wrote:
> On Mon, Sep 24, 2018 at 10:18:52PM +0200, Arnd Bergmann wrote:
> > On Tue, Sep 18, 2018 at 7:59 PM Jason Gunthorpe wrote:
> > > On Tue, Sep 18, 2018 at 10:51:08AM -0700, Darren Hart wrote:
> > > > On Fri, Se
On Tue, Sep 18, 2018 at 7:59 PM Jason Gunthorpe wrote:
>
> On Tue, Sep 18, 2018 at 10:51:08AM -0700, Darren Hart wrote:
> > On Fri, Sep 14, 2018 at 09:57:48PM +0100, Al Viro wrote:
> > > On Fri, Sep 14, 2018 at 01:35:06PM -0700, Darren Hart wrote:
> > >
> > > > Acked-by: Darren Hart (VMware)
> >
On Thu, Sep 20, 2018 at 5:12 PM Jason A. Donenfeld wrote:
>
> Hey Arnd,
>
> On Thu, Sep 20, 2018 at 6:02 PM Arnd Bergmann wrote:
> > Right, if you hit a stack requirement like this, it's usually the compiler
> > doing something bad, not just using too much stack b
On Thu, Sep 20, 2018 at 8:41 AM Ard Biesheuvel
wrote:
>
> (+ Arnd, Eric)
>
> On 18 September 2018 at 09:16, Jason A. Donenfeld wrote:
> ...
>
> > diff --git a/lib/zinc/Makefile b/lib/zinc/Makefile
> > new file mode 100644
> > index ..83dfd63988c0
> > --- /dev/null
> > +++ b/lib/zinc/M
e not interpreted as integer
values.
Signed-off-by: Arnd Bergmann
---
drivers/android/binder.c| 2 +-
drivers/crypto/qat/qat_common/adf_ctl_drv.c | 2 +-
drivers/dma-buf/dma-buf.c | 4 +---
drivers/dma-buf/sw_sync.c | 2 +-
drivers/dm
24 Jul 2018 13:13:25 +0200 Arnd Bergmann wrote:
>> > > Almost all files in the kernel are either plain text or UTF-8
>> > > encoded. A couple however are ISO_8859-1, usually just a few
>> > > characters in a C comments, for historic reasons.
>> > > T
Almost all files in the kernel are either plain text or UTF-8
encoded. A couple however are ISO_8859-1, usually just a few
characters in a C comments, for historic reasons.
This converts them all to UTF-8 for consistency.
Signed-off-by: Arnd Bergmann
---
.../devicetree/bindings/net/nfc/pn544
On Wed, Jul 18, 2018 at 5:19 PM, Ard Biesheuvel
wrote:
> On 18 July 2018 at 23:50, Ard Biesheuvel wrote:
>> On 18 July 2018 at 05:59, Arnd Bergmann wrote:
>>> On Sun, Jul 15, 2018 at 6:28 AM, Kees Cook wrote:
>>>>
>>>> After my ahash to shash conversio
On Sun, Jul 15, 2018 at 6:28 AM, Kees Cook wrote:
>
> After my ahash to shash conversions, only ccm is left as an ahash
> user, since it actually uses sg. But with the hard-coded value reduced
> to 376, this doesn't trip the frame warnings any more. :)
>
> I'll send an updated series soon.
Maybe
1 - 100 of 306 matches
Mail list logo
