Re: [PATCH V5 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-12 Thread Andrew Bresticker
Hi James, On Thu, Mar 12, 2015 at 4:17 PM, James Hartley wrote: > This adds support for the Imagination Technologies hash accelerator which > provides hardware acceleration for SHA1 SHA224 SHA256 and MD5 hashes. > > Signed-off-by: James Hartley Looks good to me. Reviewed-by: Andre

Re: [PATCH V4 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-12 Thread Andrew Bresticker
Hi James, On Wed, Mar 11, 2015 at 7:06 PM, James Hartley wrote: > This adds support for the Imagination Technologies hash accelerator which > provides hardware acceleration for SHA1 SHA224 SHA256 and MD5 hashes. > > Signed-off-by: James Hartley One comment below, otherwise this looks fine to me

Re: [PATCH V4 2/2] Documentation: crypto: Add DT binding info for the img hw hash accelerator

2015-03-12 Thread Andrew Bresticker
achio SoC. > > Signed-off-by: James Hartley Reviewed-by: Andrew Bresticker -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-10 Thread Andrew Bresticker
Hi James, >> > +static irqreturn_t img_irq_handler(int irq, void *dev_id) { >> > + struct img_hash_dev *hdev = dev_id; >> > + u32 reg; >> > + >> > + reg = img_hash_read(hdev, CR_INTSTAT); >> > + img_hash_write(hdev, CR_INTCLEAR, reg); >> > + >> > + if (reg & CR_INT_NE

Re: [PATCH V3 1/2] crypto: Add Imagination Technologies hw hash accelerator

2015-03-08 Thread Andrew Bresticker
Hi James, On Thu, Mar 5, 2015 at 7:01 PM, James Hartley wrote: > This adds support for the Imagination Technologies hash > accelerator which provides hardware acceleration for > SHA1 SHA224 SHA256 and MD5 hashes. > > Signed-off-by: James Hartley Some general comments below, I'll leave review of

Re: [PATCH V3 2/2] Documentation: crypto: Add DT binding info for the img hw hash accelerator

2015-03-06 Thread Andrew Bresticker
Hi James, On Thu, Mar 5, 2015 at 7:01 PM, James Hartley wrote: > This adds the binding documentation for the Imagination Technologies > hash accelerator that provides hardware acceleration for > SHA1/SHA224/SHA256/MD5 hashes. This hardware will be present in > the upcoming pistachio SoC. > > Sig

Re: [PATCH 1/2] crypto: Add Imagination Technologies hw hash accelerator

2014-11-17 Thread Andrew Bresticker
On Fri, Nov 14, 2014 at 11:55 PM, Corentin LABBE wrote: > Le 15/11/2014 00:59, Andrew Bresticker a écrit : >> Hi James, >> >>> + >>> +struct img_hash_drv { >>> + struct list_head dev_list; >>> + spinlock_t lock; >

Re: [PATCH 1/2] crypto: Add Imagination Technologies hw hash accelerator

2014-11-14 Thread Andrew Bresticker
Hi James, On Mon, Nov 10, 2014 at 4:10 AM, James Hartley wrote: > This adds support for the Imagination Technologies hash > accelerator that provides hardware acceleration for > SHA1 SHA224 SHA256 and MD5 Hashes. > > Signed-off-by: James Hartley It's going to take me a little longer to get thro

Re: [PATCH 2/2] Documentation: crypto: Add DT binding info for the img hw hash accelerator

2014-11-10 Thread Andrew Bresticker
Hi James, On Mon, Nov 10, 2014 at 4:10 AM, James Hartley wrote: > Signed-off-by: James Hartley A brief commit message describing the hardware and where it's found would be nice. > diff --git a/Documentation/devicetree/bindings/crypto/img-hash.txt > b/Documentation/devicetree/bindings/crypto/i