Re: [PATCH] crypto: ux500 - fix license comment syntax error

2019-06-01 Thread Alex Xu
Quoting Greg KH (2019-06-01 16:29:07) > On Sat, Jun 01, 2019 at 10:49:43AM -0400, Alex Xu (Hello71) wrote: > > Causes error: drivers/crypto/ux500/cryp/Makefile:5: *** missing > > separator. Stop. > > > > Fixes: af873fcecef5 ("treewide: Replace GPLv2 boilerplate

[PATCH] crypto: ux500 - fix license comment syntax error

2019-06-01 Thread Alex Xu (Hello71)
Causes error: drivers/crypto/ux500/cryp/Makefile:5: *** missing separator. Stop. Fixes: af873fcecef5 ("treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 194") Signed-off-by: Alex Xu (Hello71) --- drivers/crypto/ux500/cryp/Makefile | 2 +- 1 file changed, 1 inser

Re: getrandom waits for a long time when /dev/random is insufficiently read from

2016-07-30 Thread Alex Xu
On Sat, 30 Jul 2016 18:09:22 -0400 Theodore Ts'o wrote as excerpted: > On Fri, Jul 29, 2016 at 01:31:14PM -0400, Alex Xu wrote: > > When qemu is started with -object rng-random,filename=/dev/urandom, > > and immediately (i.e. with no initrd and as the first thing in > &

Re: getrandom waits for a long time when /dev/random is insufficiently read from

2016-07-29 Thread Alex Xu
On Fri, 29 Jul 2016 19:03:51 +0200 Stephan Mueller wrote as excerpted: > Am Freitag, 29. Juli 2016, 10:14:07 CEST schrieb Alex Xu: > > I don't follow. Assuming you are correct and this is the issue, then > > reading 128 bits (16 bytes) from /dev/random should "exhaust

Re: getrandom waits for a long time when /dev/random is insufficiently read from

2016-07-29 Thread Alex Xu
On Fri, 29 Jul 2016 15:12:30 +0200 Stephan Mueller wrote as excerpted: > Am Freitag, 29. Juli 2016, 09:03:45 CEST schrieb Alex Xu: > > In my opinion, assuming I am not doing something terribly wrong, > > this constitutes a bug in the kernel's handling of getrandom calls > &

Re: getrandom waits for a long time when /dev/random is insufficiently read from

2016-07-29 Thread Alex Xu
On Fri, 29 Jul 2016 12:24:27 +0200 Nikos Mavrogiannopoulos wrote: > On Fri, Jul 29, 2016 at 7:40 AM, Stephan Mueller > wrote: > > And finally, you have a coding error that is very very common but > > fatal when reading from /dev/random: you do not account for short > > reads which implies that y

getrandom waits for a long time when /dev/random is insufficiently read from

2016-07-28 Thread Alex Xu
Linux 4.6, also tried 4.7, qemu 2.6, using this C program: #include #include #include #include int main(int argc, char *argv[]) { char buf[16]; int fd; if (argc != 2) return 1; for (int i = 0; i < atoi(argv[1]); i++) { sleep(1); if ((fd = open("/dev/