[PATCH v6 3/3] hwrng: bcm2835: add reset support

2021-03-04 Thread Álvaro Fernández Rojas
=15.034; max=16.428)Mibits/s rngtest: Program run time: 1336176 microseconds Signed-off-by: Álvaro Fernández Rojas --- v6: fix commit description. v5: remove reset_control_rearm(). v4: add reset_control_rearm(). v3: no changes. v2: no changes. drivers/char/hw_random/bcm2835-rng.c | 10

[PATCH v6 2/3] dt-bindings: rng: bcm2835: document reset support

2021-03-04 Thread Álvaro Fernández Rojas
brcm,bcm6368-rng controllers require resetting the IPSEC clock in order to get a functional RNG. Signed-off-by: Álvaro Fernández Rojas --- v6: fix dt-bindings warnings. v5: no changes. v4: pass dt_binding_check. v3: make resets required if brcm,bcm6368-rng. v2: document reset support

[PATCH v6 1/3] dt-bindings: rng: bcm2835: add clock constraints

2021-03-04 Thread Álvaro Fernández Rojas
brcm,bcm6368-rng controllers require enabling the IPSEC clock in order to get a functional RNG. Signed-off-by: Álvaro Fernández Rojas --- v6: add new patch making clocks mandatory for BCM6368. .../devicetree/bindings/rng/brcm,bcm2835.yaml | 10 ++ 1 file changed, 10

[PATCH v6 0/3] hwrng: bcm2835: add reset support

2021-03-04 Thread Álvaro Fernández Rojas
(). v3: make resets required if brcm,bcm6368-rng. v2: document reset support. Álvaro Fernández Rojas (3): dt-bindings: rng: bcm2835: add clock constraints dt-bindings: rng: bcm2835: document reset support hwrng: bcm2835: add reset support .../devicetree/bindings/rng/brcm,bcm2835.yaml | 21

Re: [PATCH] hwrng: bcm2835: set quality to 1000

2021-03-04 Thread Álvaro Fernández Rojas
Hi Florian, > El 4 mar 2021, a las 23:28, Florian Fainelli escribió: > > On 3/4/21 7:11 AM, Nicolas Saenz Julienne wrote: >> On Wed, 2021-03-03 at 10:29 +0100, Álvaro Fernández Rojas wrote: >>> Hi Herbert, >>> >>>> El 3 mar 2021, a las 10:20, Herbe

Re: [PATCH v3 1/2] dt-bindings: rng: bcm2835: document reset support

2021-03-04 Thread Álvaro Fernández Rojas
Hi Nicolas, > El 4 mar 2021, a las 14:30, Nicolas Saenz Julienne > escribió: > > On Thu, 2021-03-04 at 13:18 +0100, Álvaro Fernández Rojas wrote: >> >>> El 4 mar 2021, a las 13:07, Nicolas Saenz Julienne >>> escribió: >>> >>> Hi Alva

Re: [PATCH v3 1/2] dt-bindings: rng: bcm2835: document reset support

2021-03-04 Thread Álvaro Fernández Rojas
> El 4 mar 2021, a las 13:07, Nicolas Saenz Julienne > escribió: > > Hi Alvaro, > > On Tue, 2021-02-23 at 18:00 +0100, Álvaro Fernández Rojas wrote: >> Some devices may need to perform a reset before using the RNG, such as the >> BCM6368. >> >

[PATCH v5 1/2] dt-bindings: rng: bcm2835: document reset support

2021-03-03 Thread Álvaro Fernández Rojas
Some devices may need to perform a reset before using the RNG, such as the BCM6368. Signed-off-by: Álvaro Fernández Rojas --- v5: no changes. v4: pass dt_binding_check. v3: make resets required if brcm,bcm6368-rng. v2: document reset support. .../devicetree/bindings/rng/brcm,bcm2835.yaml

[PATCH v5 2/2] hwrng: bcm2835: add reset support

2021-03-03 Thread Álvaro Fernández Rojas
)Mibits/s rngtest: Program run time: 1336176 microseconds cat: write error: Broken pipe Signed-off-by: Álvaro Fernández Rojas --- v5: remove reset_control_rearm(). v4: add reset_control_rearm(). v3: no changes. v2: no changes. drivers/char/hw_random/bcm2835-rng.c | 10 ++ 1 file

[PATCH v5 0/2] hwrng: bcm2835: add reset support

2021-03-03 Thread Álvaro Fernández Rojas
v5: remove reset_control_rearm() and apply on latest herbert/cryptodev-2.6.git. v4: fix documentation, add reset_control_rearm(). v3: make resets required if brcm,bcm6368-rng. v2: document reset support. Álvaro Fernández Rojas (2): dt-bindings: rng: bcm2835: document reset support hwrng

Re: [PATCH v4 2/2] hwrng: bcm2835: add reset support

2021-03-03 Thread Álvaro Fernández Rojas
Hi Philipp, > El 3 mar 2021, a las 14:52, Philipp Zabel escribió: > > Hi Álvaro, > > On Wed, 2021-02-24 at 09:22 +0100, Álvaro Fernández Rojas wrote: > [...] >> @@ -115,6 +121,8 @@ static void bcm2835_rng_cleanup(struct hwrng *rng) >> /* disable rng hardware

Re: [PATCH] hwrng: bcm2835: set quality to 1000

2021-03-03 Thread Álvaro Fernández Rojas
Hi Herbert, > El 3 mar 2021, a las 10:20, Herbert Xu escribió: > > On Sat, Feb 20, 2021 at 08:12:45PM +0100, Álvaro Fernández Rojas wrote: >> >> I ran rngtest and this is what I got: > > This is meaningless except for sources that have not been whitened. > &g

[PATCH v4 2/2] hwrng: bcm2835: add reset support

2021-02-24 Thread Álvaro Fernández Rojas
)Mibits/s rngtest: Program run time: 1336176 microseconds Signed-off-by: Álvaro Fernández Rojas --- v4: add reset_control_rearm(). v3: no changes. v2: no changes. drivers/char/hw_random/bcm2835-rng.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/char/hw_random

[PATCH v4 1/2] dt-bindings: rng: bcm2835: document reset support

2021-02-24 Thread Álvaro Fernández Rojas
Some devices may need to perform a reset before using the RNG, such as the BCM6368. Signed-off-by: Álvaro Fernández Rojas --- v4: pass dt_binding_check. v3: make resets required if brcm,bcm6368-rng. v2: document reset support. .../devicetree/bindings/rng/brcm,bcm2835.yaml | 14

[PATCH v4 0/2] hwrng: bcm2835: add reset support

2021-02-24 Thread Álvaro Fernández Rojas
v4: fix documentation, add reset_control_rearm(). v3: make resets required if brcm,bcm6368-rng. v2: document reset support. Álvaro Fernández Rojas (2): dt-bindings: rng: bcm2835: document reset support hwrng: bcm2835: add reset support .../devicetree/bindings/rng/brcm,bcm2835.yaml | 14

Re: [PATCH v3 1/2] dt-bindings: rng: bcm2835: document reset support

2021-02-23 Thread Álvaro Fernández Rojas
Hi Rob, > El 23 feb 2021, a las 20:34, Rob Herring escribió: > > On Tue, 23 Feb 2021 18:00:05 +0100, Álvaro Fernández Rojas wrote: >> Some devices may need to perform a reset before using the RNG, such as the >> BCM6368. >> >> Signed-off-by: Álvaro Fernández

Re: [PATCH 1/2] dt-bindings: rng: bcm2835: document reset support

2021-02-23 Thread Álvaro Fernández Rojas
Hello Scott, El 23/02/2021 a las 18:17, Scott Branden escribió: On 2021-02-23 8:36 a.m., Florian Fainelli wrote: On 2/23/2021 8:01 AM, Álvaro Fernández Rojas wrote: Some devices may need to perform a reset before using the RNG, such as the BCM6368. Signed-off-by: Álvaro Fernández Rojas

[PATCH v3 2/2] hwrng: bcm2835: add reset support

2021-02-23 Thread Álvaro Fernández Rojas
)Mibits/s rngtest: Program run time: 1336176 microseconds cat: write error: Broken pipe Signed-off-by: Álvaro Fernández Rojas --- v3: no changes. v2: no changes. drivers/char/hw_random/bcm2835-rng.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/char/hw_random/bcm2835

[PATCH v3 1/2] dt-bindings: rng: bcm2835: document reset support

2021-02-23 Thread Álvaro Fernández Rojas
Some devices may need to perform a reset before using the RNG, such as the BCM6368. Signed-off-by: Álvaro Fernández Rojas --- v3: make resets required if brcm,bcm6368-rng. v2: document reset support. .../devicetree/bindings/rng/brcm,bcm2835.yaml | 17 + 1 file changed, 17

[PATCH v3 0/2] hwrng: bcm2835: add reset support

2021-02-23 Thread Álvaro Fernández Rojas
Some devices may need to perform a reset before using the RNG, such as the BCM6368. v3: make resets required if brcm,bcm6368-rng. v2: document reset support. Álvaro Fernández Rojas (2): dt-bindings: rng: bcm2835: document reset support hwrng: bcm2835: add reset support .../devicetree

[PATCH 2/2] hwrng: bcm2835: add reset support

2021-02-23 Thread Álvaro Fernández Rojas
)Mibits/s rngtest: Program run time: 1336176 microseconds Signed-off-by: Álvaro Fernández Rojas --- v2: no changes. drivers/char/hw_random/bcm2835-rng.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/char/hw_random/bcm2835-rng.c b/drivers/char/hw_random/bcm2835-rng.c

[PATCH 1/2] dt-bindings: rng: bcm2835: document reset support

2021-02-23 Thread Álvaro Fernández Rojas
Some devices may need to perform a reset before using the RNG, such as the BCM6368. Signed-off-by: Álvaro Fernández Rojas --- v2: document reset support. Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree

[PATCH 0/2] hwrng: bcm2835: add reset support

2021-02-23 Thread Álvaro Fernández Rojas
Some devices may need to perform a reset before using the RNG, such as the BCM6368. Álvaro Fernández Rojas (2): dt-bindings: rng: bcm2835: document reset support hwrng: bcm2835: add reset support .../devicetree/bindings/rng/brcm,bcm2835.yaml | 5 + drivers/char/hw_random

[PATCH v3] hwrng: bcm2835: set quality

2021-02-22 Thread Álvaro Fernández Rojas
est: FIPS tests speed: (min=761.155; avg=8343.383; max=15662.590)Kibits/s rngtest: Program run time: 3539183 microseconds cat: write error: Broken pipe Signed-off-by: Álvaro Fernández Rojas --- v3: set different qualities for each SoC v2: add jusftification drivers/char/hw_random/bcm2835-rng.c |

[PATCH] hwrng: bcm2835: add reset support

2021-02-22 Thread Álvaro Fernández Rojas
)Mibits/s rngtest: Program run time: 1336176 microseconds cat: write error: Broken pipe Signed-off-by: Álvaro Fernández Rojas --- drivers/char/hw_random/bcm2835-rng.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/char/hw_random/bcm2835-rng.c b/drivers/char/hw_random

[PATCH v2] hwrng: iproc: set quality to 1024

2021-02-20 Thread Álvaro Fernández Rojas
and 0 failures -> 100% success rate Signed-off-by: Álvaro Fernández Rojas --- v2: set quality to 1024 and add justification drivers/char/hw_random/iproc-rng200.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/hw_random/iproc-rng200.c b/drivers/char/hw_random/iproc-rng20

[PATCH v2] hwrng: bcm2835: set quality to 1000

2021-02-20 Thread Álvaro Fernández Rojas
rngtest: Program run time: 56826982 microseconds 996 successes and 4 failures -> 99.6% success rate 1024 * 99.6% = 1019 (rounded down to 1000) Signed-off-by: Álvaro Fernández Rojas --- v2: add jusftification drivers/char/hw_random/bcm2835-rng.c | 1 + 1 file changed, 1 insertion(+) diff --

Re: [PATCH] hwrng: bcm2835: set quality to 1000

2021-02-20 Thread Álvaro Fernández Rojas
and 4 failures -> 99.6% success rate 1024 * 99.6% = 1019 (rounded down to 1000) I'm not sure if I can rely on rngtest for that... Best regards, Álvaro. El 20/02/2021 a las 20:09, Andrew Lunn escribió: On Sat, Feb 20, 2021 at 06:47:40PM +0100, Álvaro Fernández Rojas wrote: This allows

[PATCH] hwrng: iproc: set quality to 1000

2021-02-20 Thread Álvaro Fernández Rojas
This allows khwrngd to make use of iproc-rng200. Signed-off-by: Álvaro Fernández Rojas --- drivers/char/hw_random/iproc-rng200.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/hw_random/iproc-rng200.c b/drivers/char/hw_random/iproc-rng200.c index 01583faf9893..e49868dd9b96

[PATCH] hwrng: bcm2835: set quality to 1000

2021-02-20 Thread Álvaro Fernández Rojas
This allows devices without a high precission timer to reduce boot from >100s to <30s. Signed-off-by: Álvaro Fernández Rojas --- drivers/char/hw_random/bcm2835-rng.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/hw_random/bcm2835-rng.c b/drivers/char/hw_random/bcm2835

[PATCH] hwrng: bcm63xx - fix device tree compilation

2016-04-03 Thread Álvaro Fernández Rojas
Adds missing include that resulted in implicit device tree functions errors. Fixes: 7b651706712b ("hwrng: bcm63xx - add device tree support") Signed-off-by: Álvaro Fernández Rojas --- drivers/char/hw_random/bcm63xx-rng.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char

[PATCH] hw_random: brcm63xx-rng: fix non device tree compatibility

2016-02-21 Thread Álvaro Fernández Rojas
Allow building when OF is not enabled as suggested by Florian Signed-off-by: Álvaro Fernández Rojas Reported-by: Florian Fainelli --- drivers/char/hw_random/bcm63xx-rng.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/char/hw_random/bcm63xx-rng.c b/drivers/char