Re: [PATCH] md/raid6: Couple of typo fixes

2021-03-19 Thread Randy Dunlap
On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote: s/boudary/boundary/ s/compliled/compiled/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap --- crypto/async_tx/raid6test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crypto/async_tx/raid6test.c b/crypto/

Re: stable request

2021-03-19 Thread Sasha Levin
On Fri, Mar 19, 2021 at 11:50:06AM +0100, Greg KH wrote: On Fri, Mar 19, 2021 at 07:35:44AM +, Thomas Backlund wrote: Den 18-03-2021 kl. 15:03, skrev Sasha Levin: > > On Tue, Mar 16, 2021 at 01:35:40PM +0100, Ard Biesheuvel wrote: >> On Tue, 16 Mar 2021 at 13:28, Thomas Backlund wrote: >>>

Re: [PATCH] char: hw_random: delete redundant printing of return value

2021-03-19 Thread Herbert Xu
On Sat, Mar 13, 2021 at 03:47:42PM +0800, Wang Qing wrote: > platform_get_irq() has already checked and printed the return value, > the printing here is nothing special, it is not necessary at all. > > Signed-off-by: Wang Qing > --- > drivers/char/hw_random/cctrng.c | 4 +--- > 1 file changed,

Re: [PATCH] hwrng: cctrn - use devm_platform_ioremap_resource() to simplify

2021-03-19 Thread Herbert Xu
On Sat, Mar 13, 2021 at 09:42:35AM +0800, Tian Tao wrote: > Use devm_platform_ioremap_resource() to simplify the code. > > Signed-off-by: Tian Tao > --- > drivers/char/hw_random/cctrng.c | 12 +--- > 1 file changed, 1 insertion(+), 11 deletions(-) Patch applied. Thanks. -- Email: Herb

Re: [PATCH v4 0/3] crypto:hisilicon/sec - fixes some coding style

2021-03-19 Thread Herbert Xu
On Sat, Mar 13, 2021 at 03:28:22PM +0800, Longfang Liu wrote: > 1. Fix a problems. > 2. Fix some coding style. > > Changes v3 -> v4: > - Fixed an unused warning on dev. > - Create a patch for bugfix > > Changes v2 -> v3: > - Delete shash test error patch. > > Changes v1 -> v2: > - Modify

Re: [PATCH v3 0/2] crypto: arm - clean up redundant helper macros

2021-03-19 Thread Herbert Xu
On Wed, Mar 10, 2021 at 11:14:19AM +0100, Ard Biesheuvel wrote: > Now that ARM's asm/assembler.h provides mov_l and rev_l macros, let's get > rid of the locally defined ones that live in the ChaCha and AES crypto code. > > Changes since v2: > - fix rev_32->rev_l in the patch subject lines > - add

Re: [PATCH] hwrng: ba431 - use devm_platform_ioremap_resource() to simplify

2021-03-19 Thread Herbert Xu
On Sat, Mar 13, 2021 at 09:47:38AM +0800, Tian Tao wrote: > Use devm_platform_ioremap_resource() to simplify the code. > > Signed-off-by: Tian Tao > --- > drivers/char/hw_random/ba431-rng.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu

Re: [PATCH] crypto: arm/blake2s - fix for big endian

2021-03-19 Thread Herbert Xu
Eric Biggers wrote: > From: Eric Biggers > > The new ARM BLAKE2s code doesn't work correctly (fails the self-tests) > in big endian kernel builds because it doesn't swap the endianness of > the message words when loading them. Fix this. > > Fixes: 5172d322d34c ("crypto: arm/blake2s - add ARM s

Re: stable request

2021-03-19 Thread Greg KH
On Fri, Mar 19, 2021 at 07:35:44AM +, Thomas Backlund wrote: > Den 18-03-2021 kl. 15:03, skrev Sasha Levin: > > > > On Tue, Mar 16, 2021 at 01:35:40PM +0100, Ard Biesheuvel wrote: > >> On Tue, 16 Mar 2021 at 13:28, Thomas Backlund wrote: > >>> > >>> > >>> Den 16.3.2021 kl. 14:15, skrev Thomas

[PATCH] crypto: hisilicon/hpre - fix Kconfig

2021-03-19 Thread Hui Tang
hpre select 'CRYPTO_ECDH' and 'CRYPTO_CURVE25519'. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/hisilicon/Kconfig b/drivers/crypto/hisilicon/Kconfig index c45adb1..e572f99 100644 --- a/drivers/cr

[PATCH] crypto: hisilicon/hpre - fix "hpre_ctx_init" resource leak

2021-03-19 Thread Hui Tang
When calling "hpre_ctx_set" fails, stop and put qp, otherwise will leak qp resource. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c b/drivers/cr

[PATCH] crypto: hisilicon - fix the check on dma address

2021-03-19 Thread Hui Tang
System may be able to get physical address of zero if not reserved by firmware. The dma address obtained by 'dma_alloc_coherent' is valid, since already checking cpu va before, so do not check again. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 12 driv

[PATCH 2/2] crypto: hisilicon/hpre - optimise 'hpre_algs_register' error path

2021-03-19 Thread Hui Tang
There is redundant code especially when registing new algorithms in the future. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c b/drivers/

[PATCH 0/2] crypto: hisilicon/hpre - remove 'CONFIG_CRYPTO_DH'

2021-03-19 Thread Hui Tang
Remove 'CONFIG_CRYPTO_DH' and optimise 'hpre_algs_register' error path. Hui Tang (2): crypto: hisilicon/hpre - delete wrap of 'CONFIG_CRYPTO_DH' crypto: hisilicon/hpre - optimise 'hpre_algs_register' error path drivers/crypto/hisilicon/hpre/hpre_crypto.c | 30 ++--- 1

[PATCH 1/2] crypto: hisilicon/hpre - delete wrap of 'CONFIG_CRYPTO_DH'

2021-03-19 Thread Hui Tang
'CRYPTO_DH' has selected in 'Kconfig', so delete 'CONFIG_CRYPTO_DH'. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c b/drivers/crypto/hisilicon/hpr

Re: [PATCH for-stable-5.4] crypto: x86/aes-ni-xts - use direct calls to and 4-way stride

2021-03-19 Thread Greg KH
On Thu, Mar 18, 2021 at 05:41:51PM +, Ard Biesheuvel wrote: > From: Ard Biesheuvel > > Upstream commit 86ad60a65f29dd862a11c22bb4b5be28d6c5cef1 > > The XTS asm helper arrangement is a bit odd: the 8-way stride helper > consists of back-to-back calls to the 4-way core transforms, which > are

[PATCH] crypto: Correct an error in the comments

2021-03-19 Thread Meng Yu
Remove repeated word 'bit' in comments. Signed-off-by: Meng Yu --- crypto/ecc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/ecc.c b/crypto/ecc.c index 0798a18..63ba70b 100644 --- a/crypto/ecc.c +++ b/crypto/ecc.c @@ -137,7 +137,7 @@ bool vli_is_zero(const u64 *vli,

[PATCH] md/raid6: Couple of typo fixes

2021-03-19 Thread Bhaskar Chowdhury
s/boudary/boundary/ s/compliled/compiled/ Signed-off-by: Bhaskar Chowdhury --- crypto/async_tx/raid6test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crypto/async_tx/raid6test.c b/crypto/async_tx/raid6test.c index 66db82e5a3b1..c9d218e53bcb 100644 --- a/crypto/asyn

Re: stable request

2021-03-19 Thread Thomas Backlund
Den 18-03-2021 kl. 15:03, skrev Sasha Levin: > > On Tue, Mar 16, 2021 at 01:35:40PM +0100, Ard Biesheuvel wrote: >> On Tue, 16 Mar 2021 at 13:28, Thomas Backlund wrote: >>> >>> >>> Den 16.3.2021 kl. 14:15, skrev Thomas Backlund: Den 16.3.2021 kl. 12:17, skrev Ard Biesheuvel: > On Tue

[PATCH 4/4] crypto: hisilicon/zip - support new 'sqe' type in Kunpeng930

2021-03-19 Thread Yang Shen
The Kunpeng930 changes some field meanings in 'sqe'. So add a new 'hisi_zip_sqe_ops' to describe the 'sqe' operations. Signed-off-by: Yang Shen --- drivers/crypto/hisilicon/zip/zip.h| 1 + drivers/crypto/hisilicon/zip/zip_crypto.c | 25 + 2 files changed, 26 inse

[PATCH 2/4] crypto: hisilicon/zip - add comments for 'hisi_zip_sqe'

2021-03-19 Thread Yang Shen
Some fields of 'hisi_zip_sqe' are unused, and some fields have misc utilities. So add comments for used fields and make others unnamed. Signed-off-by: Yang Shen --- drivers/crypto/hisilicon/zip/zip.h| 45 ++- drivers/crypto/hisilicon/zip/zip_crypto.c | 4 +--

[PATCH 1/4] crypto: hisilicon/zip - adjust functions location

2021-03-19 Thread Yang Shen
This patch changes nothing about functions except location in order to make code logic clearly. This adjustment follows three principles: 1.The called functions are listed in order above the calling functions. 2.The paired functions are next to each other. 3.Logically similar functions are placed

[PATCH 3/4] crypto: hisilicon/zip - initialize operations about 'sqe' in 'acomp_alg.init'

2021-03-19 Thread Yang Shen
The operations about 'sqe' are different on some hardwares. Add a struct 'hisi_zip_sqe_ops' to describe the operations in a hardware. And choose the 'ops' in 'hisi_zip_acomp_init' according to the hardware. Signed-off-by: Yang Shen --- drivers/crypto/hisilicon/zip/zip_crypto.c | 141

[PATCH 0/4]crypto: hisilicon/zip - support new 'sqe' type in Kunpeng930

2021-03-19 Thread Yang Shen
In Kunpeng930, some field meanings in 'sqe' are changed, so driver need to distinguish the type on different platform. To avoid checking the platform everytime when driver fills the 'sqe', add a struct 'hisi_zip_sqe_ops' to describe the 'sqe' operations. The driver only need to choose the 'ops' on