Re: [PATCH] crypto: inside-secure: Minor typo fix in the file safexcel.c

2021-03-17 Thread Randy Dunlap
On 3/17/21 2:14 AM, Bhaskar Chowdhury wrote: > > s/procesing/processing/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/crypto/inside-secure/safexcel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/inside-secure/safexcel

Re: [PATCH v7 5/5] certs: Allow root user to append signed hashes to the blacklist keyring

2021-03-17 Thread Mickaël Salaün
On 17/03/2021 15:48, Eric Snowberg wrote: > >> On Mar 15, 2021, at 12:01 PM, Mickaël Salaün wrote: >> >> >> On 15/03/2021 17:59, Eric Snowberg wrote: >>> On Mar 12, 2021, at 10:12 AM, Mickaël Salaün wrote: From: Mickaël Salaün Add a kernel option SYSTEM_BLACKLIST_AUTH

Re: [PATCH v7 5/5] certs: Allow root user to append signed hashes to the blacklist keyring

2021-03-17 Thread Eric Snowberg
> On Mar 15, 2021, at 12:01 PM, Mickaël Salaün wrote: > > > On 15/03/2021 17:59, Eric Snowberg wrote: >> >>> On Mar 12, 2021, at 10:12 AM, Mickaël Salaün wrote: >>> >>> From: Mickaël Salaün >>> >>> Add a kernel option SYSTEM_BLACKLIST_AUTH_UPDATE to enable the root user >>> to dynamically

Re: [PATCH 2/8] dt-bindings: crypto : Add new compatible strings for qcom-qce

2021-03-17 Thread Thara Gopinath
On 3/17/21 9:20 AM, Bhupesh Sharma wrote: Hi Rob, Thanks for your review. On Wed, 17 Mar 2021 at 03:58, Rob Herring wrote: On Wed, Mar 10, 2021 at 10:54:57AM +0530, Bhupesh Sharma wrote: Newer qcom chips support newer versions of the qce IP, so add new compatible strings for qcom-qce (in

Re: [PATCH v1 0/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-17 Thread Ahmad Fatoum
Hello Richard, On 17.03.21 00:10, Richard Weinberger wrote: > On Tue, Mar 16, 2021 at 6:24 PM Ahmad Fatoum wrote: >> This series has been tested with dmcrypt[5] on an i.MX6DL. > > Do have this series also in a git repo to pull from? > I'd like to give it a test on various systems. Yes, please p

Re: [PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-17 Thread Ahmad Fatoum
Hello Richard, On 17.03.21 00:14, Richard Weinberger wrote: > Ahmad, > > On Tue, Mar 16, 2021 at 6:24 PM Ahmad Fatoum wrote: >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +struct caam_blob_priv *blobifier; > > Who is using this pointer too? > Otherwise I'd sugges

Re: [PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-17 Thread Ahmad Fatoum
Hello Jarkko, On 16.03.21 20:22, Jarkko Sakkinen wrote: > On Tue, Mar 16, 2021 at 06:01:18PM +0100, Ahmad Fatoum wrote: >> The Cryptographic Acceleration and Assurance Module (CAAM) is an IP core >> built into many newer i.MX and QorIQ SoCs by NXP. >> >> The CAAM does crypto acceleration, hardware

Re: [PATCH 2/8] dt-bindings: crypto : Add new compatible strings for qcom-qce

2021-03-17 Thread Bhupesh Sharma
Hi Rob, Thanks for your review. On Wed, 17 Mar 2021 at 03:58, Rob Herring wrote: > > On Wed, Mar 10, 2021 at 10:54:57AM +0530, Bhupesh Sharma wrote: > > Newer qcom chips support newer versions of the qce IP, so add > > new compatible strings for qcom-qce (in addition to the existing > > "qcom,cr

Re: [PATCH] crypto: inside-secure: Minor typo fix in the file safexcel.c

2021-03-17 Thread Antoine Tenart
Quoting Bhaskar Chowdhury (2021-03-17 10:14:45) > > s/procesing/processing/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Antoine Tenart Thanks, Antoine > --- > drivers/crypto/inside-secure/safexcel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/

[PATCH] crypto: inside-secure: Minor typo fix in the file safexcel.c

2021-03-17 Thread Bhaskar Chowdhury
s/procesing/processing/ Signed-off-by: Bhaskar Chowdhury --- drivers/crypto/inside-secure/safexcel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c index 6364583b88b2..9ff885d50edf 100644 --

Re: [PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-17 Thread Richard Weinberger
Sumit, - Ursprüngliche Mail - >> > module_param_named(source, trusted_key_source, charp, 0); >> > -MODULE_PARM_DESC(source, "Select trusted keys source (tpm or tee)"); >> > +MODULE_PARM_DESC(source, "Select trusted keys source (tpm, tee or caam)"); >> >> I didn't closely follow the previo

Re: [PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-17 Thread Sumit Garg
Hi Richard, On Wed, 17 Mar 2021 at 04:45, Richard Weinberger wrote: > > Ahmad, > > On Tue, Mar 16, 2021 at 6:24 PM Ahmad Fatoum wrote: > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +struct caam_blob_priv *blobifier; > > Who is using this pointer too? > Othe