[syzbot] general protection fault in scatterwalk_copychunks (4)

2021-03-15 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:47142ed6 net: dsa: bcm_sf2: Qualify phydev->dev_flags base.. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=17fb9376d0 kernel config: https://syzkaller.appspot.com/x/.config?x=eec733599e95cd87 dashboar

stable request

2021-03-15 Thread Ard Biesheuvel
Please consider backporting commit 86ad60a65f29dd862a11c22bb4b5be28d6c5cef1 crypto: x86/aes-ni-xts - use direct calls to and 4-way stride to stable. It addresses a rather substantial retpoline-related performance regression in the AES-NI XTS code, which is a widely used disk encryption algorithm

[PATCH v2 2/4] crypto: cavium - Fix the parameter of dma_unmap_sg()

2021-03-15 Thread chenxiang
From: Xiang Chen For function dma_unmap_sg(), the parameter should be number of elements in the scatterlist prior to the mapping, not after the mapping. So fix this usage. Signed-off-by: Xiang Chen --- drivers/crypto/cavium/nitrox/nitrox_reqmgr.c | 9 + 1 file changed, 5 insertions(+)

[PATCH v2 4/4] crypto: allwinner - Fix the parameter of dma_unmap_sg()

2021-03-15 Thread chenxiang
From: Xiang Chen For function dma_unmap_sg(), the parameter should be number of elements in the scatterlist prior to the mapping, not after the mapping. So fix this usage. Signed-off-by: Xiang Chen Acked-by: Corentin LABBE Tested-by: Corentin LABBE --- drivers/crypto/allwinner/sun8i-ce/sun8

[PATCH v2 1/4] crypto: amlogic - Fix the parameter of dma_unmap_sg()

2021-03-15 Thread chenxiang
From: Xiang Chen For function dma_unmap_sg(), the parameter should be number of elements in the scatterlist prior to the mapping, not after the mapping. So fix this usage. Signed-off-by: Xiang Chen --- drivers/crypto/amlogic/amlogic-gxl-cipher.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH v2 0/4] Fix the parameter of dma_map_sg()

2021-03-15 Thread chenxiang
From: Xiang Chen According to Documentation/core-api/dma-api-howto.rst, the parameters of dma_unmap_sg() must be the same as those which are passed in to the scatter/gather mapping API. But for some drivers under crypto, the parameter of dma_unmap_sg() is number of elements after mapping. So fix

[PATCH v2 3/4] crypto: ux500 - Fix the parameter of dma_unmap_sg()

2021-03-15 Thread chenxiang
From: Xiang Chen For function dma_unmap_sg(), the parameter should be number of elements in the scatterlist prior to the mapping, not after the mapping. So fix this usage. Signed-off-by: Xiang Chen --- drivers/crypto/ux500/cryp/cryp_core.c | 4 ++-- drivers/crypto/ux500/hash/hash_core.c | 2 +

Re: [PATCH v7 5/5] certs: Allow root user to append signed hashes to the blacklist keyring

2021-03-15 Thread Mickaël Salaün
On 15/03/2021 17:59, Eric Snowberg wrote: > >> On Mar 12, 2021, at 10:12 AM, Mickaël Salaün wrote: >> >> From: Mickaël Salaün >> >> Add a kernel option SYSTEM_BLACKLIST_AUTH_UPDATE to enable the root user >> to dynamically add new keys to the blacklist keyring. This enables to >> invalidate n

Re: [PATCH v7 5/5] certs: Allow root user to append signed hashes to the blacklist keyring

2021-03-15 Thread Eric Snowberg
> On Mar 12, 2021, at 10:12 AM, Mickaël Salaün wrote: > > From: Mickaël Salaün > > Add a kernel option SYSTEM_BLACKLIST_AUTH_UPDATE to enable the root user > to dynamically add new keys to the blacklist keyring. This enables to > invalidate new certificates, either from being loaded in a key

From Mrs.Glenn

2021-03-15 Thread Mrs.Glenn
-- Dear Beloved, I am Mrs Elizabet Glenn from Israel. I am a missionary but right now in a hospital bed in Israel. I am 59 years and childless; my husband is dead. I was diagnosed with terminal cancer. And my doctor just predicted that I have but very limited time to live due to damages in my sys

Re: [PATCH v7 1/5] tools/certs: Add print-cert-tbs-hash.sh

2021-03-15 Thread Eric Snowberg
> On Mar 12, 2021, at 10:12 AM, Mickaël Salaün wrote: > > From: Mickaël Salaün > > Add a new helper print-cert-tbs-hash.sh to generate a TBSCertificate > hash from a given certificate. This is useful to generate a blacklist > key description used to forbid loading a specific certificate in a

Re: [PATCH] crypto: public_key: check that pkey_algo is non-NULL before passing it to strcmp()

2021-03-15 Thread Greg KH
On Mon, Mar 15, 2021 at 11:52:52AM +0100, Toke Høiland-Jørgensen wrote: > Greg KH writes: > > > On Mon, Jan 18, 2021 at 06:13:02PM +0100, Toke Høiland-Jørgensen wrote: > >> David Howells writes: > >> > >> > Toke Høiland-Jørgensen wrote: > >> > > >> >> Reviewed-by: Toke Høiland-Jørgensen > >>

Re: [PATCH] crypto: public_key: check that pkey_algo is non-NULL before passing it to strcmp()

2021-03-15 Thread Toke Høiland-Jørgensen
Greg KH writes: > On Mon, Jan 18, 2021 at 06:13:02PM +0100, Toke Høiland-Jørgensen wrote: >> David Howells writes: >> >> > Toke Høiland-Jørgensen wrote: >> > >> >> Reviewed-by: Toke Høiland-Jørgensen >> >> >> >> and also, if you like: >> >> >> >> Tested-by: Toke Høiland-Jørgensen >> > >> >

[PATCH v3 2/2] crypto: ccp - fix command queuing to TEE ring buffer

2021-03-15 Thread Rijo Thomas
Multiple threads or clients can submit a command to the TEE ring buffer. This patch helps to synchronize command submission to the ring. One thread shall write a command to a TEE ring buffer entry only if: - Trusted OS has notified that the TEE command for the given entry has been processed a

[PATCH v3 1/2] crypto: ccp - reduce tee command status polling interval from 5ms to 1ms

2021-03-15 Thread Rijo Thomas
The PSP TEE device driver polls the command status variable every 5ms to check for command completion. Reduce this time to 1ms so that there is an improvement in driver response time to clients which submit TEE commands. Reviewed-by: Devaraj Rangasamy Signed-off-by: Rijo Thomas --- drivers/cryp

[PATCH v3 0/2] PSP TEE driver update and bug fixes

2021-03-15 Thread Rijo Thomas
The first patch helps to improve the response time by reducing the polling time of the tee command status variable. Second patch is a bug fix to handle multi-threaded use-case. During testing, race condition was seen due to missing synchronisation in writes to the TEE ring buffer. This patch helps

Re: [PATCH 4/8] dt-bindings/clock: qcom: sm8250: Add gcc clocks for sm8250 crypto block

2021-03-15 Thread Bhupesh Sharma
Hi Stephen, Thanks for the review. On Sun, 14 Mar 2021 at 02:45, Stephen Boyd wrote: > > Quoting Bhupesh Sharma (2021-03-09 21:24:59) > > This patch adds the global clock controller (gcc) clocks required > > $ git grep "This patch" -- Documentation/process/submitting-patches.rst Sure, will fix