Re: [PATCH v3 0/5] amba: minor fix and various cleanups

2021-02-02 Thread Uwe Kleine-König
Hello, we already talked about this via irc, but for the record and the benefit of others: On Tue, Feb 02, 2021 at 10:49:15AM +, Russell King - ARM Linux admin wrote: > I think you need to have a 6th patch which moves the > probe/remove/shutdown methods into the bus_type - if you're setting >

Re: [PATCH] mailbox: arm_mhuv2: make remove callback return void

2021-02-02 Thread Viresh Kumar
On 02-02-21, 20:43, Uwe Kleine-König wrote: > My build tests failed to catch that amba driver that would have needed > adaption in commit 3fd269e74f2f ("amba: Make the remove callback return > void"). Change the remove function to make the driver build again. > > Reported-by: kernel test robot >

Re: [PATCH v3 1/6] drivers: crypto: qce: sha: Restore/save ahash state with custom struct in export/import

2021-02-02 Thread kernel test robot
/scm/linux/kernel/git/herbert/cryptodev-2.6.git master config: arm64-randconfig-r024-20210202 (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross

Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples

2021-02-02 Thread Andrew Jeffery
On Wed, 3 Feb 2021, at 07:25, Rob Herring wrote: > Running 'dt-validate -m' will flag any compatible strings missing a schema. > Fix all the errors found in DT binding examples. Most of these are just > typos. > > Cc: Stephen Boyd > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Cc: Linus Walleij >

Re: [PATCH 0/9] crypto: fix alignmask handling

2021-02-02 Thread Eric Biggers
On Mon, Feb 01, 2021 at 07:02:28PM +0100, Ard Biesheuvel wrote: > Some generic implementations of vintage ciphers rely on alignmasks to > ensure that the input is presented with the right alignment. Given that > these are all C implementations, which may execute on architectures that > don't care a

Re: [GIT PULL] immutable branch for amba changes targeting v5.12-rc1

2021-02-02 Thread Uwe Kleine-König
Hello, On Tue, Feb 02, 2021 at 02:53:50PM +0100, Uwe Kleine-König wrote: > the following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e: > > Linux 5.11-rc1 (2020-12-27 15:30:22 -0800) > > are available in the Git repository at: > > https://git.pengutronix.de/git/ukl/linux tag

Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples

2021-02-02 Thread Guenter Roeck
On 2/2/21 12:55 PM, Rob Herring wrote: > Running 'dt-validate -m' will flag any compatible strings missing a schema. > Fix all the errors found in DT binding examples. Most of these are just > typos. > > Cc: Stephen Boyd > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Cc: Linus Walleij > Cc: Herbert

[PATCH 2/3] dt-bindings: iommu: renesas,ipmmu-vmsa: Make 'power-domains' conditionally required

2021-02-02 Thread Rob Herring
Fixing the compatible string typos results in an error in the example: Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.example.dt.yaml: iommu@fe951000: 'power-domains' is a required property Based on the dts files, a 'power-domains' property only exists on Gen 3 which can be conditio

[PATCH 3/3] dt-bindings: Fix errors in 'if' schemas

2021-02-02 Thread Rob Herring
Properties in if/then schemas weren't getting checked by the meta-schemas. Enabling meta-schema checks finds several errors. The use of an 'items' schema (as opposed to the list form) is wrong in some cases as it applies to all entries. 'contains' is the correct schema to use in the case of multip

[PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples

2021-02-02 Thread Rob Herring
Running 'dt-validate -m' will flag any compatible strings missing a schema. Fix all the errors found in DT binding examples. Most of these are just typos. Cc: Stephen Boyd Cc: Maxime Ripard Cc: Chen-Yu Tsai Cc: Linus Walleij Cc: Herbert Xu Cc: "David S. Miller" Cc: Daniel Palmer Cc: Bartosz

[PATCH] mailbox: arm_mhuv2: make remove callback return void

2021-02-02 Thread Uwe Kleine-König
My build tests failed to catch that amba driver that would have needed adaption in commit 3fd269e74f2f ("amba: Make the remove callback return void"). Change the remove function to make the driver build again. Reported-by: kernel test robot Fixes: 3fd269e74f2f ("amba: Make the remove callback ret

[PATCH AUTOSEL 5.4 05/17] chtls: Fix potential resource leak

2021-02-02 Thread Sasha Levin
From: Pan Bian [ Upstream commit b6011966ac6f402847eb5326beee8da3a80405c7 ] The dst entry should be released if no neighbour is found. Goto label free_dst to fix the issue. Besides, the check of ndev against NULL is redundant. Signed-off-by: Pan Bian Link: https://lore.kernel.org/r/20210121145

[PATCH AUTOSEL 4.19 03/10] chtls: Fix potential resource leak

2021-02-02 Thread Sasha Levin
From: Pan Bian [ Upstream commit b6011966ac6f402847eb5326beee8da3a80405c7 ] The dst entry should be released if no neighbour is found. Goto label free_dst to fix the issue. Besides, the check of ndev against NULL is redundant. Signed-off-by: Pan Bian Link: https://lore.kernel.org/r/20210121145

Re: [PATCH v3 1/3] x509: Detect sm2 keys by their parameters OID

2021-02-02 Thread Jarkko Sakkinen
On Sat, Jan 30, 2021 at 09:57:40PM -0500, Stefan Berger wrote: > On 1/30/21 4:26 PM, Jarkko Sakkinen wrote: > > On Wed, 2021-01-27 at 07:33 -0500, Stefan Berger wrote: > > > From: Stefan Berger > > > > > > Detect whether a key is an sm2 type of key by its OID in the parameters > > > array rather

Re: [GIT PULL] immutable branch for amba changes targeting v5.12-rc1

2021-02-02 Thread Greg Kroah-Hartman
On Tue, Feb 02, 2021 at 02:53:50PM +0100, Uwe Kleine-König wrote: > Hello, > > the following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e: > > Linux 5.11-rc1 (2020-12-27 15:30:22 -0800) > > are available in the Git repository at: > > https://git.pengutronix.de/git/ukl/linux

[GIT PULL] immutable branch for amba changes targeting v5.12-rc1

2021-02-02 Thread Uwe Kleine-König
Hello, the following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e: Linux 5.11-rc1 (2020-12-27 15:30:22 -0800) are available in the Git repository at: https://git.pengutronix.de/git/ukl/linux tags/amba-make-remove-return-void for you to fetch changes up to f170b59fedd733b92

Re: [net-next v2 07/14] octeontx2-pf: cn10k: Use LMTST lines for NPA/NIX operations

2021-02-02 Thread kernel test robot
Hi Geetha, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Geetha-sowjanya/Add-Marvell-CN10K-support/20210202-140820 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git

Re: [net-next v2 07/14] octeontx2-pf: cn10k: Use LMTST lines for NPA/NIX operations

2021-02-02 Thread kernel test robot
Hi Geetha, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Geetha-sowjanya/Add-Marvell-CN10K-support/20210202-140820 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git

Re: [PATCH v7 4/7] crypto: add ecc curve and expose them

2021-02-02 Thread Alessandrelli, Daniele
On Tue, 2021-02-02 at 20:42 +1100, Herbert Xu wrote: > On Tue, Feb 02, 2021 at 09:27:33AM +, Alessandrelli, Daniele > wrote: > > I see. Just to clarify: does the in-kernel user requirement also > > apply > > to the case when the author of a device driver also provides the > > software implement

Re: [PATCH v2] crypto: caam - Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-02-02 Thread Horia Geantă
On 2/2/2021 4:06 AM, Jiapeng Chong wrote: > Fix the following coccicheck warning: > > ./drivers/crypto/caam/debugfs.c:23:0-23: WARNING: caam_fops_u64_ro > should be defined with DEFINE_DEBUGFS_ATTRIBUTE. > > ./drivers/crypto/caam/debugfs.c:22:0-23: WARNING: caam_fops_u32_ro > should be defined wi

Re: [PATCH v3 0/5] amba: minor fix and various cleanups

2021-02-02 Thread Russell King - ARM Linux admin
On Tue, Jan 26, 2021 at 05:58:30PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > Hello, > > Changes since v2 sent with Message-Id: > 20201124133139.3072124-1-...@kleine-koenig.org: > > - Rebase to v5.11-rc1 (which resulted in a few conflicts in >drivers/hwtracing). > - Add var

Re: [PATCH v5 2/4] x509: Detect sm2 keys by their parameters OID

2021-02-02 Thread David Howells
Herbert Xu wrote: > > No idea. It seems straightforward enough, at least on the keyrings side, > > that > > I was going to add it. > > In that case please wait for the discussion on how we handle curves > to be finalised. Sure. Will do. David

Re: [PATCH v5 2/4] x509: Detect sm2 keys by their parameters OID

2021-02-02 Thread Herbert Xu
On Tue, Feb 02, 2021 at 09:33:23AM +, David Howells wrote: > > No idea. It seems straightforward enough, at least on the keyrings side, that > I was going to add it. In that case please wait for the discussion on how we handle curves to be finalised. Thanks, -- Email: Herbert Xu Home Page:

Re: [PATCH v7 4/7] crypto: add ecc curve and expose them

2021-02-02 Thread Herbert Xu
On Tue, Feb 02, 2021 at 09:27:33AM +, Alessandrelli, Daniele wrote: > > I see. Just to clarify: does the in-kernel user requirement also apply > to the case when the author of a device driver also provides the > software implementation for the new algorithms supported by device > driver / HW?

Re: [PATCH v5 2/4] x509: Detect sm2 keys by their parameters OID

2021-02-02 Thread David Howells
Herbert Xu wrote: > > Should I defer it till the next merge window? > > Is there any specific reason why this has to be in the current > one? No idea. It seems straightforward enough, at least on the keyrings side, that I was going to add it. David

Re: [PATCH v7 4/7] crypto: add ecc curve and expose them

2021-02-02 Thread Alessandrelli, Daniele
On Tue, 2021-02-02 at 16:13 +1100, Herbert Xu wrote: > The issue is that we always require a software implementation for > any given hardware algorithm. As otherwise kernel users cannot > rely on the algorithm to work. I understand. This sounds very reasonable to me. > Of course we don't want to

Re: safexcel driver for EIP197 and mini firmware features

2021-02-02 Thread Maciej Pijanowski
On 02.02.2021 09:48, Van Leeuwen, Pascal wrote: Hello Maciej, Hello, -Original Message- From: Maciej Pijanowski Sent: Monday, February 1, 2021 7:53 PM To: linux-crypto@vger.kernel.org Cc: antoine.ten...@bootlin.com; pascalv...@gmail.com; Piotr Król Subject: safexcel driver for EI

RE: safexcel driver for EIP197 and mini firmware features

2021-02-02 Thread Van Leeuwen, Pascal
Hello Maciej, > -Original Message- > From: Maciej Pijanowski > Sent: Monday, February 1, 2021 7:53 PM > To: linux-crypto@vger.kernel.org > Cc: antoine.ten...@bootlin.com; pascalv...@gmail.com; Piotr Król > > Subject: safexcel driver for EIP197 and mini firmware features > > <<< External

Re: [PATCH v5 2/4] x509: Detect sm2 keys by their parameters OID

2021-02-02 Thread Herbert Xu
On Tue, Feb 02, 2021 at 08:27:35AM +, David Howells wrote: > > Should I defer it till the next merge window? Is there any specific reason why this has to be in the current one? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~

Re: [PATCH v5 2/4] x509: Detect sm2 keys by their parameters OID

2021-02-02 Thread David Howells
Herbert Xu wrote: > > Herbert wants the first patch to go through the crypto tree. Maybe all of > > them should proceed by that route if Herbert is willing? > > I'm not actually all that fussed about where it goes through. It's > just the first patch happens to touch an area that is still unde