Re: [PATCH v2] crypto: reduce minimum alignment of on-stack structures

On Fri, 8 Jan 2021 at 22:16, Eric Biggers wrote: > > On Fri, Jan 08, 2021 at 06:17:06PM +0100, Ard Biesheuvel wrote: > > diff --git a/include/crypto/skcipher.h b/include/crypto/skcipher.h > > index 6a733b171a5d..aa133dc3bf39 100644 > > --- a/include/crypto/skcipher.h > > +++ b/include/crypto/skcip

Re: [PATCH v2] crypto: reduce minimum alignment of on-stack structures

On Fri, Jan 08, 2021 at 06:17:06PM +0100, Ard Biesheuvel wrote: > diff --git a/include/crypto/skcipher.h b/include/crypto/skcipher.h > index 6a733b171a5d..aa133dc3bf39 100644 > --- a/include/crypto/skcipher.h > +++ b/include/crypto/skcipher.h > @@ -128,7 +128,7 @@ struct skcipher_alg { >

Re: [GIT PULL] Crypto Fixes for 5.11

The pull request you sent on Fri, 8 Jan 2021 14:54:50 +1100: > git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ea1c87c156d94dd78b4f5267ec40c403b2da7e14 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH] crypto: testmgr - add NIAP FPT_TST_EXT.1 subset of tests

Am Freitag, dem 08.01.2021 um 17:38 + schrieb Elena Petrova: > NIAP FPT_TST_EXT.1 [1] specification requires testing of a small set of > cryptographic modules on boot for devices that need to be NIAP > compliant. This is also a requirement for FIPS CMVP 140-2/140-3 > certification. > > Current

[PATCH v2] crypto: reduce minimum alignment of on-stack structures

Unlike many other structure types defined in the crypto API, the 'shash_desc' structure is permitted to live on the stack, which implies its contents may not be accessed by DMA masters. (This is due to the fact that the stack may be located in the vmalloc area, which requires a different virtual-to

Здравствуйте,

Приветствую тебя, мой друг, надеюсь, ты в порядке, пожалуйста, ответь мне благодаря,

Re: [PATCH 1/6] drivers: crypto: qce: sha: Restore/save sha1_state/sha256_state with qce_sha_reqctx in export/import

On 1/2/21 4:25 PM, Herbert Xu wrote: On Fri, Dec 18, 2020 at 10:30:22PM -0500, Thara Gopinath wrote: Export and import interfaces save and restore partial transformation states. The partial states were being stored and restored in struct sha1_state for sha1/hmac(sha1) transformations and sha2

Re: [PATCH] crypto - shash: reduce minimum alignment of shash_desc structure

On Fri, 8 Jan 2021 at 11:59, Arnd Bergmann wrote: > > On Fri, Jan 8, 2021 at 11:44 AM Herbert Xu > wrote: > > > > On Fri, Jan 08, 2021 at 11:42:53AM +0100, Arnd Bergmann wrote: > > > > > > How does this work for kernels with CONFIG_VMAP_STACK? > > > I remember some other subsystems (usb, hid) ad

Re: [PATCH] crypto - shash: reduce minimum alignment of shash_desc structure

On Fri, Jan 8, 2021 at 11:44 AM Herbert Xu wrote: > > On Fri, Jan 08, 2021 at 11:42:53AM +0100, Arnd Bergmann wrote: > > > > How does this work for kernels with CONFIG_VMAP_STACK? > > I remember some other subsystems (usb, hid) adding workarounds > > for that, but I don't see those in drivers/cryp

Re: [PATCH] crypto - shash: reduce minimum alignment of shash_desc structure

On Fri, Jan 08, 2021 at 11:42:53AM +0100, Arnd Bergmann wrote: > > How does this work for kernels with CONFIG_VMAP_STACK? > I remember some other subsystems (usb, hid) adding workarounds > for that, but I don't see those in drivers/crypto I'm referring to the situation in general and not the subje

Re: [PATCH] crypto - shash: reduce minimum alignment of shash_desc structure

On Fri, Jan 8, 2021 at 10:22 AM Herbert Xu wrote: > > On Fri, Jan 08, 2021 at 09:36:23AM +0100, Ard Biesheuvel wrote: > > > > scatterlists, and I don't think we permit pointing the scatterlist > > into request structures) > > Not only do we allow that, we do that in lots of places. How does this

Re: [PATCH] crypto - shash: reduce minimum alignment of shash_desc structure

On Fri, 8 Jan 2021 at 10:23, Herbert Xu wrote: > > On Fri, Jan 08, 2021 at 09:36:23AM +0100, Ard Biesheuvel wrote: > > > > scatterlists, and I don't think we permit pointing the scatterlist > > into request structures) > > Not only do we allow that, we do that in lots of places. > Fair enough. So

Re: [PATCH] crypto - shash: reduce minimum alignment of shash_desc structure

On Fri, Jan 08, 2021 at 09:36:23AM +0100, Ard Biesheuvel wrote: > > scatterlists, and I don't think we permit pointing the scatterlist > into request structures) Not only do we allow that, we do that in lots of places. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/

Re: drivers/char/random.c needs a (new) maintainer

Pavel Machek wrote: > To play devil's advocate, does RNG subsystem need to evolve? Its task > is to get random numbers. Does it fail at the task? > > Problem is, random subsystem is hard to verify, and big rewrite is > likely to cause security problems... Parts of the problem, though, are dead e

Re: [PATCH] crypto - shash: reduce minimum alignment of shash_desc structure

On Thu, 7 Jan 2021 at 20:02, Eric Biggers wrote: > > On Thu, Jan 07, 2021 at 01:41:28PM +0100, Ard Biesheuvel wrote: > > Unlike many other structure types defined in the crypto API, the > > 'shash_desc' structure is permitted to live on the stack, which > > implies its contents may not be accessed

Re: [PATCH 05/10] dma: tx49 removal

On 07-01-21, 17:40, Thomas Bogendoerfer wrote: > On Wed, Jan 06, 2021 at 11:10:38AM -0800, Joe Perches wrote: > > On Tue, 2021-01-05 at 15:02 +0100, Thomas Bogendoerfer wrote: > > > Signed-off-by: Thomas Bogendoerfer > > [] > > > diff --git a/drivers/dma/txx9dmac.h b/drivers/dma/txx9dmac.h > > []