Re: [RFC PATCH 0/4] crypto: add CRYPTO_TFM_REQ_DMA flag

2020-12-07 Thread Ard Biesheuvel
On Mon, 7 Dec 2020 at 14:50, Horia Geantă wrote: > > On 11/26/2020 9:09 AM, Ard Biesheuvel wrote: > > On Wed, 25 Nov 2020 at 22:39, Iuliana Prodan wrote: > >> > >> On 11/25/2020 11:16 PM, Ard Biesheuvel wrote: > >>> On Wed, 25 Nov 2020 at 22:14, Iuliana Prodan (OSS) > >>> wrote: > > Fr

Re: (subset) [PATCH 000/141] Fix fall-through warnings for Clang

2020-12-07 Thread Martin K. Petersen
On Fri, 20 Nov 2020 12:21:39 -0600, Gustavo A. R. Silva wrote: > This series aims to fix almost all remaining fall-through warnings in > order to enable -Wimplicit-fallthrough for Clang. > > In preparation to enable -Wimplicit-fallthrough for Clang, explicitly > add multiple break/goto/return/fal

[PATCH v2] crypto: aes-ni - implement support for cts(cbc(aes))

2020-12-07 Thread Ard Biesheuvel
Follow the same approach as the arm64 driver for implementing a version of AES-NI in CBC mode that supports ciphertext stealing. This results in a ~2x speed increase for relatively short inputs (less than 256 bytes), which is relevant given that AES-CBC with ciphertext stealing is used for filename

Re: [PATCH] crypto: aes-ni - implement support for cts(cbc(aes))

2020-12-07 Thread Ard Biesheuvel
On Mon, 7 Dec 2020 at 19:46, Eric Biggers wrote: > > On Sun, Dec 06, 2020 at 11:45:23PM +0100, Ard Biesheuvel wrote: > > Follow the same approach as the arm64 driver for implementing a version > > of AES-NI in CBC mode that supports ciphertext stealing. Compared to the > > generic CTS template wra

Re: [Patch v2 6/6] dt-bindings: crypto: qcom-qce: Add v5.4 to binding

2020-12-07 Thread Rob Herring
On Thu, Nov 19, 2020 at 10:52:33AM -0500, Thara Gopinath wrote: > Add compatible string to support v5.4 crypto engine. > > Signed-off-by: Thara Gopinath > Reviewed-by: Bjorn Andersson > --- > Documentation/devicetree/bindings/crypto/qcom-qce.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 de

Re: [PATCH] crypto: aes-ni - implement support for cts(cbc(aes))

2020-12-07 Thread Eric Biggers
On Sun, Dec 06, 2020 at 11:45:23PM +0100, Ard Biesheuvel wrote: > Follow the same approach as the arm64 driver for implementing a version > of AES-NI in CBC mode that supports ciphertext stealing. Compared to the > generic CTS template wrapped around the existing cbc-aes-aesni skcipher, > this resu

Re: [PATCH] MAINTAINERS: crypto: s5p-sss: drop Kamil Konieczny

2020-12-07 Thread Vladimir Zapolskiy
On 12/7/20 6:55 PM, Krzysztof Kozlowski wrote: E-mails to Kamil Konieczny to his Samsung address bounce with 550 (User unknown). Kamil no longer takes care about Samsung S5P SSS driver so remove the invalid email address from: - mailmap, - bindings maintainer entries, - maintainers entry f

[PATCH] MAINTAINERS: crypto: s5p-sss: drop Kamil Konieczny

2020-12-07 Thread Krzysztof Kozlowski
E-mails to Kamil Konieczny to his Samsung address bounce with 550 (User unknown). Kamil no longer takes care about Samsung S5P SSS driver so remove the invalid email address from: - mailmap, - bindings maintainer entries, - maintainers entry for S5P Security Subsystem crypto accelerator. Signe

Re: crypto: sun4i-ss: error with kmap

2020-12-07 Thread Thomas Gleixner
On Mon, Dec 07 2020 at 13:18, Corentin Labbe wrote: > On Mon, Dec 07, 2020 at 01:15:49AM +0100, Thomas Gleixner wrote: > So if I understand correctly, basicly I cannot have two atomic kmap at > the same time since it made unmapping them in the right order complex. You can, but the ordering has to

Re: Why the auxiliary cipher in gss_krb5_crypto.c?

2020-12-07 Thread David Howells
Ard Biesheuvel wrote: > > I wonder if it would help if the input buffer and output buffer didn't > > have to correspond exactly in usage - ie. the output buffer could be used > > at a slower rate than the input to allow for buffering inside the crypto > > algorithm. > > > > I don't follow - how

Re: [RFC PATCH 0/4] crypto: add CRYPTO_TFM_REQ_DMA flag

2020-12-07 Thread Horia Geantă
On 11/26/2020 9:09 AM, Ard Biesheuvel wrote: > On Wed, 25 Nov 2020 at 22:39, Iuliana Prodan wrote: >> >> On 11/25/2020 11:16 PM, Ard Biesheuvel wrote: >>> On Wed, 25 Nov 2020 at 22:14, Iuliana Prodan (OSS) >>> wrote: From: Iuliana Prodan Add the option to allocate the crypto

[PATCH v2] xfrm: interface: Don't hide plain packets from netfilter

2020-12-07 Thread Phil Sutter
With an IPsec tunnel without dedicated interface, netfilter sees locally generated packets twice as they exit the physical interface: Once as "the inner packet" with IPsec context attached and once as the encrypted (ESP) packet. With xfrm_interface, the inner packet did not traverse NF_INET_LOCAL_

Re: [PATCH] xfrm: interface: Don't hide plain packets from netfilter

2020-12-07 Thread Steffen Klassert
On Mon, Dec 07, 2020 at 02:03:03PM +0100, Phil Sutter wrote: > With an IPsec tunnel without dedicated interface, netfilter sees locally > generated packets twice as they exit the physical interface: Once as "the > inner packet" with IPsec context attached and once as the encrypted > (ESP) packet. >

[PATCH] xfrm: interface: Don't hide plain packets from netfilter

2020-12-07 Thread Phil Sutter
With an IPsec tunnel without dedicated interface, netfilter sees locally generated packets twice as they exit the physical interface: Once as "the inner packet" with IPsec context attached and once as the encrypted (ESP) packet. With xfrm_interface, the inner packet did not traverse NF_INET_LOCAL_

Re: Why the auxiliary cipher in gss_krb5_crypto.c?

2020-12-07 Thread Ard Biesheuvel
On Mon, 7 Dec 2020 at 13:02, David Howells wrote: > > Ard Biesheuvel wrote: > > > > Yeah - the problem with that is that for sunrpc, we might be dealing with > > > 1MB > > > plus bits of non-contiguous pages, requiring >8K of scatterlist elements > > > (admittedly, we can chain them, but we may

Re: XFRM interface and NF_INET_LOCAL_OUT hook

2020-12-07 Thread Nicolas Dichtel
Le 02/12/2020 à 14:18, Steffen Klassert a écrit : > On Fri, Nov 27, 2020 at 03:10:48PM +0100, Phil Sutter wrote: [snip] >> diff --git a/net/xfrm/xfrm_interface.c b/net/xfrm/xfrm_interface.c >> index aa4cdcf69d471..24af61c95b4d4 100644 >> --- a/net/xfrm/xfrm_interface.c >> +++ b/net/xfrm/xfrm_interf

Re: XFRM interface and NF_INET_LOCAL_OUT hook

2020-12-07 Thread Phil Sutter
Hi Steffen, On Wed, Dec 02, 2020 at 02:18:47PM +0100, Steffen Klassert wrote: > On Fri, Nov 27, 2020 at 03:10:48PM +0100, Phil Sutter wrote: [...] > > diff --git a/net/xfrm/xfrm_interface.c b/net/xfrm/xfrm_interface.c > > index aa4cdcf69d471..24af61c95b4d4 100644 > > --- a/net/xfrm/xfrm_interface.

Re: crypto: sun4i-ss: error with kmap

2020-12-07 Thread Corentin Labbe
On Mon, Dec 07, 2020 at 01:15:49AM +0100, Thomas Gleixner wrote: > On Sun, Dec 06 2020 at 22:40, Corentin Labbe wrote: > > On Sat, Dec 05, 2020 at 08:48:15PM +0100, Thomas Gleixner wrote: > >> So this maps two pages and unmaps the first one. That's all called from > >> sun4i_ss_opti_poll() and the

Re: Why the auxiliary cipher in gss_krb5_crypto.c?

2020-12-07 Thread David Howells
Ard Biesheuvel wrote: > > Yeah - the problem with that is that for sunrpc, we might be dealing with > > 1MB > > plus bits of non-contiguous pages, requiring >8K of scatterlist elements > > (admittedly, we can chain them, but we may have to do one or more large > > allocations). > > > > > However

Re: XFRM interface and NF_INET_LOCAL_OUT hook

2020-12-07 Thread Steffen Klassert
On Fri, Nov 27, 2020 at 03:10:48PM +0100, Phil Sutter wrote: > On Fri, Nov 27, 2020 at 10:55:11AM +0100, Steffen Klassert wrote: > > On Thu, Nov 26, 2020 at 02:12:00PM +0100, Phil Sutter wrote: > > > > > > > > > > Is this a bug or an expected quirk when using XFRM interface? > > > > > > > > This

Re: [RESEND 17/19] crypto: s5p: convert tasklets to use new tasklet_setup() API

2020-12-07 Thread Krzysztof Kozlowski
On Mon, Dec 07, 2020 at 02:29:29PM +0530, Allen Pais wrote: > From: Allen Pais > > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. Wrap

Re: [RESEND 00/19] crypto: convert tasklets to use new tasklet_setup API()

2020-12-07 Thread Krzysztof Kozlowski
On Mon, Dec 07, 2020 at 02:29:12PM +0530, Allen Pais wrote: > From: Allen Pais > > Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")' > introduced a new tasklet initialization API. This series converts > all the crypto modules to use the new tasklet_setup() API Please use the scr

[RESEND 19/19] crypto: octeontx: convert tasklets to use new tasklet_setup() API

2020-12-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Allen Pais --- drivers/crypto/marvell/octeontx/otx_cptvf_mai

[RESEND 18/19] crypto: talitos: convert tasklets to use new tasklet_setup() API

2020-12-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/crypto/

[RESEND 17/19] crypto: s5p: convert tasklets to use new tasklet_setup() API

2020-12-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/crypto/

[RESEND 11/19] crypto: mediatek: convert tasklets to use new tasklet_setup() API

2020-12-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/crypto/

[RESEND 15/19] crypto: qce: convert tasklets to use new tasklet_setup() API

2020-12-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/crypto/

[RESEND 16/19] crypto: rockchip: convert tasklets to use new tasklet_setup() API

2020-12-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/crypto/

[RESEND 14/19] crypto: qat: convert tasklets to use new tasklet_setup() API

2020-12-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/crypto/

[RESEND 13/19] crypto: picoxcell: convert tasklets to use new tasklet_setup() API

2020-12-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/crypto/

[RESEND 10/19] crypto: ixp4xx: convert tasklets to use new tasklet_setup() API

2020-12-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/crypto/

[RESEND 09/19] crypto: img-hash: convert tasklets to use new tasklet_setup() API

2020-12-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/crypto/

[RESEND 12/19] crypto: omap: convert tasklets to use new tasklet_setup() API

2020-12-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/crypto/

[RESEND 08/19] crypto: hifn_795x: convert tasklets to use new tasklet_setup() API

2020-12-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/crypto/

[RESEND 07/19] crypto: ccree: convert tasklets to use new tasklet_setup() API

2020-12-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/crypto/

[RESEND 04/19] crypto: caam: convert tasklets to use new tasklet_setup() API

2020-12-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/crypto/

[RESEND 06/19] crypto: ccp: convert tasklets to use new tasklet_setup() API

2020-12-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/crypto/

[RESEND 05/19] crypto: cavium: convert tasklets to use new tasklet_setup() API

2020-12-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/crypto/

[RESEND 02/19] crypto: atmel: convert tasklets to use new tasklet_setup() API

2020-12-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/crypto/

[RESEND 00/19] crypto: convert tasklets to use new tasklet_setup API()

2020-12-07 Thread Allen Pais
From: Allen Pais Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")' introduced a new tasklet initialization API. This series converts all the crypto modules to use the new tasklet_setup() API The series is based on 5.10-rc6 (b65054597872) Allen Pais (19): crypto: amcc: convert

[RESEND 01/19] crypto: amcc: convert tasklets to use new tasklet_setup() API

2020-12-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/crypto/

[RESEND 03/19] crypto: axis: convert tasklets to use new tasklet_setup() API

2020-12-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/crypto/

Re: [PATCH 2/5] crypto: hisilicon/sec - add new type of sqe for Kunpeng930

2020-12-07 Thread liulongfang
On 2020/12/7 15:47, Herbert Xu Wrote: > On Mon, Dec 07, 2020 at 03:46:28PM +0800, liulongfang wrote: >> >> I need to use "__packed __aligned(n)" to make sure the structure length is >> normal. >> Is it possible to use "__packed __aligned(n)" in the kernel? > > I don't see why not. > > Cheers,

Re: Why the auxiliary cipher in gss_krb5_crypto.c?

2020-12-07 Thread David Howells
Herbert Xu wrote: > > Herbert recently made some changes for MSG_MORE support in the AF_ALG > > code, which permits a skcipher encryption to be split into several > > invocations of the skcipher layer without the need for this complexity > > on the side of the caller. Maybe there is a way to reus

[PATCH] crypto: mediatek - remove obsolete driver

2020-12-07 Thread Vic Wu
The crypto mediatek driver has been replaced by the inside-secure driver now. Remove this driver to avoid having duplicate drivers. Signed-off-by: Vic Wu Acked-by: Ryder Lee --- drivers/crypto/Kconfig | 15 - drivers/crypto/Makefile|1 - drivers/crypto/medi