Re: [PATCH 2/5] crypto: hisilicon/sec - add new type of sqe for Kunpeng930

2020-12-06 Thread Herbert Xu
On Mon, Dec 07, 2020 at 03:46:28PM +0800, liulongfang wrote: > > I need to use "__packed __aligned(n)" to make sure the structure length is > normal. > Is it possible to use "__packed __aligned(n)" in the kernel? I don't see why not. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.

Re: [PATCH 2/5] crypto: hisilicon/sec - add new type of sqe for Kunpeng930

2020-12-06 Thread liulongfang
On 2020/12/7 11:45, Herbert Xu Wrote: > On Mon, Dec 07, 2020 at 11:43:38AM +0800, liulongfang wrote: >> >> Can I use __attribute__((aligned(n))) instead of #pragma pack(n)? > > We normally just use __aligned(n) in the kernel. > > Cheers, > I need to use "__packed __aligned(n)" to make sure the

Re: [PATCH 2/5] crypto: hisilicon/sec - add new type of sqe for Kunpeng930

2020-12-06 Thread Herbert Xu
On Mon, Dec 07, 2020 at 11:43:38AM +0800, liulongfang wrote: > > Can I use __attribute__((aligned(n))) instead of #pragma pack(n)? We normally just use __aligned(n) in the kernel. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~h

Re: [PATCH 2/5] crypto: hisilicon/sec - add new type of sqe for Kunpeng930

2020-12-06 Thread liulongfang
On 2020/12/4 15:03, Herbert Xu Wrote: > On Thu, Nov 26, 2020 at 10:18:03AM +0800, Longfang Liu wrote: >> >> diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.h >> b/drivers/crypto/hisilicon/sec2/sec_crypto.h >> index 0e933e7..712176b 100644 >> --- a/drivers/crypto/hisilicon/sec2/sec_crypto.h

Re: [PATCH 0/5] crypto: hisilicon - add some new algorithms

2020-12-06 Thread liulongfang
On 2020/12/7 9:33, Herbert Xu wrote: > On Mon, Dec 07, 2020 at 09:20:05AM +0800, liulongfang wrote: >> >> Did any test case tests fail? > > You tell me :) > > If it passed all of the tests in your testing, please state that > in the cover letter or in one of the patches. > > Thanks, > OK, I wil

Re: [PATCH 0/5] crypto: hisilicon - add some new algorithms

2020-12-06 Thread Herbert Xu
On Mon, Dec 07, 2020 at 09:20:05AM +0800, liulongfang wrote: > > Did any test case tests fail? You tell me :) If it passed all of the tests in your testing, please state that in the cover letter or in one of the patches. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbe

Re: [PATCH 0/5] crypto: hisilicon - add some new algorithms

2020-12-06 Thread liulongfang
On 2020/12/4 15:05, Herbert Xu wrote: > On Thu, Nov 26, 2020 at 10:18:01AM +0800, Longfang Liu wrote: >> As the new Kunpeng930 supports some new algorithms, >> the driver needs to be updated >> >> Longfang Liu (4): >> crypto: hisilicon/sec - add new type of sqe for Kunpeng930 >> crypto: hisilic

Re: [PATCH 2/5] crypto: hisilicon/sec - add new type of sqe for Kunpeng930

2020-12-06 Thread liulongfang
On 2020/12/4 15:03, Herbert Xu Wrote: > On Thu, Nov 26, 2020 at 10:18:03AM +0800, Longfang Liu wrote: >> >> diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.h >> b/drivers/crypto/hisilicon/sec2/sec_crypto.h >> index 0e933e7..712176b 100644 >> --- a/drivers/crypto/hisilicon/sec2/sec_crypto.h >

Re: crypto: sun4i-ss: error with kmap

2020-12-06 Thread Thomas Gleixner
On Sun, Dec 06 2020 at 22:40, Corentin Labbe wrote: > On Sat, Dec 05, 2020 at 08:48:15PM +0100, Thomas Gleixner wrote: >> So this maps two pages and unmaps the first one. That's all called from >> sun4i_ss_opti_poll() and the bug is clearly visible there: >> >> sg_miter_next(&mi); >> sg_

[PATCH] crypto: aes-ni - implement support for cts(cbc(aes))

2020-12-06 Thread Ard Biesheuvel
Follow the same approach as the arm64 driver for implementing a version of AES-NI in CBC mode that supports ciphertext stealing. Compared to the generic CTS template wrapped around the existing cbc-aes-aesni skcipher, this results in a ~2x speed increase for relatively short inputs (less than 256 b

Re: crypto: sun4i-ss: error with kmap

2020-12-06 Thread Corentin Labbe
On Sat, Dec 05, 2020 at 08:48:15PM +0100, Thomas Gleixner wrote: > Corentin, > > On Sat, Dec 05 2020 at 19:43, Corentin Labbe wrote: > > On Fri, Dec 04, 2020 at 09:58:21PM +0100, Thomas Gleixner wrote: > >> Can you please replace the debug patch with the one below and try again? > >> That stops th