Re: ks-sa-rng.c:undefined reference to `devm_platform_ioremap_resource'

2020-11-26 Thread Alexander Sverdlin
Hi! On 27/11/2020 06:48, Herbert Xu wrote: > On Fri, Nov 13, 2020 at 11:02:13PM +0800, kernel test robot wrote: >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >> master >> head: 585e5b17b92dead8a3aca4e3c9876fbca5f7e0ba >> commit: 90c4b29eb1e555fee66f8329a18cb8a070

Re: [PATCH v3] crypto: ccree - rework cache parameters handling

2020-11-26 Thread Herbert Xu
On Sun, Nov 22, 2020 at 09:51:53AM +0200, Gilad Ben-Yossef wrote: > Rework the setting of DMA cache parameters, program more appropriate > values and explicitly set sharability domain. > > Signed-off-by: Gilad Ben-Yossef > --- > > Changes from previous versions: > - After discussion with Rob H.,

Re: [PATCH] crypto: cavium - Use dma_set_mask_and_coherent to simplify code

2020-11-26 Thread Herbert Xu
On Sat, Nov 21, 2020 at 08:56:47AM +0100, Christophe JAILLET wrote: > 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by > an equivalent 'dma_set_mask_and_coherent()' which is much less verbose. > > Signed-off-by: Christophe JAILLET > --- > drivers/crypto/cavium/cpt/cptpf_

Re: [PATCH] crypto: marvell/octeontx - Use dma_set_mask_and_coherent to simplify code

2020-11-26 Thread Herbert Xu
On Sat, Nov 21, 2020 at 08:49:16AM +0100, Christophe JAILLET wrote: > 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by > an equivalent 'dma_set_mask_and_coherent()' which is much less verbose. > > Signed-off-by: Christophe JAILLET > --- > drivers/crypto/marvell/octeontx/

Re: [PATCH] crypto: cavium/zip - Use dma_set_mask_and_coherent to simplify code

2020-11-26 Thread Herbert Xu
On Sat, Nov 21, 2020 at 08:31:31AM +0100, Christophe JAILLET wrote: > 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by > an equivalent 'dma_set_mask_and_coherent()' which is much less verbose. > > Signed-off-by: Christophe JAILLET > --- > drivers/crypto/cavium/zip/zip_ma

Re: [PATCH 075/141] crypto: ccree - Fix fall-through warnings for Clang

2020-11-26 Thread Herbert Xu
On Fri, Nov 20, 2020 at 12:34:56PM -0600, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple break statements instead of > letting the code fall through to the next case. > > Link: https://github.com/KSPP/li

Re: [PATCH 0/4] crypto: hisilicon/trng - add HiSilicon TRNG driver support

2020-11-26 Thread Herbert Xu
On Fri, Nov 20, 2020 at 04:56:59PM +0800, Weili Qian wrote: > 1. Move HiSilicon TRNG driver form 'drivers/char/hw_random/' >to 'drivers/crypto/hisilicon/'. > 2. Add support for PRNG in Crypto subsystem. > > Weili Qian (4): > hwrng: hisi - remove HiSilicon TRNG driver > crypto: hisilicon/tr

Re: [PATCH v2 0/3] crypto: tcrypt enhancements

2020-11-26 Thread Herbert Xu
On Fri, Nov 20, 2020 at 12:04:30PM +0100, Ard Biesheuvel wrote: > Some tcrypt enhancements that I have been using locally to test and > benchmark crypto algorithms on the command line using KVM: > - allow tcrypt.ko to be builtin and defer its initialization to late_initcall > - add 1420 byte blocks

Re: [PATCH RESEND] crypto: qat - fix excluded_middle.cocci warnings

2020-11-26 Thread Herbert Xu
On Thu, Nov 19, 2020 at 10:25:19PM +, Giovanni Cabiddu wrote: > > Condition !A || A && B is equivalent to !A || B. > > Generated by: scripts/coccinelle/misc/excluded_middle.cocci > > Fixes: b76f0ea01312 ("coccinelle: misc: add excluded_middle.cocci script") > CC: Denis Efremov > Reported-by

Re: [PATCH v3 0/4] crypto: aegis128 enhancements

2020-11-26 Thread Herbert Xu
On Tue, Nov 17, 2020 at 02:32:10PM +0100, Ard Biesheuvel wrote: > This series supersedes [0] '[PATCH] crypto: aegis128/neon - optimize tail > block handling', which is included as patch #3 here, but hasn't been > modified substantially. > > Patch #1 should probably go to -stable, even though aegis

Re: [Patch v2 0/6] Enable Qualcomm Crypto Engine on sdm845

2020-11-26 Thread Herbert Xu
On Thu, Nov 19, 2020 at 10:52:27AM -0500, Thara Gopinath wrote: > Qualcomm crypto engine supports hardware accelerated algorithms for > encryption and authentication. Enable support for aes,des,3des encryption > algorithms and sha1,sha256, hmac(sha1),hmac(sha256) authentication > algorithms on sdm8

[PATCH] crypto: cpt - Fix sparse warnings in cptpf

2020-11-26 Thread Herbert Xu
This patch fixes a few sparse warnings that were missed in the last round. Signed-off-by: Herbert Xu diff --git a/drivers/crypto/cavium/cpt/cptpf_main.c b/drivers/crypto/cavium/cpt/cptpf_main.c index 24d63bdc5dd2..711b1acdd4e0 100644 --- a/drivers/crypto/cavium/cpt/cptpf_main.c +++ b/drivers/cr

Re: [PATCH v3 6/7] crypto: sun4i-ss: enabled stats via debugfs

2020-11-26 Thread Herbert Xu
On Mon, Nov 16, 2020 at 01:53:44PM +, Corentin Labbe wrote: > > +#ifdef CONFIG_CRYPTO_DEV_SUN4I_SS_DEBUG > + /* Ignore error of debugfs */ > + ss->dbgfs_dir = debugfs_create_dir("sun4i-ss", NULL); > + ss->dbgfs_stats = debugfs_create_file("stats", 0444, ss->dbgfs_dir, ss, > +

Re: ks-sa-rng.c:undefined reference to `devm_platform_ioremap_resource'

2020-11-26 Thread Herbert Xu
On Fri, Nov 13, 2020 at 11:02:13PM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 585e5b17b92dead8a3aca4e3c9876fbca5f7e0ba > commit: 90c4b29eb1e555fee66f8329a18cb8a070090ad6 hwrng: ks-sa - Enable > COMPILE_TEST > dat

[PATCH] hwrng: ks-sa - Add dependency on IOMEM and OF

2020-11-26 Thread Herbert Xu
Resent with fixed Subject line. ---8<--- This patch adds a dependency for KEYSTONE on HAS_IOMEM and OF to prevent COMPILE_TEST build failures. Reported-by: kernel test robot Signed-off-by: Herbert Xu diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig index ab33a2e17cd

[v2 PATCH] crypto: lib/blake2s - Move selftest prototype into header file

2020-11-26 Thread Herbert Xu
v2 Actually include the header file. ---8<--- This patch fixes a missing prototype warning on blake2s_selftest. Reported-by: kernel test robot Signed-off-by: Herbert Xu diff --git a/include/crypto/internal/blake2s.h b/include/crypto/internal/blake2s.h index 74ff77032e52..6e376ae6b6b5 100644

[PATCH] crypto: lib/blake2s - Move selftest prototype into header file

2020-11-26 Thread Herbert Xu
On Fri, Nov 13, 2020 at 04:02:28PM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 585e5b17b92dead8a3aca4e3c9876fbca5f7e0ba > commit: 66d7fb94e4ffe5acc589e0b2b4710aecc1f07a28 crypto: blake2s - generic C > library impl

Re: [RFC][PATCH 00/18] crypto: Add generic Kerberos library

2020-11-26 Thread Herbert Xu
On Thu, Nov 26, 2020 at 08:19:41AM +, David Howells wrote: > > I haven't done that yet. Sorry, I should've been more explicit with what I > was after. I was wanting to find out if the nfs/nfsd people are okay with > this (and if there are any gotchas I should know about - it turns out, if I >

Re: [PATCH] crypto: qat - Use dma_set_mask_and_coherent to simplify code

2020-11-26 Thread Christophe JAILLET
Le 26/11/2020 à 13:04, Giovanni Cabiddu a écrit : Hi Christophe, On Sat, Nov 21, 2020 at 07:13:59AM +, Christophe JAILLET wrote: 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by an equivalent 'dma_set_mask_and_coherent()' which is much less verbose. While at it, al

Re: [RFC PATCH 0/4] crypto: add CRYPTO_TFM_REQ_DMA flag

2020-11-26 Thread Iuliana Prodan
On 11/26/2020 7:12 PM, Ard Biesheuvel wrote: On Thu, 26 Nov 2020 at 17:00, Iuliana Prodan wrote: On 11/26/2020 9:09 AM, Ard Biesheuvel wrote: On Wed, 25 Nov 2020 at 22:39, Iuliana Prodan wrote: On 11/25/2020 11:16 PM, Ard Biesheuvel wrote: On Wed, 25 Nov 2020 at 22:14, Iuliana Prodan (OSS

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-26 Thread Miguel Ojeda
On Thu, Nov 26, 2020 at 4:28 PM Geert Uytterhoeven wrote: > > The maintainer is not necessarily the owner/author of the code, and > thus may not know the intent of the code. Agreed, I was not blaming maintainers -- just trying to point out that the problem is there :-) In those cases, it is stil

Re: [RFC PATCH 0/4] crypto: add CRYPTO_TFM_REQ_DMA flag

2020-11-26 Thread Ard Biesheuvel
On Thu, 26 Nov 2020 at 17:00, Iuliana Prodan wrote: > > On 11/26/2020 9:09 AM, Ard Biesheuvel wrote: > > On Wed, 25 Nov 2020 at 22:39, Iuliana Prodan wrote: > >> > >> On 11/25/2020 11:16 PM, Ard Biesheuvel wrote: > >>> On Wed, 25 Nov 2020 at 22:14, Iuliana Prodan (OSS) > >>> wrote: > >

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-26 Thread Karol Herbst
On Thu, Nov 26, 2020 at 4:28 PM Geert Uytterhoeven wrote: > > Hi Miguel, > > On Thu, Nov 26, 2020 at 3:54 PM Miguel Ojeda > wrote: > > On Wed, Nov 25, 2020 at 11:44 PM Edward Cree wrote: > > > To make the intent clear, you have to first be certain that you > > > understand the intent; otherwise

Re: [RFC PATCH 0/4] crypto: add CRYPTO_TFM_REQ_DMA flag

2020-11-26 Thread Iuliana Prodan
On 11/26/2020 9:09 AM, Ard Biesheuvel wrote: On Wed, 25 Nov 2020 at 22:39, Iuliana Prodan wrote: On 11/25/2020 11:16 PM, Ard Biesheuvel wrote: On Wed, 25 Nov 2020 at 22:14, Iuliana Prodan (OSS) wrote: From: Iuliana Prodan Add the option to allocate the crypto request object plus any extr

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-26 Thread Geert Uytterhoeven
Hi Miguel, On Thu, Nov 26, 2020 at 3:54 PM Miguel Ojeda wrote: > On Wed, Nov 25, 2020 at 11:44 PM Edward Cree wrote: > > To make the intent clear, you have to first be certain that you > > understand the intent; otherwise by adding either a break or a > > fallthrough to suppress the warning yo

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-26 Thread Miguel Ojeda
On Wed, Nov 25, 2020 at 11:44 PM Edward Cree wrote: > > To make the intent clear, you have to first be certain that you > understand the intent; otherwise by adding either a break or a > fallthrough to suppress the warning you are just destroying the > information that "the intent of this code

Re: XFRM interface and NF_INET_LOCAL_OUT hook

2020-11-26 Thread Phil Sutter
Hi Steffen, On Thu, Nov 26, 2020 at 10:40:21AM +0100, Steffen Klassert wrote: > On Wed, Nov 25, 2020 at 12:23:42PM +0100, Phil Sutter wrote: > > I am working on a ticket complaining about netfilter policy match > > missing packets in OUTPUT chain if XFRM interface is being used. > > > > I don't f

Re: [PATCH] crypto: qat - Use dma_set_mask_and_coherent to simplify code

2020-11-26 Thread Giovanni Cabiddu
Hi Christophe, On Sat, Nov 21, 2020 at 07:13:59AM +, Christophe JAILLET wrote: > 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by > an equivalent 'dma_set_mask_and_coherent()' which is much less verbose. > > While at it, also remove some unless extra () in the 32 bits

[PATCH 2/2] crypto: keembay-ocs-aes: Add support for Keem Bay OCS AES/SM4

2020-11-26 Thread Daniele Alessandrelli
From: Mike Healy Add support for the AES/SM4 crypto engine included in the Offload and Crypto Subsystem (OCS) of the Intel Keem Bay SoC, thus enabling hardware-acceleration for the following transformations: - ecb(aes), cbc(aes), ctr(aes), cts(cbc(aes)), gcm(aes) and cbc(aes); supported for 12

[PATCH 1/2] dt-bindings: Add Keem Bay OCS AES bindings

2020-11-26 Thread Daniele Alessandrelli
From: Daniele Alessandrelli Add device-tree bindings for Intel Keem Bay Offload and Crypto Subsystem (OCS) AES crypto driver. Signed-off-by: Daniele Alessandrelli Acked-by: Mark Gross --- .../crypto/intel,keembay-ocs-aes.yaml | 45 +++ 1 file changed, 45 insertions(+)

[PATCH 0/2] crypto: Add Keem Bay OCS AES/SM4 driver

2020-11-26 Thread Daniele Alessandrelli
The Intel Keem Bay SoC has an Offload Crypto Subsystem (OCS) featuring a crypto engine for accelerating AES/SM4 operations. This driver adds support for such hardware thus enabling hardware acceleration for the following transformations on the Intel Keem Bay SoC: - ecb(aes), cbc(aes), ctr(aes), c

Re: XFRM interface and NF_INET_LOCAL_OUT hook

2020-11-26 Thread Steffen Klassert
Hi Phil, On Wed, Nov 25, 2020 at 12:23:42PM +0100, Phil Sutter wrote: > Hi Steffen, > > I am working on a ticket complaining about netfilter policy match > missing packets in OUTPUT chain if XFRM interface is being used. > > I don't fully overlook the relevant code path, but it seems like > skb_

Re: [RFC][PATCH 00/18] crypto: Add generic Kerberos library

2020-11-26 Thread David Howells
Herbert Xu wrote: > > Here's my first cut at a generic Kerberos crypto library in the kernel so > > that I can share code between rxrpc and sunrpc (and cifs?). > > I can't find the bit where you are actually sharing this code with > sunrpc, am I missing something? I haven't done that yet. Sorr