Re: [PATCH] crypto: cavium/nitrox: add an error message to explain the failure of pci_request_mem_regions

2020-08-28 Thread George Acosta
Hi Herbert, I just noticed a small potential issue about the calling sequence of pci_disable_device and dev_err. Do you think it will be better to call dev_err before we call pci_disable_device(pdev) , or the order here does not matter? On Fri, Aug 28, 2020 at 2:19 AM Herbert Xu wrote: > > On Thu

Re: [PATCH] crypto: amlogic - Fix endianness marker

2020-08-28 Thread LABBE Corentin
On Fri, Aug 28, 2020 at 05:18:33PM +1000, Herbert Xu wrote: > The endianness marking on the variable v in meson_cipher is wrong. > It is actually in CPU-order, not little-endian. > > This patch fixes it. > > Fixes: 3d04158814e7 ("crypto: amlogic - enable working on big...") > Signed-off-by: Herbe

Re: [PATCH] crypto: qat - aead cipher length should be block multiple

2020-08-28 Thread Giovanni Cabiddu
On Sat, Aug 22, 2020 at 02:04:10PM +0100, Ard Biesheuvel wrote: > On Sat, 22 Aug 2020 at 09:29, Giovanni Cabiddu > wrote: > > > > From: Dominik Przychodni > > > > Include an additional check on the cipher length to prevent undefined > > behaviour from occurring upon submitting requests which are

Re: [PATCH] crypto: cavium/nitrox: add an error message to explain the failure of pci_request_mem_regions

2020-08-28 Thread Herbert Xu
On Thu, Aug 20, 2020 at 10:12:08PM -0500, George Acosta wrote: > Provide an error message for users when pci_request_mem_regions failed. > > Signed-off-by: George Acosta > --- > drivers/crypto/cavium/nitrox/nitrox_main.c | 1 + > 1 file changed, 1 insertion(+) Patch applied. Thanks. -- Email:

Re: [PATCH] crypto: ccree - fix runtime PM imbalance on error

2020-08-28 Thread Herbert Xu
On Fri, Aug 21, 2020 at 04:15:13PM +0800, dinghao@zju.edu.cn wrote: > pm_runtime_get_sync() increments the runtime PM usage counter > even when it returns an error code. However, users of cc_pm_get(), > a direct wrapper of pm_runtime_get_sync(), assume that PM usage > counter will not change on

Re: [PATCH -next] crypto: sa2ul - Fix pointer-to-int-cast warning

2020-08-28 Thread Herbert Xu
On Tue, Aug 18, 2020 at 10:00:01PM +0800, YueHaibing wrote: > drivers/crypto/sa2ul.c: In function ‘sa_sha_init’: > drivers/crypto/sa2ul.c:1486:33: warning: cast from pointer to integer of > different size [-Wpointer-to-int-cast] >crypto_ahash_digestsize(tfm), (u64)rctx); >

[PATCH] crypto: amlogic - Fix endianness marker

2020-08-28 Thread Herbert Xu
The endianness marking on the variable v in meson_cipher is wrong. It is actually in CPU-order, not little-endian. This patch fixes it. Fixes: 3d04158814e7 ("crypto: amlogic - enable working on big...") Signed-off-by: Herbert Xu diff --git a/drivers/crypto/amlogic/amlogic-gxl-cipher.c b/driver