Re: Issue with iwd + Linux 5.8.3 + WPA Enterprise

2020-08-25 Thread Paul Menzel
Dear Caleb, Thank you for the report. Linux has a no regression policy, so the correct forum to report this to is the Linux kernel folks. I am adding the crypto and stable folks to the receiver list. Am 26.08.20 um 07:51 schrieb caljor...@hotmail.com: I wanted to note an issue that I hav

Re: [PATCH 2/2] crypto: sa2ul: fix compiler warning produced by clang

2020-08-25 Thread Nathan Chancellor
On Tue, Aug 25, 2020 at 04:31:06PM +0300, Tero Kristo wrote: > Clang detects a warning for an assignment that doesn't really do > anything. Fix this by removing the offending piece of code. > > Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver") > Reported-by: Nathan Chancellor > Signed-off

Re: [PATCH v2 2/3] dt-bindings: rng: add bindings for Xiphera XIP8001B hwnrg

2020-08-25 Thread Rob Herring
On Thu, Aug 20, 2020 at 01:51:21PM +0300, Atte Tommiska wrote: > Document the device tree bindings of Xiphera's XIP8001B-trng IP. typo in the subject. Otherwise, Reviewed-by: Rob Herring > > Signed-off-by: Atte Tommiska > --- > .../bindings/rng/xiphera,xip8001b-trng.yaml | 33 +

Re: [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add Xiphera vendor prefix

2020-08-25 Thread Rob Herring
On Thu, 20 Aug 2020 13:51:20 +0300, Atte Tommiska wrote: > Xiphera is an FPGA-based cryptographic solutions provider based in > Finland. > Website of the company: https://xiphera.com/ > > Signed-off-by: Atte Tommiska > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file

Re: [PATCH] crypto: arm64/gcm - Fix endianness warnings

2020-08-25 Thread Ard Biesheuvel
On Tue, 25 Aug 2020 at 03:41, Herbert Xu wrote: > > This patch changes a couple u128's to be128 which is the correct > type to use and fixes a few sparse warnings. > > Signed-off-by: Herbert Xu Acked-by: Ard Biesheuvel > > diff --git a/arch/arm64/crypto/ghash-ce-glue.c > b/arch/arm64/crypto/g

Re: [PATCH] crypto: arm64/sha - Add declarations for assembly variables

2020-08-25 Thread Ard Biesheuvel
On Tue, 25 Aug 2020 at 03:41, Herbert Xu wrote: > > This patch adds declarations for variables only used by assembly > code to silence compiler warnings: > > CC [M] arch/arm64/crypto/sha1-ce-glue.o > AS [M] arch/arm64/crypto/sha1-ce-core.o > CC [M] arch/arm64/crypto/sha2-ce-glue.o > AS

Re: Severe performance regression in "net: macsec: preserve ingress frame ordering"

2020-08-25 Thread Andrew Lunn
On Tue, Aug 25, 2020 at 01:09:31PM +, Van Leeuwen, Pascal wrote: > > -Original Message- > > From: Andrew Lunn > > Sent: Monday, August 24, 2020 3:02 PM > > To: Van Leeuwen, Pascal > > Cc: Sabrina Dubroca ; Scott Dial > > ; linux-crypto@vger.kernel.org; Ryan Cox > > ; net...@vger.kern

[PATCH 0/2] crypto: sa2ul: couple of fixes

2020-08-25 Thread Tero Kristo
Hi, Here are couple of fixes for sa2ul driver. Found via static checkers. -Tero -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

[PATCH 1/2] dt-bindings: crypto: sa2ul: fix a DT binding check warning

2020-08-25 Thread Tero Kristo
DT binding check produces a warning about bad cell size: Documentation/devicetree/bindings/crypto/ti,sa2ul.example.dt.yaml: example-0: crypto@4e0:reg:0: [0, 81788928, 0, 4608] is too long From schema: python3.6/site-packages/dtschema/schemas/reg.yaml Fix this by reducing the address

[PATCH 2/2] crypto: sa2ul: fix compiler warning produced by clang

2020-08-25 Thread Tero Kristo
Clang detects a warning for an assignment that doesn't really do anything. Fix this by removing the offending piece of code. Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver") Reported-by: Nathan Chancellor Signed-off-by: Tero Kristo --- drivers/crypto/sa2ul.c | 6 ++ 1 file changed,

RE: Severe performance regression in "net: macsec: preserve ingress frame ordering"

2020-08-25 Thread Van Leeuwen, Pascal
> -Original Message- > From: Andrew Lunn > Sent: Monday, August 24, 2020 3:02 PM > To: Van Leeuwen, Pascal > Cc: Sabrina Dubroca ; Scott Dial ; > linux-crypto@vger.kernel.org; Ryan Cox > ; net...@vger.kernel.org; da...@davemloft.net; Antoine > Tenart ; > ebigg...@google.com > Subject: R

Re: [PATCH v34 01/12] Linux Random Number Generator

2020-08-25 Thread Stephan Mueller
Am Dienstag, 25. August 2020, 13:28:53 CEST schrieb kernel test robot: Hi, > All warnings (new ones prefixed by >>): > >> drivers/char/lrng/lrng_drng.c:381:6: warning: no previous prototype for > >> 'lrng_reset' [-Wmissing-prototypes] > 381 | void lrng_reset(void) > > | ^~

Re: [PATCH v34 01/12] Linux Random Number Generator

2020-08-25 Thread kernel test robot
Hi "Stephan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on cryptodev/master crypto/master v5.9-rc2 next-20200825] [If your patch is applied to the wrong git tree, kindly drop us a note. And

[PATCH v34 08/12] crypto: provide access to a static Jitter RNG state

2020-08-25 Thread Stephan Müller
To support the LRNG operation which uses the Jitter RNG separately from the kernel crypto API, at a time where potentially the regular memory management is not yet initialized, the Jitter RNG needs to provide a state whose memory is defined at compile time. As only once instance will ever be needed

[PATCH v34 09/12] LRNG - add Jitter RNG fast noise source

2020-08-25 Thread Stephan Müller
The Jitter RNG fast noise source implemented as part of the kernel crypto API is queried for 256 bits of entropy at the time the seed buffer managed by the LRNG is about to be filled. CC: "Eric W. Biederman" CC: "Alexander E. Patrakov" CC: "Ahmed S. Darwish" CC: "Theodore Y. Ts'o" CC: Willy Ta

[PATCH v34 07/12] LRNG - add kernel crypto API PRNG extension

2020-08-25 Thread Stephan Müller
Add runtime-pluggable support for all PRNGs that are accessible via the kernel crypto API, including hardware PRNGs. The PRNG is selected with the module parameter drng_name where the name must be one that the kernel crypto API can resolve into an RNG. This allows using of the kernel crypto API PR

[PATCH v34 10/12] LRNG - add SP800-90B compliant health tests

2020-08-25 Thread Stephan Müller
Implement health tests for LRNG's slow noise sources as mandated by SP-800-90B The file contains the following health tests: - stuck test: The stuck test calculates the first, second and third discrete derivative of the time stamp to be processed by the LFSR. Only if all three values are non-z

[PATCH v34 12/12] LRNG - add power-on and runtime self-tests

2020-08-25 Thread Stephan Müller
Parts of the LRNG are already covered by self-tests, including: * Self-test of SP800-90A DRBG provided by the Linux kernel crypto API. * Self-test of the PRNG provided by the Linux kernel crypto API. * Raw noise source data testing including SP800-90B compliant tests when enabling CONFIG_LRNG_

[PATCH v34 02/12] LRNG - allocate one DRNG instance per NUMA node

2020-08-25 Thread Stephan Müller
In order to improve NUMA-locality when serving getrandom(2) requests, allocate one DRNG instance per node. The DRNG instance that is present right from the start of the kernel is reused as the first per-NUMA-node DRNG. For all remaining online NUMA nodes a new DRNG instance is allocated. During b

[PATCH v34 03/12] LRNG - sysctls and /proc interface

2020-08-25 Thread Stephan Müller
The LRNG sysctl interface provides the same controls as the existing /dev/random implementation. These sysctls behave identically and are implemented identically. The goal is to allow a possible merge of the existing /dev/random implementation with this implementation which implies that this patch

[PATCH v34 11/12] LRNG - add interface for gathering of raw entropy

2020-08-25 Thread Stephan Müller
The test interface allows a privileged process to capture the raw unconditioned noise that is collected by the LRNG for statistical analysis. Such testing allows the analysis how much entropy the interrupt noise source provides on a given platform. Extracted noise data is not used to seed the LRNG.

[PATCH v34 01/12] Linux Random Number Generator

2020-08-25 Thread Stephan Müller
In an effort to provide a flexible implementation for a random number generator that also delivers entropy during early boot time, allows replacement of the deterministic random number generation mechanism, implement the various components in separate code for easier maintenance, and provide compli

[PATCH v34 06/12] LRNG - add SP800-90A DRBG extension

2020-08-25 Thread Stephan Müller
Using the LRNG switchable DRNG support, the SP800-90A DRBG extension is implemented. The DRBG uses the kernel crypto API DRBG implementation. In addition, it uses the kernel crypto API SHASH support to provide the hashing operation. The DRBG supports the choice of either a CTR DRBG using AES-256,

[PATCH v34 00/12] /dev/random - a new approach with full SP800-90B compliance

2020-08-25 Thread Stephan Müller
Hi, The following patch set provides a different approach to /dev/random which is called Linux Random Number Generator (LRNG) to collect entropy within the Linux kernel. The main improvements compared to the existing /dev/random is to provide sufficient entropy during boot time as well as in virtu

[PATCH v34 04/12] LRNG - add switchable DRNG support

2020-08-25 Thread Stephan Müller
The DRNG switch support allows replacing the DRNG mechanism of the LRNG. The switching support rests on the interface definition of include/linux/lrng.h. A new DRNG is implemented by filling in the interface defined in this header file. In addition to the DRNG, the extension also has to provide a

[PATCH v34 05/12] crypto: DRBG - externalize DRBG functions for LRNG

2020-08-25 Thread Stephan Müller
This patch allows several DRBG functions to be called by the LRNG kernel code paths outside the drbg.c file. CC: "Eric W. Biederman" CC: "Alexander E. Patrakov" CC: "Ahmed S. Darwish" CC: "Theodore Y. Ts'o" CC: Willy Tarreau CC: Matthew Garrett CC: Vito Caputo CC: Andreas Dilger CC: Jan Ka

Re: [PATCH] crypto: arm/poly1305 - Add prototype for poly1305_blocks_neon

2020-08-25 Thread Jason A. Donenfeld
On Tue, Aug 25, 2020 at 3:23 AM Herbert Xu wrote: > > This patch adds a prototype for poly1305_blocks_neon to slience > a compiler warning: > > CC [M] arch/arm/crypto/poly1305-glue.o > ../arch/arm/crypto/poly1305-glue.c:25:13: warning: no previous prototype for > `poly1305_blocks_neon' [-Wmiss