Re: [PATCH 0/5] crypto: Implement cmac based on cbc skcipher

2020-08-19 Thread Ard Biesheuvel
On Wed, 19 Aug 2020 at 00:39, Ben Greear wrote: > > On 8/18/20 3:33 PM, Herbert Xu wrote: > > On Tue, Aug 18, 2020 at 03:31:10PM -0700, Ben Greear wrote: > >> > >> I don't think it has been discussed recently, but mac80211 is already > >> a complicated beast, so if this added any significant compl

Re: [PATCH v2] lib: Verify array index is correct before using it

2020-08-19 Thread Herbert Xu
On Tue, Jul 28, 2020 at 08:21:57AM -0400, Huang Guobin wrote: > This code reads from the array before verifying that "c" is a valid > index. Move test array offset code before use to fix it. > > Fixes: 2da572c959dd ("lib: add software 842 compression/decompression") > Signed-off-by: Huang Guobin

Re: [PATCH 6/9] crypto: caam/qi2 - add support for more XTS key lengths

2020-08-19 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: 226853ac3ebe ("crypto: caam/qi2 - add skcipher algorithms"). The bot has tested the following trees: v5.8.1, v5.7.15, v5.4.58. v5.8.1: Failed to apply! Possible dependencies: 528

Re: [PATCH RESEND 6/9] crypto: caam/qi2 - add support for more XTS key lengths

2020-08-19 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: 226853ac3ebe ("crypto: caam/qi2 - add skcipher algorithms"). The bot has tested the following trees: v5.8.1, v5.7.15, v5.4.58. v5.8.1: Failed to apply! Possible dependencies: 528

Re: [PATCH RESEND 5/9] crypto: caam/qi - add support for more XTS key lengths

2020-08-19 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: b189817cf789 ("crypto: caam/qi - add ablkcipher and authenc algorithms"). The bot has tested the following trees: v5.8.1, v5.7.15, v5.4.58, v4.19.139, v4.14.193. v5.8.1: Failed to

Re: [PATCH 4/9] crypto: caam/jr - add support for more XTS key lengths

2020-08-19 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: c6415a6016bf ("crypto: caam - add support for acipher xts(aes)"). The bot has tested the following trees: v5.8.1, v5.7.15, v5.4.58, v4.19.139, v4.14.193, v4.9.232, v4.4.232. v5.8.1:

Re: [PATCH RESEND 3/9] crypto: caam/qi2 - add fallback for XTS with more than 8B IV

2020-08-19 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: 226853ac3ebe ("crypto: caam/qi2 - add skcipher algorithms"). The bot has tested the following trees: v5.8.1, v5.7.15, v5.4.58. v5.8.1: Failed to apply! Possible dependencies: 528

Re: [PATCH RESEND 4/9] crypto: caam/jr - add support for more XTS key lengths

2020-08-19 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: c6415a6016bf ("crypto: caam - add support for acipher xts(aes)"). The bot has tested the following trees: v5.8.1, v5.7.15, v5.4.58, v4.19.139, v4.14.193, v4.9.232, v4.4.232. v5.8.1:

Re: [PATCH 5/9] crypto: caam/qi - add support for more XTS key lengths

2020-08-19 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: b189817cf789 ("crypto: caam/qi - add ablkcipher and authenc algorithms"). The bot has tested the following trees: v5.8.1, v5.7.15, v5.4.58, v4.19.139, v4.14.193. v5.8.1: Failed to

Re: [PATCH 2/9] crypto: caam/qi - add fallback for XTS with more than 8B IV

2020-08-19 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: b189817cf789 ("crypto: caam/qi - add ablkcipher and authenc algorithms"). The bot has tested the following trees: v5.8.1, v5.7.15, v5.4.58, v4.19.139, v4.14.193. v5.8.1: Failed to

Re: [PATCH RESEND 1/9] crypto: caam/jr - add fallback for XTS with more than 8B IV

2020-08-19 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: c6415a6016bf ("crypto: caam - add support for acipher xts(aes)"). The bot has tested the following trees: v5.8.1, v5.7.15, v5.4.58, v4.19.139, v4.14.193, v4.9.232, v4.4.232. v5.8.1:

Re: [PATCH 3/9] crypto: caam/qi2 - add fallback for XTS with more than 8B IV

2020-08-19 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: 226853ac3ebe ("crypto: caam/qi2 - add skcipher algorithms"). The bot has tested the following trees: v5.8.1, v5.7.15, v5.4.58. v5.8.1: Failed to apply! Possible dependencies: 528

Re: [PATCH RESEND 2/9] crypto: caam/qi - add fallback for XTS with more than 8B IV

2020-08-19 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: b189817cf789 ("crypto: caam/qi - add ablkcipher and authenc algorithms"). The bot has tested the following trees: v5.8.1, v5.7.15, v5.4.58, v4.19.139, v4.14.193. v5.8.1: Failed to

Re: [PATCH 2/3] dt-bindings: rng: add bindings for Xiphera XIP8001B hwnrg

2020-08-19 Thread Rob Herring
On Wed, 19 Aug 2020 15:21:34 +0300, Atte Tommiska wrote: > Document the device tree bindings of Xiphera's XIP8001B-trng IP. > > Signed-off-by: Atte Tommiska > --- > .../bindings/rng/xiphera,xip8001b-trng.yaml | 30 +++ > 1 file changed, 30 insertions(+) > create mode 100644 >

Re: [PATCH] Add missing bound checks for software 842 decompressor

2020-08-19 Thread Kees Cook
On Sun, Aug 16, 2020 at 02:33:41AM +0200, Joan Bruguera wrote: > Any feedback? Hi! I just happened to see this email. I think this should likely be directed to the crypto (which also handled compress/decompress APIs) list and the original author... Additional notes below... > - Joan > > On 05.

Re: [PATCH 0/2] Cyrpto: Clean up kmap() use

2020-08-19 Thread Ira Weiny
On Mon, Aug 10, 2020 at 05:40:13PM -0700, 'Ira Weiny' wrote: > From: Ira Weiny > > While going through kmap() users the following 2 issues were found via code > inspection. Any feedback on these patches? Perhaps I've not included the correct people? Adding some people to the CC list. Specifica

[RESEND PATCH] KEYS: asymmetric: Fix kerneldoc

2020-08-19 Thread Krzysztof Kozlowski
Fix W=1 compile warnings (invalid kerneldoc): crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid1' not described in 'asymmetric_key_id_same' crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid2' not described in '

Re: [PATCH] ARM: multi_v7_defconfig: enable caam crypto module

2020-08-19 Thread Shawn Guo
On Mon, Jul 27, 2020 at 07:14:28PM +0300, Horia Geantă wrote: > caam crypto module is included in several ARMv7-based SoCs from > i.MX, Layerscape, Vybrid families. > > Signed-off-by: Horia Geantă Applied, thanks.

[PATCH 2/3] dt-bindings: rng: add bindings for Xiphera XIP8001B hwnrg

2020-08-19 Thread Atte Tommiska
Document the device tree bindings of Xiphera's XIP8001B-trng IP. Signed-off-by: Atte Tommiska --- .../bindings/rng/xiphera,xip8001b-trng.yaml | 30 +++ 1 file changed, 30 insertions(+) create mode 100644 Documentation/devicetree/bindings/rng/xiphera,xip8001b-trng.yaml diff -

[PATCH 1/3] dt-bindings: vendor-prefixes: Add Xiphera vendor prefix

2020-08-19 Thread Atte Tommiska
Xiphera is an FPGA-based cryptographic solutions provider based in Finland. Website of the company: https://xiphera.com/ Signed-off-by: Atte Tommiska --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings

[PATCH 0/3] hwrng: add support for Xiphera XIP8001B

2020-08-19 Thread Atte Tommiska
This patchset introduces a linux driver for Xiphera's XIP8001B IP. The IP is an FPGA-based TRNG which can be used in various FPGA families. The IP is in use in multiple customer projects and in Xiphera's own products. Atte Tommiska (3): dt-bindings: vendor-prefixes: Add Xiphera vendor prefix d

[PATCH 3/3] hwrng: xiphera-trng: add support for XIP8001B hwrng

2020-08-19 Thread Atte Tommiska
Xiphera XIP8001B is an FPGA-based True Random Number Generator Intellectual Property (IP) Core which can be instantiated in multiple FPGA families. This driver adds Linux support for it through the hwrng interface. Signed-off-by: Atte Tommiska --- drivers/char/hw_random/Kconfig| 10 ++

[v3 PATCH] crypto: algapi - Remove skbuff.h inclusion

2020-08-19 Thread Herbert Xu
v3 Add sizes.h to arch/x86/crypto glue code. ---8<--- The header file algapi.h includes skbuff.h unnecessarily since all we need is a forward declaration for struct sk_buff. This patch removes that inclusion. Unfortunately skbuff.h pulls in a lot of things and drivers over the years have come t