Re: [PATCH v2 3/3] drivers: crypto: add the Virtual Function driver for OcteonTX2 CPT

2020-08-12 Thread Herbert Xu
On Fri, Aug 07, 2020 at 07:39:20PM +0530, Srujana Challa wrote: > > +static inline int is_any_alg_used(void) > +{ > + int i; > + > + for (i = 0; i < ARRAY_SIZE(otx2_cpt_skciphers); i++) > + if (refcount_read(&otx2_cpt_skciphers[i].base.cra_refcnt) != 1) > + r

Re: [PATCH v2 2/3] drivers: crypto: add support for OCTEONTX2 CPT engine

2020-08-12 Thread Herbert Xu
On Fri, Aug 07, 2020 at 07:39:19PM +0530, Srujana Challa wrote: > > +#if defined(CONFIG_ARM64) > +static inline long otx2_lmt_flush(void *ioreg) > +{ > + long result = 0; > + > + __asm__ volatile(".cpu generic+lse\n" > + "ldeor xzr, %0, [%1]\n" > +

Re: [PATCH v2 2/3] drivers: crypto: add support for OCTEONTX2 CPT engine

2020-08-12 Thread Herbert Xu
On Fri, Aug 07, 2020 at 07:39:19PM +0530, Srujana Challa wrote: > > +/* > + * On OcteonTX2 platform the parameter insts_num is used as a count of > + * instructions to be enqueued. The valid values for insts_num are: > + * 1 - 1 CPT instruction will be enqueued during LMTST operation > + * 2 - 2 CP

[PATCH] crypto: virtio - don't use 'default m'

2020-08-12 Thread Eric Biggers
From: Ram Muthiah Drivers shouldn't be enabled by default unless there is a very good reason to do so. There doesn't seem to be any such reason for the virtio crypto driver, so change it to the default of 'n'. Signed-off-by: Ram Muthiah [EB: adjusted commit message] Signed-off-by: Eric Biggers

Re: [PATCHv1 2/2] crypto: add Intel SoCFPGA crypto service driver

2020-08-12 Thread Richard Gong
I will move them to drivers/misc. Regards, Richard On 8/11/20 7:34 PM, Herbert Xu wrote: On Tue, Aug 11, 2020 at 08:56:22AM -0500, richard.g...@linux.intel.com wrote: From: Richard Gong Add Intel FPGA crypto service (FCS) driver to support new crypto services on Intel SoCFPGA platforms. T

Hi

2020-08-12 Thread DR HARUNA BELLO
-- Hello Dear Assalamu Alaikum Wa Rahmatullahi Wa Barakatuh I NEED AN IMMEDIATE RESPONSE FROM YOU. Good day Dear I have a project of $18.5 Million Us Dollars which I will like you to support me so that the fund will be transfer to your bank account. Please if you are capable reply back to me

[PATCH v2] crypto: algif_aead - fix uninitialized ctx->init

2020-08-12 Thread Ondrej Mosnacek
In skcipher_accept_parent_nokey() the whole af_alg_ctx structure is cleared by memset() after allocation, so add such memset() also to aead_accept_parent_nokey() so that the new "init" field is also initialized to zero. Without that the initial ctx->init checks might randomly return true and cause

Re: [PATCH] crypto: af_alg - fix uninitialized ctx->init

2020-08-12 Thread Ondrej Mosnacek
On Wed, Aug 12, 2020 at 2:33 PM Herbert Xu wrote: > On Wed, Aug 12, 2020 at 11:22:32AM +0200, Ondrej Mosnacek wrote: > > This new member of struct af_alg_ctx was not being initialized before > > use, leading to random errors. Found via libkcapi testsuite. > > > > Cc: Stephan Mueller > > Fixes: f3

Re: Severe performance regression in "net: macsec: preserve ingress frame ordering"

2020-08-12 Thread Andrew Lunn
> With networking protocols you often also have a requirement to minimize > packet reordering, so I understand it's a careful balance. But it is possible > to serialize the important stuff and still do the crypto out-of-order, which > would be really beneficial on _some_ platforms (which have HW cr

Re: [PATCH] crypto: af_alg - fix uninitialized ctx->init

2020-08-12 Thread Herbert Xu
On Wed, Aug 12, 2020 at 11:22:32AM +0200, Ondrej Mosnacek wrote: > This new member of struct af_alg_ctx was not being initialized before > use, leading to random errors. Found via libkcapi testsuite. > > Cc: Stephan Mueller > Fixes: f3c802a1f300 ("crypto: algif_aead - Only wake up when ctx->more

RE: Severe performance regression in "net: macsec: preserve ingress frame ordering"

2020-08-12 Thread Van Leeuwen, Pascal
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf Of Sabrina Dubroca > Sent: Wednesday, August 12, 2020 12:05 PM > To: Scott Dial > Cc: linux-crypto@vger.kernel.org; Ryan Cox ; > net...@vger.kernel.org; da...@davemloft.net; Antoine Tenart > ; ebigg...@google.co

Re: Severe performance regression in "net: macsec: preserve ingress frame ordering"

2020-08-12 Thread Sabrina Dubroca
2020-08-10, 12:09:40 -0400, Scott Dial wrote: > On 8/10/2020 9:34 AM, Sabrina Dubroca wrote: > > [adding the linux-crypto list] > > > > 2020-08-06, 23:48:16 -0400, Scott Dial wrote: > >> On 8/6/2020 5:11 PM, Ryan Cox wrote: > >>> With 5.7 I get: > >>> * 9.90 Gb/s with no macsec at all > >>> * 1.80

[PATCH] crypto: af_alg - fix uninitialized ctx->init

2020-08-12 Thread Ondrej Mosnacek
This new member of struct af_alg_ctx was not being initialized before use, leading to random errors. Found via libkcapi testsuite. Cc: Stephan Mueller Fixes: f3c802a1f300 ("crypto: algif_aead - Only wake up when ctx->more is zero") Signed-off-by: Ondrej Mosnacek --- crypto/algif_aead.c | 1