Re: [PATCHv2 2/2] hwrng: optee: fix wait use case

2020-08-05 Thread Sumit Garg
On Thu, 6 Aug 2020 at 12:00, Jorge Ramirez-Ortiz, Foundries wrote: > > On 06/08/20, Sumit Garg wrote: > > On Thu, 6 Aug 2020 at 02:08, Jorge Ramirez-Ortiz, Foundries > > wrote: > > > > > > On 05/08/20, Sumit Garg wrote: > > > > Apologies for my delayed response as I was busy with some other tasks

Re: [PATCHv2 2/2] hwrng: optee: fix wait use case

2020-08-05 Thread Jorge Ramirez-Ortiz, Foundries
On 06/08/20, Sumit Garg wrote: > On Thu, 6 Aug 2020 at 02:08, Jorge Ramirez-Ortiz, Foundries > wrote: > > > > On 05/08/20, Sumit Garg wrote: > > > Apologies for my delayed response as I was busy with some other tasks > > > along with holidays. > > > > no pb! was just making sure this wasnt falling

Re: [PATCHv2 2/2] hwrng: optee: fix wait use case

2020-08-05 Thread Sumit Garg
On Thu, 6 Aug 2020 at 02:08, Jorge Ramirez-Ortiz, Foundries wrote: > > On 05/08/20, Sumit Garg wrote: > > Apologies for my delayed response as I was busy with some other tasks > > along with holidays. > > no pb! was just making sure this wasnt falling through some cracks. > > > > > On Fri, 24 Jul

Re: [v4 01/10] crypto: hisilicon/qm - fix wrong release after using strsep

2020-08-05 Thread shenyang (M)
On 2020/8/5 14:04, Markus Elfring wrote: Thanks for your review. There is only one error branch need to do something uninit. So I think the jump is not necessary and will affect code reading.:) How does this concern fit to the Linux coding style? https://git.kernel.org/pub/scm/linux/kernel/g

Re: [PATCHv2 2/2] hwrng: optee: fix wait use case

2020-08-05 Thread Jorge Ramirez-Ortiz, Foundries
On 05/08/20, Sumit Garg wrote: > Apologies for my delayed response as I was busy with some other tasks > along with holidays. no pb! was just making sure this wasnt falling through some cracks. > > On Fri, 24 Jul 2020 at 19:53, Jorge Ramirez-Ortiz, Foundries > wrote: > > > > On 24/07/20, Sumit

[PATCH] crypto/x86: Use CRC32 mnemonic in crc32c-intel_glue.c

2020-08-05 Thread Uros Bizjak
Current minimum required version of binutils is 2.23, which supports CRC32 instruction mnemonic. Replace the byte-wise specification of CRC32 with this proper mnemonic. The compiler is now able to pass memory operand to the instruction, so there is no need for a temporary register anymore. Some e

Re: [PATCHv2 2/2] hwrng: optee: fix wait use case

2020-08-05 Thread Sumit Garg
Apologies for my delayed response as I was busy with some other tasks along with holidays. On Fri, 24 Jul 2020 at 19:53, Jorge Ramirez-Ortiz, Foundries wrote: > > On 24/07/20, Sumit Garg wrote: > > On Thu, 23 Jul 2020 at 14:16, Jorge Ramirez-Ortiz > > wrote: > > > > > > The current code waits f

[PATCH v3 32/38] virtio_crypto: convert to LE accessors

2020-08-05 Thread Michael S. Tsirkin
Virtio crypto is modern-only. Use LE accessors for config space. Signed-off-by: Michael S. Tsirkin --- drivers/crypto/virtio/virtio_crypto_core.c | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/crypto/virtio/virtio_crypto_core.c b/drivers/cry

[PATCH v3 08/38] virtio_crypto: correct tags for config space fields

2020-08-05 Thread Michael S. Tsirkin
Since crypto is a modern-only device, tag config space fields as having little endian-ness. Signed-off-by: Michael S. Tsirkin Reviewed-by: Cornelia Huck --- include/uapi/linux/virtio_crypto.h | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/includ

Re: [PATCHv2 2/2] hwrng: optee: fix wait use case

2020-08-05 Thread Jorge Ramirez-Ortiz, Foundries
On 23/07/20, Jorge Ramirez-Ortiz wrote: > The current code waits for data to be available before attempting a > second read. However the second read would not be executed as the > while loop exits. > > This fix does not wait if all data has been read and reads a second > time if only partial data

[PATCH v2] crypto/x86: Use CRC32 mnemonic in crc32c-intel_glue.c

2020-08-05 Thread Uros Bizjak
Current minimum required version of binutils is 2.23, which supports CRC32 instruction mnemonic. Replace the byte-wise specification of CRC32 with this proper mnemonic. The compiler is now able to pass memory operand to the instruction, so there is no need for a temporary register anymore. Some e