Re: [PATCH] crypto: ccp - zero the cmd data after use it

On 8/4/20 12:22, Herbert Xu wrote: > On Tue, Aug 04, 2020 at 12:20:21PM +0800, Liwei Song wrote: >> >> Yes, the other process should do this zero work, but the case I met is >> this address will appear in the slab_alloc_node() as freelist pointer of >> slub, >> and before slub do zero wrok, eve

Re: [PATCH] crypto: ccp - zero the cmd data after use it

On Tue, Aug 04, 2020 at 12:20:21PM +0800, Liwei Song wrote: > > Yes, the other process should do this zero work, but the case I met is > this address will appear in the slab_alloc_node() as freelist pointer of slub, > and before slub do zero wrok, even kzalloc() doesn't work with this address. Tha

Re: [PATCH] crypto: ccp - zero the cmd data after use it

On 8/4/20 12:04, Herbert Xu wrote: > On Tue, Aug 04, 2020 at 11:51:47AM +0800, Liwei Song wrote: >> >> On 8/3/20 20:52, Herbert Xu wrote: >>> On Mon, Aug 03, 2020 at 03:58:58PM +0800, Liwei Song wrote: exist the following assignment in ccp(ignore the force convert of the struct) by lis

Re: [PATCH] crypto: ccp - zero the cmd data after use it

On Tue, Aug 04, 2020 at 11:51:47AM +0800, Liwei Song wrote: > > On 8/3/20 20:52, Herbert Xu wrote: > > On Mon, Aug 03, 2020 at 03:58:58PM +0800, Liwei Song wrote: > >> exist the following assignment in ccp(ignore the force > >> convert of the struct) by list_del in ccp_dequeue_cmd(): > >> req->__c

Re: [PATCH] crypto: ccp - zero the cmd data after use it

On 8/3/20 20:52, Herbert Xu wrote: > On Mon, Aug 03, 2020 at 03:58:58PM +0800, Liwei Song wrote: >> exist the following assignment in ccp(ignore the force >> convert of the struct) by list_del in ccp_dequeue_cmd(): >> req->__ctx->cmd->entry->next = LIST_POISON1; >> >> after use the req, kzfree(r

Re: [PATCH v4] crypto: af_alg - add extra parameters for DRBG interface

On Mon, Aug 03, 2020 at 03:48:02PM +0100, Elena Petrova wrote: > > sendmsg is used for "Additional Data" input, and unlike entropy, it > could be useful outside of testing. But if you confirm it's not > useful, then yes, I can decouple the testing parts. Unless there is someone asking for it then

Re: linux-next: manual merge of the crypto tree with the jc_docs tree

Hi all, On Fri, 24 Jul 2020 13:09:51 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the crypto tree got a conflict in: > > Documentation/crypto/api-intro.rst > > between commit: > > 5846551bb147 ("docs: crypto: convert api-intro.txt to ReST format") > > from the jc_docs tr

Re: linux-next: manual merge of the tip tree with the crypto tree

Hi all, On Tue, 21 Jul 2020 14:28:45 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the tip tree got a conflict in: > > arch/x86/include/asm/inst.h > > between commit: > > d7866e503bdc ("crypto: x86 - Remove include/asm/inst.h") > (also "crypto: x86 - Put back integer parts

Re: linux-next: manual merge of the akpm-current tree with the crypto tree

Hi all, On Fri, 17 Jul 2020 20:14:11 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the akpm-current tree got a conflict in: > > drivers/crypto/mediatek/mtk-aes.c > > between commit: > > f441ba2ad341 ("crypto: mediatek - use AES library for GCM key derivation") > > from th

[PATCH v2 08/24] virtio_crypto: correct tags for config space fields

Since crypto is a modern-only device, tag config space fields as having little endian-ness. Signed-off-by: Michael S. Tsirkin --- include/uapi/linux/virtio_crypto.h | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/include/uapi/linux/virtio_crypto.h

Re: [PATCH] crypto: x86/aesni - implement accelerated CBCMAC, CMAC and XCBC shashes

Hello, This helps a bit...now download sw-crypt performance is about 150Mbps, but still not as good as with my patch on 5.4 kernel, and fpu is still high in perf top: 13.89% libc-2.29.so [.] __memset_sse2_unaligned_erms 6.62% [kernel] [k] kernel_fpu_begin 4.14% [kernel]

Re: [GIT PULL] Crypto Update for 5.9

The pull request you sent on Mon, 3 Aug 2020 14:40:24 +1000: > git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ab5c60b79ab6cc50b39bbb21b2f9fb55af900b84 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH v4] crypto: af_alg - add extra parameters for DRBG interface

Am Montag, 3. August 2020, 16:48:02 CEST schrieb Elena Petrova: Hi Elena, > On Fri, 31 Jul 2020 at 08:27, Herbert Xu wrote: > > Eric Biggers wrote: > > > lock_sock() would solve the former. I'm not sure what should be done > > > about > > > rng_recvmsg(). It apparently relies on the crypto_r

[crypto:master 164/167] drivers/char/hw_random/ingenic-rng.c:118:1-6: WARNING: invalid free of devm_ allocated data (fwd)

2.6.git master head: 3cbfe80737c18ac6e635421ab676716a393d3074 commit: 190873a0ea4500433ae818521cad20d37f9ee059 [164/167] crypto: ingenic - Add hardware RNG for Ingenic JZ4780 and X1000 :: branch date: 3 days ago :: commit date: 3 days ago config: mips-randconfig-c003-20200803 (atta

Re: [PATCH] crypto: ccp - zero the cmd data after use it

On Mon, Aug 03, 2020 at 03:58:58PM +0800, Liwei Song wrote: > exist the following assignment in ccp(ignore the force > convert of the struct) by list_del in ccp_dequeue_cmd(): > req->__ctx->cmd->entry->next = LIST_POISON1; > > after use the req, kzfree(req) can not zero the entry > entry->next = L

[PATCH] crypto: ccp - zero the cmd data after use it

exist the following assignment in ccp(ignore the force convert of the struct) by list_del in ccp_dequeue_cmd(): req->__ctx->cmd->entry->next = LIST_POISON1; after use the req, kzfree(req) can not zero the entry entry->next = LIST_POISON1 of the ccp_cmd(cmd) struct when this address available as sl