Re: LTP: crypto: af_alg02 regression on linux-next 20200621 tag

2020-06-22 Thread Herbert Xu
On Tue, Jun 23, 2020 at 11:53:43AM +0530, Naresh Kamboju wrote: > > Thanks for the investigation. > After reverting, two test cases got PASS out of four reported failure cases. > ltp-crypto-tests: > * af_alg02 - still failing - Hung and time out > * af_alg05 - still failing - Hung and ti

Re: LTP: crypto: af_alg02 regression on linux-next 20200621 tag

2020-06-22 Thread Naresh Kamboju
On Tue, 23 Jun 2020 at 04:19, Luis Chamberlain wrote: > > On Tue, Jun 23, 2020 at 12:04:06AM +0530, Naresh Kamboju wrote: > > LTP crypto regressions noticed on linux next 20200621. > > > > The common case for all tests is timeout after 15 minutes which > > means tests got hung and LTP timers kille

[PATCH v2 2/3] crypto: hisilicon/zip - permit users to specify NUMA node

2020-06-22 Thread Barry Song
If users don't specify NUMA node, the driver will use the ZIP module near the CPU allocating acomp. Otherwise, it uses the ZIP module according to the requirement of users. Cc: Zhou Wang Signed-off-by: Barry Song --- drivers/crypto/hisilicon/zip/zip.h| 2 +- drivers/crypto/hisilicon/zip

[PATCH v2 0/3] crypto: allow users to specify acomp hardware from a desired NUMA node

2020-06-22 Thread Barry Song
For a typical Linux server, probably there are several hardware modules. For example, numa node0 has a compressor, numa node2 has a same module. Some drivers are automatically using the module near the CPU calling acomp_alloc. But it isn't necessarily correct. Just like memory allocation API like k

[PATCH v2 1/3] crypto: permit users to specify numa node of acomp hardware

2020-06-22 Thread Barry Song
For a Linux server with NUMA, there are possibly multiple (de)compressors which are either local or remote to some NUMA node. Some drivers will automatically use the (de)compressor near the CPU calling acomp_alloc(). However, it is not necessarily correct because users who send acomp_req could be f

[PATCH v2 3/3] mm/zswap: allocate acomp on the numa node committing acomp_req

2020-06-22 Thread Barry Song
zswap is allocating acomp on one different cpu with those cpus which will eventually committing acomp_req. this patch specifies the numa node to help compression/decompression done by local (de)compressors hardware. Cc: Seth Jennings Cc: Dan Streetman Cc: Vitaly Wool Cc: Herbert Xu Cc: David S

Re: [PATCH 5.7] x86/crypto: aesni: Fix build with LLVM_IAS=1

2020-06-22 Thread Sedat Dilek
On Mon, Jun 22, 2020 at 10:33 PM Nick Desaulniers wrote: > > On Mon, Jun 22, 2020 at 8:50 AM Sedat Dilek wrote: > > > > When building with LLVM_IAS=1 means using Clang's Integrated Assembly (IAS) > > from LLVM/Clang >= v10.0.1-rc1+ instead of GNU/as from GNU/binutils > > I see the following break

[PATCH 5.7 v3] x86/crypto: aesni: Fix build with LLVM_IAS=1

2020-06-22 Thread Sedat Dilek
When building with LLVM_IAS=1 means using Clang's Integrated Assembly (IAS) from LLVM/Clang >= v10.0.1-rc1+ instead of GNU/as from GNU/binutils I see the following breakage in Debian/testing AMD64: :15:74: error: too many positional arguments PRECOMPUTE 8*3+8(%rsp), %xmm1, %xmm2, %xmm3, %xmm4, %x

[PATCH 5.7 v2] x86/crypto: aesni: Fix build with LLVM_IAS=1

2020-06-22 Thread Sedat Dilek
When building with LLVM_IAS=1 means using Clang's Integrated Assembly (IAS) from LLVM/Clang >= v10.0.1-rc1+ instead of GNU/as from GNU/binutils I see the following breakage in Debian/testing AMD64: :15:74: error: too many positional arguments PRECOMPUTE 8*3+8(%rsp), %xmm1, %xmm2, %xmm3, %xmm4, %x

[PATCH] crypto, x86: aesni: add compatibility with IAS

2020-06-22 Thread Jian Cai
Clang's integrated assembler complains "invalid reassignment of non-absolute variable 'var_ddq_add'" while assembling arch/x86/crypto/aes_ctrby8_avx-x86_64.S. It was because var_ddq_add was reassigned with non-absolute values several times, which IAS did not support. We can avoid the reassignment b

Re: LTP: crypto: af_alg02 regression on linux-next 20200621 tag

2020-06-22 Thread Luis Chamberlain
On Tue, Jun 23, 2020 at 12:04:06AM +0530, Naresh Kamboju wrote: > LTP crypto regressions noticed on linux next 20200621. > > The common case for all tests is timeout after 15 minutes which > means tests got hung and LTP timers killed those test runs after > timeout. > The root cause of the failure

[PATCH] crypto: ccp - Fix use of merged scatterlists

2020-06-22 Thread John Allen
Running the crypto manager self tests with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS may result in several types of errors when using the ccp-crypto driver: alg: skcipher: cbc-des3-ccp encryption failed on test vector 0; expected_error=0, actual_error=-5 ... alg: skcipher: ctr-aes-ccp decryption overran

LTP: crypto: af_alg02 regression on linux-next 20200621 tag

2020-06-22 Thread Naresh Kamboju
LTP crypto regressions noticed on linux next 20200621. The common case for all tests is timeout after 15 minutes which means tests got hung and LTP timers killed those test runs after timeout. The root cause of the failure is under investigation. ltp-crypto-tests: * af_alg02 - failed *

Re: [PATCH] crypto: sun8i-ce - Fix runtime PM imbalance in sun8i_ce_cipher_init

2020-06-22 Thread Markus Elfring
> Fix this by … Please replace the beginning of this sentence with the tag “Fixes”. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183 Regards, Markus

Re: [PATCH 5.7] x86/crypto: aesni: Fix build with LLVM_IAS=1

2020-06-22 Thread Sedat Dilek
On Mon, Jun 22, 2020 at 5:50 PM Sedat Dilek wrote: > Craig Topper suggested me in ClangBuiltLinux issue #1050: > > > I think the "too many positional arguments" is because the parser isn't able > > to handle the trailing commas. > > > > The "unknown use of instruction mnemonic" is because the mac

URGENT REPLY.

2020-06-22 Thread Karim Zakari
Good-Day Friend, Hope you are doing great Today. I have a proposed business deal worthy (US$16.5 Million Dollars) that will benefit both parties. This is legitimate' legal and your personality will not be compromised. Waiting for your response for more details, As you are willing to execute

[PATCH 5.7] x86/crypto: aesni: Fix build with LLVM_IAS=1

2020-06-22 Thread Sedat Dilek
When building with LLVM_IAS=1 means using Clang's Integrated Assembly (IAS) from LLVM/Clang >= v10.0.1-rc1+ instead of GNU/as from GNU/binutils I see the following breakage in Debian/testing AMD64: :15:74: error: too many positional arguments PRECOMPUTE 8*3+8(%rsp), %xmm1, %xmm2, %xmm3, %xmm4, %x

Re: [next-20200621] LTP tests af_alg02/05 failure on POWER9 PowerVM LPAR

2020-06-22 Thread Herbert Xu
On Mon, Jun 22, 2020 at 05:55:29PM +0530, Sachin Sant wrote: > With recent next(next-20200621) af_alg02/05 tests fail while running on POWER9 > PowerVM LPAR. > > Results from 5.8.0-rc1-next-20200622 > # ./af_alg02 > tst_test.c:1096: INFO: Timeout per run is 0h 00m 20s >

[next-20200621] LTP tests af_alg02/05 failure on POWER9 PowerVM LPAR

2020-06-22 Thread Sachin Sant
With recent next(next-20200621) af_alg02/05 tests fail while running on POWER9 PowerVM LPAR. Results from 5.8.0-rc1-next-20200622 # ./af_alg02 tst_test.c:1096: INFO: Timeout per run is 0h 00m 20s af_alg02.c:52: BROK: Timed out while reading from request socket. # 5.8.0-rc1-next-20200618 was

Re: [PATCH 0/2] Introduce PCI_FIXUP_IOMMU

2020-06-22 Thread Joerg Roedel
On Thu, Jun 04, 2020 at 09:33:07PM +0800, Zhangfei Gao wrote: > +++ b/drivers/iommu/iommu.c > @@ -2418,6 +2418,10 @@ int iommu_fwspec_init(struct device *dev, struct > fwnode_handle *iommu_fwnode, >     fwspec->iommu_fwnode = iommu_fwnode; >     fwspec->ops = ops; >     dev_iommu_fwspec

Re: [PATCH 0/2] Introduce PCI_FIXUP_IOMMU

2020-06-22 Thread Joerg Roedel
On Mon, Jun 01, 2020 at 12:41:04PM -0500, Bjorn Helgaas wrote: > I found this [1] from Paul Menzel, which was a slowdown caused by > quirk_usb_early_handoff(). I think the real problem is individual > quirks that take a long time. > > The PCI_FIXUP_IOMMU things we're talking about should be fast,

[PATCH] KEYS: asymmetric: fix error return code in software_key_query()

2020-06-22 Thread Wei Yongjun
Fix to return negative error code -ENOMEM from kmalloc() error handling case instead of 0, as done elsewhere in this function. Fixes: f1774cb8956a ("X.509: parse public key parameters from x509 for akcipher") Signed-off-by: Wei Yongjun --- crypto/asymmetric_keys/public_key.c | 2 +- 1 file chan

Re: [PATCH 1/3] crypto: permit users to specify numa node of acomp hardware

2020-06-22 Thread Jonathan Cameron
On Mon, 22 Jun 2020 11:24:23 +0100 "Song Bao Hua (Barry Song)" wrote: > > -Original Message- > > From: Jonathan Cameron > > Sent: Monday, June 22, 2020 9:59 PM > > To: Song Bao Hua (Barry Song) > > Cc: herb...@gondor.apana.org.au; da...@davemloft.net; Seth Jennings > > ; Linuxarm ; > > l

RE: [PATCH 1/3] crypto: permit users to specify numa node of acomp hardware

2020-06-22 Thread Song Bao Hua (Barry Song)
> -Original Message- > From: Jonathan Cameron > Sent: Monday, June 22, 2020 9:59 PM > To: Song Bao Hua (Barry Song) > Cc: herb...@gondor.apana.org.au; da...@davemloft.net; Seth Jennings > ; Linuxarm ; > linux-ker...@vger.kernel.org; linux...@kvack.org; > linux-crypto@vger.kernel.org; a...@

Re: [PATCH 1/3] crypto: permit users to specify numa node of acomp hardware

2020-06-22 Thread Jonathan Cameron
On Mon, 22 Jun 2020 14:48:59 +1200 Barry Song wrote: > For a Linux server with NUMA, there are possibly multiple (de)compressors > which are either local or remote to some NUMA node. Some drivers will > automatically use the (de)compressor near the CPU calling acomp_alloc(). > However, it is not