Re: [PATCH 0/2] Introduce PCI_FIXUP_IOMMU

2020-06-18 Thread Zhangfei Gao
Hi, Bjorn On 2020/6/16 上午7:52, Bjorn Helgaas wrote: On Sat, Jun 13, 2020 at 10:30:56PM +0800, Zhangfei Gao wrote: On 2020/6/11 下午9:44, Bjorn Helgaas wrote: +++ b/drivers/iommu/iommu.c @@ -2418,6 +2418,10 @@ int iommu_fwspec_init(struct device *dev, struct fwnode_handle *iommu_fwnode,

Re: Security Random Number Generator support

2020-06-18 Thread Neal Liu
Hi Marc, On Thu, 2020-06-18 at 10:50 +0100, Marc Zyngier wrote: > On 2020-06-03 08:54, Neal Liu wrote: > > Hi Neal, > > > Do you know which ARM expert could edict this standard? > > Or is there any chance that we can make one? And be reviewed by > > maintainers? > > It appears that ARM just rel

Re: [PATCH] crypto: ccp: remove redundant assignment to variable ret

2020-06-18 Thread Tom Lendacky
On 6/18/20 5:12 AM, Colin King wrote: From: Colin Ian King The variable ret is being assigned with a value that is never read and it is being updated later with a new value. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King A

Re: [PATCH] crypto: caam/qi2: remove redundant assignment to ret

2020-06-18 Thread Horia Geantă
On 6/18/2020 2:00 PM, Herbert Xu wrote: > On Thu, Jun 18, 2020 at 01:54:55PM +0300, Horia Geantă wrote: >> >> The proper fix would be updating the ahash_finup_no_ctx() function >> to return the specific error code: >> return ret; >> instead of returning -ENOMEM for all error cases. >> >> For e

Re: [PATCH] crypto: caam/qi2: remove redundant assignment to ret

2020-06-18 Thread Herbert Xu
On Thu, Jun 18, 2020 at 01:54:55PM +0300, Horia Geantă wrote: > > The proper fix would be updating the ahash_finup_no_ctx() function > to return the specific error code: > return ret; > instead of returning -ENOMEM for all error cases. > > For example error code returned by dpaa2_caam_enqueu

Re: [PATCH] crypto: caam/qi2: remove redundant assignment to ret

2020-06-18 Thread Horia Geantă
On 6/11/2020 6:39 PM, Colin King wrote: > From: Colin Ian King > > The variable ret is being assigned a value that is never read, the > error exit path via label 'unmap' returns -ENOMEM anyhow, so assigning > ret with -ENOMEM is redundamt. > > Addresses-Coverity: ("Unused value") > Signed-off-by

Re: [PATCH] crypto: caam/qi2: remove redundant assignment to ret

2020-06-18 Thread Herbert Xu
On Thu, Jun 18, 2020 at 01:40:55PM +0300, Horia Geantă wrote: > On 6/18/2020 10:58 AM, Herbert Xu wrote: > > On Thu, Jun 11, 2020 at 04:39:34PM +0100, Colin King wrote: > >> From: Colin Ian King > >> > >> The variable ret is being assigned a value that is never read, the > >> error exit path via l

Re: [PATCH] crypto: caam/qi2: remove redundant assignment to ret

2020-06-18 Thread Horia Geantă
On 6/18/2020 10:58 AM, Herbert Xu wrote: > On Thu, Jun 11, 2020 at 04:39:34PM +0100, Colin King wrote: >> From: Colin Ian King >> >> The variable ret is being assigned a value that is never read, the >> error exit path via label 'unmap' returns -ENOMEM anyhow, so assigning >> ret with -ENOMEM is r

[PATCH] crypto: img-hash: remove redundant initialization of variable err

2020-06-18 Thread Colin King
From: Colin Ian King The variable err is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/crypto/img-hash.c | 2 +

[PATCH] crypto: ccp: remove redundant assignment to variable ret

2020-06-18 Thread Colin King
From: Colin Ian King The variable ret is being assigned with a value that is never read and it is being updated later with a new value. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/crypto/ccp/ccp-ops.c | 1 - 1

Re: Security Random Number Generator support

2020-06-18 Thread Marc Zyngier
On 2020-06-03 08:54, Neal Liu wrote: Hi Neal, Do you know which ARM expert could edict this standard? Or is there any chance that we can make one? And be reviewed by maintainers? It appears that ARM just released a beta version of the spec at [1]. I'd encourage you (and anyone else) to have

Re: [PATCH] crypto: caam/qi2: remove redundant assignment to ret

2020-06-18 Thread Herbert Xu
On Thu, Jun 11, 2020 at 04:39:34PM +0100, Colin King wrote: > From: Colin Ian King > > The variable ret is being assigned a value that is never read, the > error exit path via label 'unmap' returns -ENOMEM anyhow, so assigning > ret with -ENOMEM is redundamt. > > Addresses-Coverity: ("Unused val

Re: [PATCH 0/3] crypto: qat - update admin interface

2020-06-18 Thread Herbert Xu
On Thu, Jun 11, 2020 at 10:14:46PM +0100, Giovanni Cabiddu wrote: > Refactor and update the admin interface in the qat driver. > > These changes are on top of "crypto: qat - remove packed attribute > in etr structs" (https://patchwork.kernel.org/patch/11586063/) > > Wojciech Ziemba (3): > crypt

Re: [PATCH] crypto: hisilicon - update SEC driver module parameter

2020-06-18 Thread Herbert Xu
On Mon, Jun 08, 2020 at 10:01:11PM +0800, Longfang Liu wrote: > As stress-ng running SEC engine on the Ubuntu OS, > we found that SEC only supports two threads each with one TFM > based on the default module parameter 'ctx_q_num'. > If running more threads, stress-ng will fail since it cannot > get

Re: [PATCH 0/2] crc-t10dif library improvements

2020-06-18 Thread Herbert Xu
Eric Biggers wrote: > This series makes some more improvements to lib/crc-t10dif.c, as discussed at > https://lkml.kernel.org/linux-crypto/20200604063324.ga28...@gondor.apana.org.au/T/#u > > This applies on top of Herbert's > "[v2 PATCH] crc-t10dif: Fix potential crypto notify dead-lock". > > Er

Re: [PATCH] padata: upgrade smp_mb__after_atomic to smp_mb in padata_do_serial

2020-06-18 Thread Herbert Xu
On Mon, Jun 08, 2020 at 05:26:52PM -0400, Daniel Jordan wrote: > A 5.7 kernel hangs during a tcrypt test of padata that waits for an AEAD > request to finish. This is only seen on large machines running many > concurrent requests. > > The issue is that padata never serializes the request. The re

Re: [PATCH v2] crypto: hisilicon - allow smaller reads in debugfs

2020-06-18 Thread Herbert Xu
On Tue, Jun 02, 2020 at 04:54:09PM +0300, Dan Carpenter wrote: > Originally this code rejected any read less than 256 bytes. There > is no need for this artificial limit. We should just use the normal > helper functions to read a string from the kernel. > > Signed-off-by: Dan Carpenter > --- >

Re: [PATCH v2] crypto: caam/qi2 - add support for dpseci_reset()

2020-06-18 Thread Herbert Xu
On Wed, Jun 03, 2020 at 11:47:04AM +0300, Andrei Botila wrote: > From: Andrei Botila > > Add support for dpseci_reset() command for DPSECI objects. > For DPSECI DPAA2 objects with version lower than v5.4 reset command > was broken in MC f/w. > > Signed-off-by: Andrei Botila > --- > Changes sinc

Re: [PATCH 0/3] Replace user types and remove packed

2020-06-18 Thread Herbert Xu
On Wed, Jun 03, 2020 at 06:33:43PM +0100, Giovanni Cabiddu wrote: > Remove user types across qat code base and replace packed attribute in > etr ring struct which causes a split lock. > > These changes are on top of "crypto: qat - fix parameter check in aead > encryption" (https://patchwork.kernel

Re: [PATCH] crypto: caam - add clock info for VFxxx SoCs

2020-06-18 Thread Herbert Xu
On Mon, Jun 01, 2020 at 04:07:26PM -0700, Andrey Smirnov wrote: > Add a small bit of plumbing necessary to use CAAM on VFxxx SoCs. > > Signed-off-by: Andrey Smirnov > Cc: Chris Healy > Cc: Horia Geantă > Cc: Herbert Xu > Cc: Fabio Estevam > Cc: linux-...@nxp.com > Cc: linux-crypto@vger.kernel

Re: [PATCH v2 0/2] hwrng: add support for Silex Insight BA431

2020-06-18 Thread Herbert Xu
On Mon, Jun 01, 2020 at 04:27:38PM +0200, Olivier Sobrie wrote: > Hello all, > > This set of patches aims at introducing a linux hwrng driver for the > Silex Insight BA431 IP which is available for various FPGA. > This hardware is for instance present in Silex Insight Viper OEM boards. > > The fi

Re: [PATCH] crypto: sa2ul: fix odd_ptr_err.cocci warnings

2020-06-18 Thread Tero Kristo
On 18/06/2020 10:28, Herbert Xu wrote: On Fri, Jun 12, 2020 at 11:22:02PM +0200, Julia Lawall wrote: From: kernel test robot PTR_ERR should normally access the value just tested by IS_ERR Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci Fixes: 5b8516f3bedb ("crypto: sa2ul: Add crypto

Re: [PATCH] crypto: qat - convert to SPDX License Identifiers

2020-06-18 Thread Herbert Xu
On Wed, May 27, 2020 at 04:21:28PM +0100, Giovanni Cabiddu wrote: > Replace License Headers with SPDX License Identifiers. > > Signed-off-by: Giovanni Cabiddu > --- > .../crypto/qat/qat_c3xxx/adf_c3xxx_hw_data.c | 48 +- > .../crypto/qat/qat_c3xxx/adf_c3xxx_hw_data.h | 48 +

Re: [PATCH] crypto: sa2ul: fix odd_ptr_err.cocci warnings

2020-06-18 Thread Herbert Xu
On Fri, Jun 12, 2020 at 11:22:02PM +0200, Julia Lawall wrote: > From: kernel test robot > > PTR_ERR should normally access the value just tested by IS_ERR > > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci > > Fixes: 5b8516f3bedb ("crypto: sa2ul: Add crypto driver") > CC: Keerthy > S

[PATCH] crypto: api - Prune inclusions in crypto.h

2020-06-18 Thread Herbert Xu
We haven't used string.h since the memcpy calls were removed so this patch removes its inclusion. The file uaccess.h isn't needed at all. However, removing it reveals that we do need to add an inclusion for refcount.h. Signed-off-by: Herbert Xu diff --git a/include/linux/crypto.h b/include/lin