Re: [PATCH v2 00/12] crypto: hisilicon - misc cleanup and optimizations

2020-05-14 Thread Herbert Xu
On Sat, May 09, 2020 at 05:43:53PM +0800, Shukun Tan wrote: > This patchset includes some misc updates. > patch 1-3: modify the accelerator probe process. > patch 4: refactor module parameter pf_q_num. > patch 5-6: add state machine and FLR support. > patch 7: remove use_dma_api related useless cod

Re: [PATCH] crypto: blake2b - Fix clang optimization for ARMv7-M

2020-05-14 Thread Herbert Xu
On Tue, May 05, 2020 at 03:53:45PM +0200, Arnd Bergmann wrote: > When building for ARMv7-M, clang-9 or higher tries to unroll some loops, > which ends up confusing the register allocator to the point of generating > rather bad code and using more than the warning limit for stack frames: > > warnin

Re: [PATCH 0/4] crypto: constify struct debugfs_reg32

2020-05-14 Thread Herbert Xu
On Sat, May 09, 2020 at 12:34:58AM +0200, Rikard Falkeborn wrote: > A small series constifying struct debugfs_reg32 where it can be made > const. There's no dependency between the patches. > > Rikard Falkeborn (4): > crypto: ccree - constify struct debugfs_reg32 > crypto: hisilicon/hpre - cons

Re: [PATCH -next] crypto: xilinx - Remove set but not used variable 'drv_ctx'

2020-05-14 Thread Herbert Xu
YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/crypto/xilinx/zynqmp-aes-gcm.c: In function 'zynqmp_aes_aead_cipher': > drivers/crypto/xilinx/zynqmp-aes-gcm.c:83:30: warning: > variable 'drv_ctx' set but not used [-Wunused-but-set-variable] > > commit bc86f9c54616

Re: [PATCH] crypto: Replace zero-length array with flexible-array

2020-05-14 Thread Herbert Xu
Gustavo A. R. Silva wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in C99: > > struct foo { >int stu

Re: [PATCH AUTOSEL 4.14 39/39] crypto: xts - simplify error handling in ->create()

2020-05-14 Thread Sasha Levin
On Thu, May 14, 2020 at 12:08:43PM -0700, Eric Biggers wrote: On Thu, May 14, 2020 at 02:54:56PM -0400, Sasha Levin wrote: From: Eric Biggers [ Upstream commit 732e540953477083082e999ff553622c59cffd5f ] Simplify the error handling in the XTS template's ->create() function by taking advantage

Re: [PATCH 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-14 Thread Lukasz Stelmach
It was <2020-05-14 czw 22:20>, when Stephan Mueller wrote: > Am Donnerstag, 14. Mai 2020, 21:07:33 CEST schrieb Łukasz Stelmach: > > Hi Łukasz, > >> The value has been estimaded by obtainig 1024 chunks of data 128 bytes >> (1024 bits) each from the generator and finding chunk with minimal >> entrop

Re: [PATCH 2/2] hwrng: exynos - Set the quality value

2020-05-14 Thread Stephan Mueller
Am Donnerstag, 14. Mai 2020, 21:07:34 CEST schrieb Łukasz Stelmach: Hi Łukasz, > The value has been estimaded by obtainig 1024 chunks of data 128 bytes > (1024 bits) each from the generator and finding chunk with minimal > entropy using the ent(1) tool. The value was 6.332937 bits of entropy > in

Re: [PATCH 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-14 Thread Stephan Mueller
Am Donnerstag, 14. Mai 2020, 21:07:33 CEST schrieb Łukasz Stelmach: Hi Łukasz, > The value has been estimaded by obtainig 1024 chunks of data 128 bytes > (1024 bits) each from the generator and finding chunk with minimal > entropy using the ent(1) tool. The value was 6.327820 bits of entropy > in

Re: [PATCH net-next 1/2] Crypto/chcr: Fixes compilations warnings

2020-05-14 Thread David Miller
From: Ayush Sawal Date: Thu, 14 May 2020 13:23:29 +0530 > @@ -256,7 +256,7 @@ static void get_aes_decrypt_key(unsigned char *dec_key, > return; > } > for (i = 0; i < nk; i++) > - w_ring[i] = be32_to_cpu(*(u32 *)&key[4 * i]); > + w_ring[i] = be32_t

[PATCH AUTOSEL 5.6 61/62] crypto: xts - simplify error handling in ->create()

2020-05-14 Thread Sasha Levin
From: Eric Biggers [ Upstream commit 732e540953477083082e999ff553622c59cffd5f ] Simplify the error handling in the XTS template's ->create() function by taking advantage of crypto_drop_skcipher() now accepting (as a no-op) a spawn that hasn't been grabbed yet. Signed-off-by: Eric Biggers Signe

[PATCH AUTOSEL 5.6 60/62] crypto: lrw - simplify error handling in create()

2020-05-14 Thread Sasha Levin
From: Eric Biggers [ Upstream commit d57063103332b95eac9c118900f35700a491da08 ] Simplify the error handling in the LRW template's ->create() function by taking advantage of crypto_drop_skcipher() now accepting (as a no-op) a spawn that hasn't been grabbed yet. Signed-off-by: Eric Biggers Signe

[PATCH 0/2] Set the quality value for two HW RNGs

2020-05-14 Thread Łukasz Stelmach
The rng structure contains the quality field which tells how many bits of entropy can be obtained from 1024 bits read from a device. With the quality value set the hw_random framework starts a kernel thread to feed the entropy pool in the CRNG, which helps to initialize it quickly especially during

[PATCH AUTOSEL 5.6 62/62] gcc-10: avoid shadowing standard library 'free()' in crypto

2020-05-14 Thread Sasha Levin
From: Linus Torvalds [ Upstream commit 1a263ae60b04de959d9ce9caea4889385eefcc7b ] gcc-10 has started warning about conflicting types for a few new built-in functions, particularly 'free()'. This results in warnings like: crypto/xts.c:325:13: warning: conflicting types for built-in function

Re: [PATCH AUTOSEL 4.14 39/39] crypto: xts - simplify error handling in ->create()

2020-05-14 Thread Eric Biggers
On Thu, May 14, 2020 at 02:54:56PM -0400, Sasha Levin wrote: > From: Eric Biggers > > [ Upstream commit 732e540953477083082e999ff553622c59cffd5f ] > > Simplify the error handling in the XTS template's ->create() function by > taking advantage of crypto_drop_skcipher() now accepting (as a no-op)

[PATCH 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-14 Thread Łukasz Stelmach
The value has been estimaded by obtainig 1024 chunks of data 128 bytes (1024 bits) each from the generator and finding chunk with minimal entropy using the ent(1) tool. The value was 6.327820 bits of entropy in each 8 bits of data. Signed-off-by: Łukasz Stelmach --- drivers/char/hw_random/iproc-

[PATCH 2/2] hwrng: exynos - Set the quality value

2020-05-14 Thread Łukasz Stelmach
The value has been estimaded by obtainig 1024 chunks of data 128 bytes (1024 bits) each from the generator and finding chunk with minimal entropy using the ent(1) tool. The value was 6.332937 bits of entropy in each 8 bits of data. Signed-off-by: Łukasz Stelmach --- drivers/char/hw_random/exynos

[PATCH AUTOSEL 5.4 48/49] crypto: xts - simplify error handling in ->create()

2020-05-14 Thread Sasha Levin
From: Eric Biggers [ Upstream commit 732e540953477083082e999ff553622c59cffd5f ] Simplify the error handling in the XTS template's ->create() function by taking advantage of crypto_drop_skcipher() now accepting (as a no-op) a spawn that hasn't been grabbed yet. Signed-off-by: Eric Biggers Signe

[PATCH AUTOSEL 5.4 49/49] gcc-10: avoid shadowing standard library 'free()' in crypto

2020-05-14 Thread Sasha Levin
From: Linus Torvalds [ Upstream commit 1a263ae60b04de959d9ce9caea4889385eefcc7b ] gcc-10 has started warning about conflicting types for a few new built-in functions, particularly 'free()'. This results in warnings like: crypto/xts.c:325:13: warning: conflicting types for built-in function

[PATCH AUTOSEL 5.4 47/49] crypto: lrw - simplify error handling in create()

2020-05-14 Thread Sasha Levin
From: Eric Biggers [ Upstream commit d57063103332b95eac9c118900f35700a491da08 ] Simplify the error handling in the LRW template's ->create() function by taking advantage of crypto_drop_skcipher() now accepting (as a no-op) a spawn that hasn't been grabbed yet. Signed-off-by: Eric Biggers Signe

[PATCH AUTOSEL 4.19 30/31] crypto: xts - simplify error handling in ->create()

2020-05-14 Thread Sasha Levin
From: Eric Biggers [ Upstream commit 732e540953477083082e999ff553622c59cffd5f ] Simplify the error handling in the XTS template's ->create() function by taking advantage of crypto_drop_skcipher() now accepting (as a no-op) a spawn that hasn't been grabbed yet. Signed-off-by: Eric Biggers Signe

[PATCH AUTOSEL 4.19 29/31] crypto: lrw - simplify error handling in create()

2020-05-14 Thread Sasha Levin
From: Eric Biggers [ Upstream commit d57063103332b95eac9c118900f35700a491da08 ] Simplify the error handling in the LRW template's ->create() function by taking advantage of crypto_drop_skcipher() now accepting (as a no-op) a spawn that hasn't been grabbed yet. Signed-off-by: Eric Biggers Signe

[PATCH AUTOSEL 4.19 31/31] gcc-10: avoid shadowing standard library 'free()' in crypto

2020-05-14 Thread Sasha Levin
From: Linus Torvalds [ Upstream commit 1a263ae60b04de959d9ce9caea4889385eefcc7b ] gcc-10 has started warning about conflicting types for a few new built-in functions, particularly 'free()'. This results in warnings like: crypto/xts.c:325:13: warning: conflicting types for built-in function

[PATCH AUTOSEL 4.14 39/39] crypto: xts - simplify error handling in ->create()

2020-05-14 Thread Sasha Levin
From: Eric Biggers [ Upstream commit 732e540953477083082e999ff553622c59cffd5f ] Simplify the error handling in the XTS template's ->create() function by taking advantage of crypto_drop_skcipher() now accepting (as a no-op) a spawn that hasn't been grabbed yet. Signed-off-by: Eric Biggers Signe

Re: linux-next: manual merge of the sound-asoc tree with the crypto tree

2020-05-14 Thread Ard Biesheuvel
On Tue, 12 May 2020 at 22:31, Arnd Bergmann wrote: > > On Tue, May 12, 2020 at 10:08 PM Eric Biggers wrote: > > On Tue, May 12, 2020 at 06:08:01PM +0100, Mark Brown wrote: > > > > For later: if SHASH_DESC_ON_STACK is causing problems, we really ought to > > find a > > better solution, since lots

[PATCH 1/1] dt-bindings: rng: Convert OMAP RNG to schema

2020-05-14 Thread Tero Kristo
Convert TI OMAP Random number generator bindings to DT schema. Signed-off-by: Tero Kristo --- .../devicetree/bindings/rng/omap_rng.txt | 38 - .../devicetree/bindings/rng/ti,omap-rng.yaml | 77 +++ 2 files changed, 77 insertions(+), 38 deletions(-) delete mode 1006

[PATCHv3 1/7] dt-bindings: crypto: Add TI SA2UL crypto accelerator documentation

2020-05-14 Thread Tero Kristo
From: Keerthy The Security Accelerator Ultra Lite (SA2UL) subsystem provides hardware cryptographic acceleration for the following use cases: * Encryption and authentication for secure boot * Encryption and authentication of content in applications requiring DRM (digital rights management) and

[PATCH net-next 0/2] Fixing compilation warnings and errors

2020-05-14 Thread Ayush Sawal
Patch 1: Fixes the warnings seen when compiling using sparse tool. Patch 2: Fixes a cocci check error introduced after commit 567be3a5d227 ("crypto: chelsio - Use multiple txq/rxq per tfm to process the requests"). Ayush Sawal (2): Crypto/chcr: Fixes compilations warnings Crypto/chcr: Fixes

[PATCH net-next 2/2] Crypto/chcr: Fixes a cocci check error

2020-05-14 Thread Ayush Sawal
This fixes an error observed after running coccinile check. drivers/crypto/chelsio/chcr_algo.c:1462:5-8: Unneeded variable: "err". Return "0" on line 1480 This line is missed in the commit 567be3a5d227 ("crypto: chelsio - Use multiple txq/rxq per tfm to process the requests"). Fixes: 567be3a5d227

[PATCH net-next 1/2] Crypto/chcr: Fixes compilations warnings

2020-05-14 Thread Ayush Sawal
This patch fixes the compilation warnings displayed by sparse tool for chcr driver. Signed-off-by: Ayush Sawal --- drivers/crypto/chelsio/chcr_algo.c | 8 drivers/crypto/chelsio/chcr_ipsec.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/chelsio/c