Move existing code to trusted keys subsystem. Also, rename files with
"tpm" as suffix which provides the underlying implementation.
Suggested-by: Jarkko Sakkinen
Signed-off-by: Sumit Garg
Reviewed-by: Jarkko Sakkinen
---
crypto/asymmetric_keys/asym_tpm.c| 2 +-
include/
Switch to utilize common heap based tpm_buf code for TPM based trusted
and asymmetric keys rather than using stack based tpm1_buf code. Also,
remove tpm1_buf code.
Suggested-by: Jarkko Sakkinen
Signed-off-by: Sumit Garg
Reviewed-by: Jarkko Sakkinen
Reviewed-by: Jerry Snitselaar
---
crypto/asy
Move TPM2 trusted keys code to trusted keys subsystem. The reason
being it's better to consolidate all the trusted keys code to a single
location so that it can be maintained sanely.
Also, utilize existing tpm_send() exported API which wraps the internal
tpm_transmit_cmd() API.
Suggested-by: Jark
Move tpm_buf code to common include/linux/tpm.h header so that it can
be reused via other subsystems like trusted keys etc.
Also rename trusted keys and asymmetric keys usage of TPM 1.x buffer
implementation to tpm1_buf to avoid any compilation errors.
Suggested-by: Jarkko Sakkinen
Signed-off-by
This patch-set does restructuring of trusted keys code to create and
consolidate trusted keys subsystem.
Also, patch #2 replaces tpm1_buf code used in security/keys/trusted.c and
crypto/asymmertic_keys/asym_tpm.c files to use the common tpm_buf code.
Changes in v8:
1. Rebased to latest tpmdd/mast
On Tue, Oct 15, 2019 at 09:16:57AM -0700, Davidlohr Bueso wrote:
> Because it is not a Rmw operation, atomic_set() is not serialized,
> and therefore the 'upgradable' smp_mb__after_atomic() call after
> the atomic_set() is completely bogus (not to mention the comment
> could also use some love, but
Agree with you, thanks!
Zaibo
.
On 2019/10/16 4:13, Rikard Falkeborn wrote:
Arguments are supposed to be ordered high then low.
Fixes: c8b4b477079d ("crypto: hisilicon - add HiSilicon HPRE accelerator")
Signed-off-by: Rikard Falkeborn
---
Spotted when trying to introduce compile time checkin
Arguments are supposed to be ordered high then low.
Fixes: c8b4b477079d ("crypto: hisilicon - add HiSilicon HPRE accelerator")
Signed-off-by: Rikard Falkeborn
---
Spotted when trying to introduce compile time checking that the order
of the arguments to GENMASK are correct [0]. I have only compile
* Ard Biesheuvel [191014 12:20]:
> Commit 7a7ffe65c8c5 ("crypto: skcipher - Add top-level skcipher interface")
> dated 20 august 2015 introduced the new skcipher API which is supposed to
> replace both blkcipher and ablkcipher. While all consumers of the API have
> been converted long ago, some pr
On Tue, Oct 15, 2019 at 01:11:38AM -0700, Christoph Hellwig wrote:
> On Fri, Oct 11, 2019 at 09:38:47PM -0700, Eric Biggers wrote:
> > This series converts the glue code for the SPARC64 crypto opcodes
> > implementations of AES, Camellia, DES, and 3DES modes from the
> > deprecated "blkcipher" API
Because it is not a Rmw operation, atomic_set() is not serialized,
and therefore the 'upgradable' smp_mb__after_atomic() call after
the atomic_set() is completely bogus (not to mention the comment
could also use some love, but that's a different matter).
This patch replaces these with smp_mb(), wh
On Tue, Oct 15, 2019 at 2:27 PM Ben Dooks wrote:
>
> The omap3_rom_rng_idle function takes a pointer, so give
> it a pointer instead of a plain 0. This fixes the following
> sparse warning:
>
> drivers/char/hw_random/omap3-rom-rng.c:115:28: warning: Using plain integer
> as NULL pointer
>
> Signe
On Tue, Oct 15, 2019 at 2:36 PM Ben Dooks wrote:
>
> Add __ioemm attribute to reg_rng to fix the following
> sparse warnings:
>
> drivers/char/hw_random/ks-sa-rng.c:102:9: warning: incorrect type in argument
> 2 (different address spaces)
> drivers/char/hw_random/ks-sa-rng.c:102:9:expected vo
Add __ioemm attribute to reg_rng to fix the following
sparse warnings:
drivers/char/hw_random/ks-sa-rng.c:102:9: warning: incorrect type in argument 2
(different address spaces)
drivers/char/hw_random/ks-sa-rng.c:102:9:expected void volatile [noderef]
*addr
drivers/char/hw_random/ks-sa-rng.
The omap3_rom_rng_idle function takes a pointer, so give
it a pointer instead of a plain 0. This fixes the following
sparse warning:
drivers/char/hw_random/omap3-rom-rng.c:115:28: warning: Using plain integer as
NULL pointer
Signed-off-by: Ben Dooks
---
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
On 12.10.19 22:18, Eric Biggers wrote:
> From: Eric Biggers
>
> Convert the glue code for the S390 CPACF protected key implementations
> of AES-ECB, AES-CBC, AES-XTS, and AES-CTR from the deprecated
> "blkcipher" API to the "skcipher" API. This is needed in order for the
> blkcipher API to be rem
On 12.10.19 22:18, Eric Biggers wrote:
> From: Eric Biggers
>
> Convert the glue code for the S390 CPACF implementations of AES-ECB,
> AES-CBC, AES-XTS, and AES-CTR from the deprecated "blkcipher" API to the
> "skcipher" API. This is needed in order for the blkcipher API to be
> removed.
>
> Note
From: kbuild test robot
drivers/crypto/amlogic/amlogic-gxl-core.c:241:1-9: WARNING: Use
devm_platform_ioremap_resource for mc -> base
Use devm_platform_ioremap_resource helper which wraps
platform_get_resource() and devm_ioremap_resource() together.
Generated by: scripts/coccinelle/api/devm_
On Tue, 15 Oct 2019 at 04:45, Eric Biggers wrote:
>
> This series converts the glue code for the PowerPC SPE implementations
> of AES-ECB, AES-CBC, AES-CTR, and AES-XTS from the deprecated
> "blkcipher" API to the "skcipher" API. This is needed in order for the
> blkcipher API to be removed.
>
>
On Tue, 15 Oct 2019 at 12:17, wrote:
>
> Hi, Ard,
>
> Thanks for working on this.
>
> On 10/14/2019 03:18 PM, Ard Biesheuvel wrote:
> > Commit 7a7ffe65c8c5 ("crypto: skcipher - Add top-level skcipher interface")
> > dated 20 august 2015 introduced the new skcipher API which is supposed to
> > repl
Hi, Ard,
Thanks for working on this.
On 10/14/2019 03:18 PM, Ard Biesheuvel wrote:
> Commit 7a7ffe65c8c5 ("crypto: skcipher - Add top-level skcipher interface")
> dated 20 august 2015 introduced the new skcipher API which is supposed to
> replace both blkcipher and ablkcipher. While all consumers
On 12.10.19 22:18, Eric Biggers wrote:
> From: Eric Biggers
>
> Convert the glue code for the S390 CPACF implementations of DES-ECB,
> DES-CBC, DES-CTR, 3DES-ECB, 3DES-CBC, and 3DES-CTR from the deprecated
> "blkcipher" API to the "skcipher" API. This is needed in order for the
> blkcipher API to
On Tue, 15 Oct 2019 at 12:00, Martin Willi wrote:
>
> Hi Ard,
>
> > Since turning the FPU on and off is cheap these days, simplify the
> > SIMD routine by dropping the per-page yield, which makes for a
> > cleaner switch to the library API as well.
>
> In my measurements that lazy FPU restore work
Hi Ard,
> Since turning the FPU on and off is cheap these days, simplify the
> SIMD routine by dropping the per-page yield, which makes for a
> cleaner switch to the library API as well.
In my measurements that lazy FPU restore works as intended, and I could
not identify any slowdown by this chan
On Tue, 15 Oct 2019 at 01:46, Jarkko Sakkinen
wrote:
>
> On Fri, Oct 11, 2019 at 02:05:17PM -0700, Jerry Snitselaar wrote:
> > On Fri Oct 11 19, Jarkko Sakkinen wrote:
> > > On Mon, Oct 07, 2019 at 10:55:31AM +0530, Sumit Garg wrote:
> > > > This patch-set does restructuring of trusted keys code t
On Tue, 15 Oct 2019 at 01:04, Jarkko Sakkinen
wrote:
>
> On Fri, Oct 11, 2019 at 03:37:57PM +0300, Jarkko Sakkinen wrote:
> > On Mon, Oct 07, 2019 at 10:55:31AM +0530, Sumit Garg wrote:
> > > This patch-set does restructuring of trusted keys code to create and
> > > consolidate trusted keys subsys
Add the logic to deal with input sizes that are not a round multiple
of the AES block size, as described by the XTS spec. This brings the
SPE implementation in line with other kernel drivers that have been
updated recently to take this into account.
Cc: Eric Biggers
Signed-off-by: Ard Biesheuvel
On Fri, Oct 11, 2019 at 09:38:47PM -0700, Eric Biggers wrote:
> This series converts the glue code for the SPARC64 crypto opcodes
> implementations of AES, Camellia, DES, and 3DES modes from the
> deprecated "blkcipher" API to the "skcipher" API. This is needed in
> order for the blkcipher API to
28 matches
Mail list logo
