Re: EIP97 kernel failure with af_alg/libaio

2019-10-13 Thread Stephan Mueller
Am Sonntag, 13. Oktober 2019, 10:49:07 CEST schrieb Gleb Pomykalov: Hi Gleb, > Hello, > > I'm trying to make EIP97 work on Mediatek mtk7623n (Banana PI R2). The > kernel version is 4.14.145. My tests uses af_alg in libaio mode, and > encrypts the data. For smaller blocks it works just fine, but

Re: [PATCH v2 3/4] crypto: amlogic: Add crypto accelerator for amlogic GXL

2019-10-13 Thread Randy Dunlap
Hi, On 10/13/19 10:31 PM, Corentin Labbe wrote: > diff --git a/drivers/crypto/amlogic/Kconfig b/drivers/crypto/amlogic/Kconfig > new file mode 100644 > index ..9c4bf96afeb3 > --- /dev/null > +++ b/drivers/crypto/amlogic/Kconfig > @@ -0,0 +1,24 @@ > +config CRYPTO_DEV_AMLOGIC_GXL > +

[PATCH v2 2/4] MAINTAINERS: Add myself as maintainer of amlogic crypto

2019-10-13 Thread Corentin Labbe
I will maintain the amlogic crypto driver. Signed-off-by: Corentin Labbe --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 36c5d6ee01f9..a8487a0999ce 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1477,6 +1477,13 @@ F: drivers/soc/am

[PATCH v2 4/4] ARM64: dts: amlogic: adds crypto hardware node

2019-10-13 Thread Corentin Labbe
This patch adds the GXL crypto hardware node for all GXL SoCs. Signed-off-by: Corentin Labbe --- arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi ind

[PATCH v2 1/4] dt-bindings: crypto: Add DT bindings documentation for amlogic-crypto

2019-10-13 Thread Corentin Labbe
This patch adds documentation for Device-Tree bindings for the Amlogic GXL cryptographic offloader driver. Signed-off-by: Corentin Labbe --- .../bindings/crypto/amlogic,gxl-crypto.yaml | 52 +++ 1 file changed, 52 insertions(+) create mode 100644 Documentation/devicetree/bind

[PATCH v2 0/4] crypto: add amlogic crypto offloader driver

2019-10-13 Thread Corentin Labbe
Hello This serie adds support for the crypto offloader present on amlogic GXL SoCs. Tested on meson-gxl-s905x-khadas-vim and meson-gxl-s905x-libretech-cc Regards Changes since v1: - renamed files and algo with gxl - removed unused reset handlings - splited the probe functions - splited meson_ci

[PATCH v2 3/4] crypto: amlogic: Add crypto accelerator for amlogic GXL

2019-10-13 Thread Corentin Labbe
This patch adds support for the amlogic GXL cryptographic offloader present on GXL SoCs. This driver supports AES cipher in CBC/ECB mode. Signed-off-by: Corentin Labbe --- drivers/crypto/Kconfig | 2 + drivers/crypto/Makefile | 1 + drivers/crypto/am

Re: [PATCH v2 0/4] crypto: add amlogic crypto offloader driver

2019-10-13 Thread Corentin Labbe
On Mon, Oct 14, 2019 at 07:18:35AM +0200, Corentin Labbe wrote: > Hello > > This serie adds support for the crypto offloader present on amlogic GXL > SoCs. > > Tested on meson-gxl-s905x-khadas-vim and meson-gxl-s905x-libretech-cc > > Regards > Oups sorry please ignore this patchset, I forgot t

[PATCH v2 4/4] ARM64: dts: amlogic: adds crypto hardware node

2019-10-13 Thread Corentin Labbe
This patch adds the GXL crypto hardware node for all GXL SoCs. Signed-off-by: Corentin Labbe --- arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi ind

[PATCH v2 3/4] crypto: amlogic: Add crypto accelerator for amlogic GXL

2019-10-13 Thread Corentin Labbe
This patch adds support for the amlogic GXL cryptographic offloader present on GXL SoCs. This driver supports AES cipher in CBC/ECB mode. Signed-off-by: Corentin Labbe --- drivers/crypto/Kconfig | 2 + drivers/crypto/Makefile | 1 + drivers/crypto/am

[PATCH v2 1/4] dt-bindings: crypto: Add DT bindings documentation for amlogic-crypto

2019-10-13 Thread Corentin Labbe
This patch adds documentation for Device-Tree bindings for the Amlogic GXL cryptographic offloader driver. Signed-off-by: Corentin Labbe --- .../bindings/crypto/amlogic,gxl-crypto.yaml | 52 +++ 1 file changed, 52 insertions(+) create mode 100644 Documentation/devicetree/bind

[PATCH v2 2/4] MAINTAINERS: Add myself as maintainer of amlogic crypto

2019-10-13 Thread Corentin Labbe
I will maintain the amlogic crypto driver. Signed-off-by: Corentin Labbe --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 36c5d6ee01f9..a8487a0999ce 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1477,6 +1477,13 @@ F: drivers/soc/am

[PATCH v2 0/4] crypto: add amlogic crypto offloader driver

2019-10-13 Thread Corentin Labbe
Hello This serie adds support for the crypto offloader present on amlogic GXL SoCs. Tested on meson-gxl-s905x-khadas-vim and meson-gxl-s905x-libretech-cc Regards Changes since v1: - renamed files and algo with gxl - removed unused reset handlings - splited the probe functions - splited meson_ci

Re: [PATCH] crypto: padlock-aes - convert to skcipher API

2019-10-13 Thread Eric Biggers
On Mon, Oct 14, 2019 at 04:47:27AM +, Jamie Heilman wrote: > Eric Biggers wrote: > > > I built a patched 5.3.6 with none of the crypto bits modularized > > > and you can find that dmesg and config at: > > > > > > http://audible.transient.net/~jamie/k/skcipher.config-5.3.6 > > > http://audible.

Re: [PATCH] crypto: padlock-aes - convert to skcipher API

2019-10-13 Thread Jamie Heilman
Eric Biggers wrote: > > I built a patched 5.3.6 with none of the crypto bits modularized > > and you can find that dmesg and config at: > > > > http://audible.transient.net/~jamie/k/skcipher.config-5.3.6 > > http://audible.transient.net/~jamie/k/skcipher.dmesg > > > > Great, I don't see any test

Re: [PATCH] crypto: padlock-aes - convert to skcipher API

2019-10-13 Thread Eric Biggers
On Sun, Oct 13, 2019 at 11:20:51PM +, Jamie Heilman wrote: > Eric Biggers wrote: > > From: Eric Biggers > > > > Convert the VIA PadLock implementations of AES-ECB and AES-CBC from the > > deprecated "blkcipher" API to the "skcipher" API. This is needed in > > order for the blkcipher API to b

Re: [PATCH v4 0/5] BLAKE2b generic implementation

2019-10-13 Thread Eric Biggers
On Sun, Oct 13, 2019 at 09:50:52PM +0200, David Sterba wrote: > On Fri, Oct 11, 2019 at 10:57:40AM -0700, Eric Biggers wrote: > > The choice of data lengths seems a bit unusual, as they include every > > length in > > two ranges but nothing in between. Also, none of the lengths except 0 is a > >

Re: [PATCH] crypto: padlock-aes - convert to skcipher API

2019-10-13 Thread Jamie Heilman
Eric Biggers wrote: > From: Eric Biggers > > Convert the VIA PadLock implementations of AES-ECB and AES-CBC from the > deprecated "blkcipher" API to the "skcipher" API. This is needed in > order for the blkcipher API to be removed. > > Signed-off-by: Eric Biggers > --- > > This is compile-tes

Re: [PATCH v4 0/5] BLAKE2b generic implementation

2019-10-13 Thread David Sterba
On Fri, Oct 11, 2019 at 10:57:40AM -0700, Eric Biggers wrote: > The choice of data lengths seems a bit unusual, as they include every length > in > two ranges but nothing in between. Also, none of the lengths except 0 is a > multiple of the blake2b block size. Instead, maybe use something like >

Re: [PATCH 0/4] crypto: nx - convert to skcipher API

2019-10-13 Thread Ard Biesheuvel
On Sun, 13 Oct 2019 at 20:56, Eric Biggers wrote: > > On Sun, Oct 13, 2019 at 05:31:31PM +0200, Ard Biesheuvel wrote: > > On Sun, 13 Oct 2019 at 08:29, Ard Biesheuvel > > wrote: > > > > > > On Sun, 13 Oct 2019 at 06:40, Eric Biggers wrote: > > > > > > > > This series converts the PowerPC Nest (

Re: [PATCH 0/4] crypto: nx - convert to skcipher API

2019-10-13 Thread Eric Biggers
On Sun, Oct 13, 2019 at 05:31:31PM +0200, Ard Biesheuvel wrote: > On Sun, 13 Oct 2019 at 08:29, Ard Biesheuvel > wrote: > > > > On Sun, 13 Oct 2019 at 06:40, Eric Biggers wrote: > > > > > > This series converts the PowerPC Nest (NX) implementations of AES modes > > > from the deprecated "blkciph

Re: [PATCH v4 1/5] crypto: add blake2b generic implementation

2019-10-13 Thread David Sterba
On Fri, Oct 11, 2019 at 11:04:40AM -0700, Eric Biggers wrote: > > +struct blake2b_param > > +{ > > It should be 'struct blake2b_param {' > > checkpatch.pl should warn about this. Can you fix the checkpatch warnings > that > make sense to fix? I fixed all the { at the end of line of struct defi

Re: [PATCH 0/4] crypto: nx - convert to skcipher API

2019-10-13 Thread Ard Biesheuvel
On Sun, 13 Oct 2019 at 08:29, Ard Biesheuvel wrote: > > On Sun, 13 Oct 2019 at 06:40, Eric Biggers wrote: > > > > This series converts the PowerPC Nest (NX) implementations of AES modes > > from the deprecated "blkcipher" API to the "skcipher" API. This is > > needed in order for the blkcipher A

EIP97 kernel failure with af_alg/libaio

2019-10-13 Thread Gleb Pomykalov
Hello, I'm trying to make EIP97 work on Mediatek mtk7623n (Banana PI R2). The kernel version is 4.14.145. My tests uses af_alg in libaio mode, and encrypts the data. For smaller blocks it works just fine, but if I increase the size I'm getting the kernel error (it fails on 8k block and larger, 4k