Re: [Patch v6 4/4] KEYS: trusted: Move TPM2 trusted keys code

2019-09-17 Thread Sumit Garg
On Tue, 17 Sep 2019 at 23:45, Jarkko Sakkinen wrote: > > On Tue, Sep 17, 2019 at 09:14:15PM +0300, Jarkko Sakkinen wrote: > > On Mon, Sep 16, 2019 at 04:04:24PM +0530, Sumit Garg wrote: > > > Move TPM2 trusted keys code to trusted keys subsystem. The reason > > > being it's better to consolidate a

Re: [PATCH 07/12] crypto: caam - use devres to de-initialize the RNG

2019-09-17 Thread Andrey Smirnov
On Mon, Sep 9, 2019 at 8:39 AM Horia Geanta wrote: > > On 9/4/2019 5:35 AM, Andrey Smirnov wrote: > > Use devres to de-initialize the RNG and drop explicit de-initialization > > code in caam_remove(). > > > > Signed-off-by: Andrey Smirnov > > Cc: Chris Healy > > Cc: Lucas Stach > > Cc: Horia Ge

Re: [PATCH] crypto: caam - use the same jr for rng init/exit

2019-09-17 Thread Andrey Smirnov
On Wed, Sep 11, 2019 at 2:35 AM Horia Geanta wrote: > > On 9/4/2019 5:35 AM, Andrey Smirnov wrote: > > In order to allow caam_jr_enqueue() to lock underlying JR's > > device (via device_lock(), see commit that follows) we need to make > > sure that no code calls caam_jr_enqueue() as a part of caam

Re: [PATCH 12/12] crypto: caam - change JR device ownership scheme

2019-09-17 Thread Andrey Smirnov
On Fri, Sep 13, 2019 at 12:16 PM Leonard Crestez wrote: > > On 04.09.2019 05:35, Andrey Smirnov wrote: > > Returning -EBUSY from platform device's .remove() callback won't stop > > the removal process, so the code in caam_jr_remove() is not going to > > have the desired effect of preventing JR fro

Re: [PATCH v4 2/3] dt-bindings: rng: add bindings for MediaTek ARMv8 SoCs

2019-09-17 Thread Neal Liu
On Tue, 2019-07-23 at 22:35 +0800, Rob Herring wrote: > On Mon, Jul 22, 2019 at 8:21 PM Neal Liu wrote: > > > > Please don't top post to lists. > > > Dear Rob, > > You can check my driver for detail: > > http://patchwork.kernel.org/patch/11012475/ or patchset 3/3 > > I could, or

Re: [PATCH v3 1/2] dt-binding: hwrng: add NPCM RNG documentation

2019-09-17 Thread Rob Herring
On Thu, 12 Sep 2019 12:01:48 +0300, Tomer Maimon wrote: > Added device tree binding documentation for Nuvoton BMC > NPCM Random Number Generator (RNG). > > Signed-off-by: Tomer Maimon > --- > .../devicetree/bindings/rng/nuvoton,npcm-rng.txt | 12 > 1 file changed, 12 insertions(

Re: [Patch v6 4/4] KEYS: trusted: Move TPM2 trusted keys code

2019-09-17 Thread Jarkko Sakkinen
On Tue, Sep 17, 2019 at 09:14:15PM +0300, Jarkko Sakkinen wrote: > On Mon, Sep 16, 2019 at 04:04:24PM +0530, Sumit Garg wrote: > > Move TPM2 trusted keys code to trusted keys subsystem. The reason > > being it's better to consolidate all the trusted keys code to a single > > location so that it can

Re: [Patch v6 4/4] KEYS: trusted: Move TPM2 trusted keys code

2019-09-17 Thread Jarkko Sakkinen
On Mon, Sep 16, 2019 at 04:04:24PM +0530, Sumit Garg wrote: > Move TPM2 trusted keys code to trusted keys subsystem. The reason > being it's better to consolidate all the trusted keys code to a single > location so that it can be maintained sanely. > > Suggested-by: Jarkko Sakkinen > Signed-off-b

Re: [PATCH] hw_random: don't wait on add_early_randomness()

2019-09-17 Thread Theodore Y. Ts'o
On Tue, Sep 17, 2019 at 11:54:50AM +0200, Laurent Vivier wrote: > add_early_randomness() is called by hwrng_register() when the > hardware is added. If this hardware and its module are present > at boot, and if there is no data available the boot hangs until > data are available and can't be interr

Re: [PATCH] hw_random: don't wait on add_early_randomness()

2019-09-17 Thread Laurent Vivier
On 17/09/2019 14:40, Herbert Xu wrote: > On Tue, Sep 17, 2019 at 11:54:50AM +0200, Laurent Vivier wrote: >> add_early_randomness() is called by hwrng_register() when the >> hardware is added. If this hardware and its module are present >> at boot, and if there is no data available the boot hangs un

Re: [PATCH] hw_random: don't wait on add_early_randomness()

2019-09-17 Thread Herbert Xu
On Tue, Sep 17, 2019 at 11:54:50AM +0200, Laurent Vivier wrote: > add_early_randomness() is called by hwrng_register() when the > hardware is added. If this hardware and its module are present > at boot, and if there is no data available the boot hangs until > data are available and can't be interr

[PATCH 1/3] crypto: inside-secure - Added support for the rfc4106(gcm(aes)) AEAD

2019-09-17 Thread Pascal van Leeuwen
This patch adds support for rfc4106(gcm(aes)) for use with IPsec ESP Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 1 + drivers/crypto/inside-secure/safexcel_cipher.c | 112

[PATCH 3/3] crypto: inside-secure - Added support for the rfc4309(ccm(aes)) AEAD

2019-09-17 Thread Pascal van Leeuwen
This patch adds support for rfc4309(ccm(aes)) for use with IPsec ESP Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 5 +- drivers/crypto/inside-secure/safexcel_cipher.c | 165 +++

[PATCH 0/3] crypto: inside-secure - Add ESP GCM/GMAC/CCM variants

2019-09-17 Thread Pascal van Leeuwen
This patchset adds support for the rfc4106(gcm(aes)), rfc4543(gcm(aes)) and rfc4309(ccm(aes)) ciphersuites intended for IPsec ESP acceleration. The patchset has been tested with the eip197c_iewxkbc configuration on the Xilinx VCU118 development boardi as well as on the Macchiatobin board, includin

[PATCH 2/3] crypto: inside-secure - Added support for the rfc4543(gcm(aes)) "AEAD"

2019-09-17 Thread Pascal van Leeuwen
This patch adds support for rfc4543(gcm(aes)) - i.e. AES-GMAC - for use with IPsec ESP Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 2 + drivers/crypto/inside-secure/safexcel_cipher.c | 86 +

[PATCH 2/2] crypto: inside-secure - Fixed corner case TRC admin RAM probing issue

2019-09-17 Thread Pascal van Leeuwen
This patch fixed a corner case admin RAM probing issue witnessed on the Xilinx VCU118 FPGA development board with an EIP197 configuration with 4096 words of admin RAM, of which only 2050 were recognised. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 48 +

[PATCH 1/2] crypto: inside-secure: [URGENT] Fix stability issue with Macchiatobin

2019-09-17 Thread Pascal van Leeuwen
This patch corrects an error in the Transform Record Cache initialization code that was causing intermittent stability problems on the Macchiatobin board. Unfortunately, due to HW platform specifics, the problem could not happen on the main development platform, being the VCU118 Xilinx development

[PATCH 0/2] crypto: inside-secure: [URGENT] Fix stability issue

2019-09-17 Thread Pascal van Leeuwen
This patchset fixes some issues with the TRC RAM probing that caused instability (random failures) on the Macchiatobin board and incorrect configuration of the TRC for some other corner case RAM configuration. The patchset has been tested with the eip197c_iewxkbc configuration with 163840 bytes of

[PATCH] hw_random: don't wait on add_early_randomness()

2019-09-17 Thread Laurent Vivier
add_early_randomness() is called by hwrng_register() when the hardware is added. If this hardware and its module are present at boot, and if there is no data available the boot hangs until data are available and can't be interrupted. To avoid that, call rng_get_data() in non-blocking mode (wait=0)

[PATCH 1/2] crypto: arm/aes-ce - build for v8 architecture explicitly

2019-09-17 Thread Ard Biesheuvel
From: Ard Biesheuvel The NEON/Crypto Extensions based AES implementation for 32-bit ARM can be built in a kernel that targets ARMv6 CPUs and higher, even though the actual code will not be able to run on that generation, but it allows for a portable image to be generated that can will use the spe

[PATCH 2/2] crypto: arm/aes-ce - add dependency on AES library

2019-09-17 Thread Ard Biesheuvel
From: Ard Biesheuvel The ARM accelerated AES driver depends on the new AES library for its non-SIMD fallback so express this in its Kconfig declaration. Signed-off-by: Ard Biesheuvel --- arch/arm/crypto/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/crypto/Kconfig b/arch/