Re: [PATCH 3/9] dt-bindings: crypto: Add DT bindings documentation for sun8i-ce Crypto Engine

2019-09-12 Thread Chen-Yu Tsai
On Thu, Sep 12, 2019 at 9:33 PM Maxime Ripard wrote: > > On Thu, Sep 12, 2019 at 09:26:27PM +0100, Chen-Yu Tsai wrote: > > > > > > > > clock-names: > > > > items: > > > > - const: ahb > > > > - const: mod > > > > - const: mbus > > > > > > And here as well > > > > > > Someth

Re: [PATCH 3/9] dt-bindings: crypto: Add DT bindings documentation for sun8i-ce Crypto Engine

2019-09-12 Thread Maxime Ripard
On Thu, Sep 12, 2019 at 09:26:27PM +0100, Chen-Yu Tsai wrote: > > > > > > clock-names: > > > items: > > > - const: ahb > > > - const: mod > > > - const: mbus > > > > And here as well > > > > Something I missed earlier though was that we've tried to unify as > > much as possi

Re: [PATCH 3/9] dt-bindings: crypto: Add DT bindings documentation for sun8i-ce Crypto Engine

2019-09-12 Thread Chen-Yu Tsai
On Thu, Sep 12, 2019 at 10:37 AM Maxime Ripard wrote: > > Hi Corentin, > > On Wed, Sep 11, 2019 at 08:31:58PM +0200, Corentin Labbe wrote: > > On Sat, Sep 07, 2019 at 07:01:16AM +0300, Maxime Ripard wrote: > > > On Fri, Sep 06, 2019 at 08:45:45PM +0200, Corentin Labbe wrote: > > > > This patch add

Re: [PATCH v3 2/2] hwrng: npcm: add NPCM RNG driver

2019-09-12 Thread Vinod Koul
On 12-09-19, 12:01, Tomer Maimon wrote: > Add Nuvoton NPCM BMC Random Number Generator(RNG) driver. Is this a true RNG or a psedo RNG, in case of latter it should be added in drivers/crypto/. See crypto_register_rng() > > Signed-off-by: Tomer Maimon > --- > drivers/char/hw_random/Kconfig|

[PATCH] hw_random: move add_early_randomness() out of rng_mutex

2019-09-12 Thread Laurent Vivier
add_early_randomness() is called every time a new rng backend is added and every time it is set as the current rng provider. add_early_randomness() is called from functions locking rng_mutex, and if it hangs all the hw_random framework hangs: we can't read sysfs, add or remove a backend. This pat

[PATCHv2 3/3] crypto: testmgr - Added testvectors for the hmac(sm3) ahash

2019-09-12 Thread Pascal van Leeuwen
Added testvectors for the hmac(sm3) ahash authentication algorithm changes since v1: - nothing Signed-off-by: Pascal van Leeuwen --- crypto/testmgr.c | 6 ++ crypto/testmgr.h | 56 2 files changed, 62 insertions(+) diff --git a/cryp

[PATCHv2 2/3] crypto: inside-secure - Added support for HMAC-SM3 ahash

2019-09-12 Thread Pascal van Leeuwen
Added support for the hmac(sm3) ahash authentication algorithm changes since v1: - added Acked-by tag below, no changes to the source Acked-by: Antoine Tenart Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 1 + drivers/crypto/inside-secure/safexcel.h

[PATCHv2 0/3] crypto: inside-secure - Add support for (HMAC) SM3

2019-09-12 Thread Pascal van Leeuwen
Extend driver support with sm3 and hmac(sm3) ahash support. Also add GM/T 0042-2015 hmac(sm3) testvectors to the testmgr. The patchset has been tested with the eip197c_iewxkbc configuration on the Xilinx VCU118 development board, including the crypto extra tests. Note that this patchset applies on

[PATCHv2 1/3] crypto: inside-secure - Added support for basic SM3 ahash

2019-09-12 Thread Pascal van Leeuwen
Added support for the SM3 ahash algorithm changes since v1: - moved definition of CONTEXT_CONTROL_CRYPTO_ALG_SM3 (0x7) up above 0xf Acked-by: Antoine Tenart Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 1 + drivers/crypto/inside-secure/safexcel.h |

[PATCHv2 2/2] crypto: inside-secure - Add support for the Chacha20-Poly1305 AEAD

2019-09-12 Thread Pascal van Leeuwen
This patch adds support for the Chacha20-Poly1305 cipher suite. It adds both the basic rfc7539(chacha20,poly1305) as well as the rfc7539esp(chacha20,poly1305) variant for IPsec ESP acceleration. changes since v1: - changed char to u8 (2x) - clarified comment for safexcel_cipher_ctx.aead - added a

[PATCHv2 1/2] crypto: inside-secure - Added support for the CHACHA20 skcipher

2019-09-12 Thread Pascal van Leeuwen
Added support for the CHACHA20 skcipher algorithm. Tested on an eip197c-iesb configuration in the Xilinx VCU118 devboard, passes all testmgr vectors plus the extra fuzzing tests. changes since v1: - changed switch statement entry from default to explicit+empty default Signed-off-by: Pascal van Le

[PATCHv2 0/2] rypto: inside-secure: Add support for the Chacha20 skcipher and the Chacha20-Poly1305 AEAD suites

2019-09-12 Thread Pascal van Leeuwen
Extend driver support with chacha20, rfc7539(chacha20,poly1305) and rfc7539esp(chacha20,poly1305) ciphers. The patchset has been tested with the eip197c_iesb and eip197c_iewxkbc configurations on the Xilinx VCU118 development board, including the crypto extra tests. Note that this patchset applies

Re: [PATCH 3/9] dt-bindings: crypto: Add DT bindings documentation for sun8i-ce Crypto Engine

2019-09-12 Thread Maxime Ripard
Hi Corentin, On Wed, Sep 11, 2019 at 08:31:58PM +0200, Corentin Labbe wrote: > On Sat, Sep 07, 2019 at 07:01:16AM +0300, Maxime Ripard wrote: > > On Fri, Sep 06, 2019 at 08:45:45PM +0200, Corentin Labbe wrote: > > > This patch adds documentation for Device-Tree bindings for the > > > Crypto Engine

[PATCH v3 2/2] hwrng: npcm: add NPCM RNG driver

2019-09-12 Thread Tomer Maimon
Add Nuvoton NPCM BMC Random Number Generator(RNG) driver. Signed-off-by: Tomer Maimon --- drivers/char/hw_random/Kconfig| 13 +++ drivers/char/hw_random/Makefile | 1 + drivers/char/hw_random/npcm-rng.c | 186 ++ 3 files changed, 200 insertions(+) create mod

[PATCH v3 0/2] hwrng: npcm: add NPCM RNG driver support

2019-09-12 Thread Tomer Maimon
This patch set adds Random Number Generator (RNG) support for the Nuvoton NPCM Baseboard Management Controller (BMC). The RNG driver we use power consumption when the RNG is not required. The NPCM RNG driver tested on NPCM750 evaluation board. Addressed comments from:. - Daniel Thompson: http

[PATCH v3 1/2] dt-binding: hwrng: add NPCM RNG documentation

2019-09-12 Thread Tomer Maimon
Added device tree binding documentation for Nuvoton BMC NPCM Random Number Generator (RNG). Signed-off-by: Tomer Maimon --- .../devicetree/bindings/rng/nuvoton,npcm-rng.txt | 12 1 file changed, 12 insertions(+) create mode 100644 Documentation/devicetree/bindings/rng/nuvoton,n

Re: [PATCH 2/2] crypto: sun4i-ss: enable pm_runtime

2019-09-12 Thread Corentin Labbe
On Thu, Sep 12, 2019 at 08:35:51AM +0200, Maxime Ripard wrote: > Hi, > > Le mer. 11 sept. 2019 à 13:46, Corentin Labbe > a écrit : > > > > This patch enables power management on the Security System. > > > > Signed-off-by: Corentin Labbe > > --- > > drivers/crypto/sunxi-ss/sun4i-ss-cipher.c | 5