[PATCH] crypto: user - fix potential warnings in cryptouser.h

2019-06-08 Thread Masahiro Yamada
Function definitions in headers are usually marked as 'static inline'. Since 'inline' is missing for crypto_reportstat(), if it were not referenced from a .c file that includes this header, it would produce a warning. Also, 'struct crypto_user_alg' should be forward declared so that we do not rel

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-08 Thread Ard Biesheuvel
On Sat, 8 Jun 2019 at 16:37, Ard Biesheuvel wrote: > > On Sat, 8 Jun 2019 at 15:03, Sandy Harris wrote: > > > > First off, it is not clear we should implement WEP at all since it is > > fatally flawed. This has been known for about a decade, there have > > been at least two better algorithms adde

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-08 Thread Ard Biesheuvel
On Sat, 8 Jun 2019 at 15:03, Sandy Harris wrote: > > First off, it is not clear we should implement WEP at all since it is > fatally flawed. This has been known for about a decade, there have > been at least two better algorithms added to the standards, & the only > reason anyone would need WEP to

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-08 Thread Sandy Harris
First off, it is not clear we should implement WEP at all since it is fatally flawed. This has been known for about a decade, there have been at least two better algorithms added to the standards, & the only reason anyone would need WEP today would be to connect to an old router in an obviously ins