Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Denis Kenzior
Hi Eric, On 06/07/2019 05:40 PM, Eric Biggers wrote: On Fri, Jun 07, 2019 at 04:54:04PM -0500, Denis Kenzior wrote: Hi Eric, On 06/07/2019 04:41 PM, Eric Biggers wrote: On Fri, Jun 07, 2019 at 04:28:59PM -0500, Denis Kenzior wrote: Hi Eric, On 06/07/2019 04:15 PM, Eric Biggers wrote: On Fr

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Eric Biggers
On Fri, Jun 07, 2019 at 04:54:04PM -0500, Denis Kenzior wrote: > Hi Eric, > > On 06/07/2019 04:41 PM, Eric Biggers wrote: > > On Fri, Jun 07, 2019 at 04:28:59PM -0500, Denis Kenzior wrote: > > > Hi Eric, > > > > > > On 06/07/2019 04:15 PM, Eric Biggers wrote: > > > > On Fri, Jun 07, 2019 at 03:45

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Denis Kenzior
Hi Eric, On 06/07/2019 04:41 PM, Eric Biggers wrote: On Fri, Jun 07, 2019 at 04:28:59PM -0500, Denis Kenzior wrote: Hi Eric, On 06/07/2019 04:15 PM, Eric Biggers wrote: On Fri, Jun 07, 2019 at 03:45:45PM -0500, Denis Kenzior wrote: Hi Ard, Ah ok, good to know. That does imply that the dri

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Eric Biggers
On Fri, Jun 07, 2019 at 04:28:59PM -0500, Denis Kenzior wrote: > Hi Eric, > > On 06/07/2019 04:15 PM, Eric Biggers wrote: > > On Fri, Jun 07, 2019 at 03:45:45PM -0500, Denis Kenzior wrote: > > > Hi Ard, > > > > > > > > > > > Ah ok, good to know. That does imply that the driver is not entirely >

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Denis Kenzior
Hi Eric, On 06/07/2019 04:15 PM, Eric Biggers wrote: On Fri, Jun 07, 2019 at 03:45:45PM -0500, Denis Kenzior wrote: Hi Ard, Ah ok, good to know. That does imply that the driver is not entirely broken, which is good news I suppose. Not entirely, but we did have to resort to using multiple

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Eric Biggers
On Fri, Jun 07, 2019 at 03:45:45PM -0500, Denis Kenzior wrote: > Hi Ard, > > > > > Ah ok, good to know. That does imply that the driver is not entirely > > broken, which is good news I suppose. > > > > Not entirely, but we did have to resort to using multiple sockets, otherwise > parallel encry

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Denis Kenzior
Hi Ard, Ah ok, good to know. That does imply that the driver is not entirely broken, which is good news I suppose. Not entirely, but we did have to resort to using multiple sockets, otherwise parallel encrypt/decrypt operations on the socket would result in invalid behavior. Probably due

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Ard Biesheuvel
On Fri, 7 Jun 2019 at 22:24, Marcel Holtmann wrote: > > Hi Eric, > > >> One of the issues that I would like to see addressed in the crypto API > >> is they way the cipher abstraction is used. In general, a cipher should > >> never be used directly, and so it would be much better to clean up the >

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Marcel Holtmann
Hi Eric, >> One of the issues that I would like to see addressed in the crypto API >> is they way the cipher abstraction is used. In general, a cipher should >> never be used directly, and so it would be much better to clean up the >> existing uses of ciphers outside of the crypto subsystem itself

[PATCH v2 0/4] crypto: caam - Add i.MX8MQ support

2019-06-07 Thread Andrey Smirnov
Everyone: Picking up where Chris left off (I chatted with him privately beforehead), this series adds support for i.MX8MQ to CAAM driver. Just like [v1], this series is i.MX8MQ only. Feedback is welcome! Thanks, Andrey Smirnov Changes since [v1] - Series reworked to continuse using register b

[PATCH v2 2/4] crypto: caam - move DMA mask selection into a function

2019-06-07 Thread Andrey Smirnov
Exactly the same code to figure out DMA mask is repeated twice in the driver code. To avoid repetition, move that logic into a standalone subroutine in intern.h. While at it re-shuffle the code to make it more readable with early returns. Signed-off-by: Andrey Smirnov Cc: Chris Spencer Cc: Cory

[PATCH v2 1/4] crypto: caam - do not initialise clocks on the i.MX8

2019-06-07 Thread Andrey Smirnov
From: Chris Spencer There are no clocks that the CAAM driver needs to initialise on the i.MX8. Signed-off-by: Aymen Sghaier Signed-off-by: Chris Spencer Signed-off-by: Andrey Smirnov Cc: Chris Spencer Cc: Cory Tusar Cc: Chris Healy Cc: Lucas Stach Cc: Horia Geantă Cc: Aymen Sghaier Cc:

[PATCH v2 3/4] crypto: caam - correct DMA address size for the i.MX8

2019-06-07 Thread Andrey Smirnov
From: Chris Spencer The i.MX8 is arm64, but its CAAM DMA address size is 32-bits. Signed-off-by: Aymen Sghaier Signed-off-by: Franck LENORMAND Signed-off-by: Chris Spencer Signed-off-by: Andrey Smirnov Cc: Chris Spencer Cc: Cory Tusar Cc: Chris Healy Cc: Lucas Stach Cc: Horia Geantă Cc:

[PATCH v2 4/4] crypto: caam - always select job ring via RSR on i.MX8MQ

2019-06-07 Thread Andrey Smirnov
Per feedback from NXP tech support the way to use register based service interface on i.MX8MQ is to follow the same set of steps outlined for the case when virtualization is enabled, regardless if it is. Current version of SRM for i.MX8MQ speaks of DECO DID_MS and DECO DID_LS registers, but apparen

Re: [PATCH 1/2] dt-bindings: rng: Document BCM7211 RNG compatible string

2019-06-07 Thread Florian Fainelli
On 5/10/19 10:31 AM, Florian Fainelli wrote: > BCM7211 features a RNG200 block, document its compatible string. > > Signed-off-by: Florian Fainelli Rob, does this look okay to you? > --- > Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt | 1 + > 1 file changed, 1 insertion(+) > >

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Ard Biesheuvel
On Fri, 7 Jun 2019 at 19:59, Eric Biggers wrote: > > On Fri, Jun 07, 2019 at 04:49:41PM +0200, Ard Biesheuvel wrote: > > One of the issues that I would like to see addressed in the crypto API > > is they way the cipher abstraction is used. In general, a cipher should > > never be used directly, an

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Eric Biggers
On Fri, Jun 07, 2019 at 04:49:41PM +0200, Ard Biesheuvel wrote: > One of the issues that I would like to see addressed in the crypto API > is they way the cipher abstraction is used. In general, a cipher should > never be used directly, and so it would be much better to clean up the > existing uses

[RFC PATCH 3/3] lib80211/wep: switch to skcipher interface for arc4

2019-06-07 Thread Ard Biesheuvel
The WEP code uses the arc4 cipher interface, and invokes it byte by byte. This is rather inefficient, and since the cipher interface in general is not really suitable for use outside of the crypto subsystem, move this code to use the skcipher interface instead. Given that the only driver that prov

[RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Ard Biesheuvel
One of the issues that I would like to see addressed in the crypto API is they way the cipher abstraction is used. In general, a cipher should never be used directly, and so it would be much better to clean up the existing uses of ciphers outside of the crypto subsystem itself, so that we can make

[RFC PATCH 1/3] net/mac80211: switch to skcipher interface for arc4

2019-06-07 Thread Ard Biesheuvel
The mac80211 WEP code uses the cipher interface, and invokes it byte by byte. This is rather inefficient, and since the cipher interface in general is not really suitable for use outside of the crypto subsystem, move this code to use the skcipher interface instead. Given that the only driver that

[RFC PATCH 2/3] lib80211/tkip: switch to skcipher interface for arc4

2019-06-07 Thread Ard Biesheuvel
The TKIP code uses the arc4 cipher interface, and invokes it byte by byte. This is rather inefficient, and since the cipher interface in general is not really suitable for use outside of the crypto subsystem, move this code to use the skcipher interface instead. Given that the only driver that pro

Re: [PATCH 0/3] Add support for Graviton TRNG

2019-06-07 Thread Saidi, Ali
On 6/5/19, 7:20 AM, "Will Deacon" wrote: On Tue, Jun 04, 2019 at 08:30:57PM +, Ali Saidi wrote: > AWS Graviton based systems provide an Arm SMC call in the vendor defined > hypervisor region to read random numbers from a HW TRNG and return them to the > guest. >