Re: Question regarding crypto scatterlists / testmgr

2019-04-17 Thread Herbert Xu
On Wed, Apr 17, 2019 at 08:29:59PM -0700, Ard Biesheuvel wrote: > > Seems like I was misreading the code: we have the following code in > skcipher_walk_next > > if (!err && (walk->flags & SKCIPHER_WALK_PHYS)) { > walk->src.phys.page = virt_to_page(walk->src.virt.addr); > walk->dst.phys.pag

Re: Question regarding crypto scatterlists / testmgr

2019-04-17 Thread Ard Biesheuvel
On Wed, 17 Apr 2019 at 20:16, Pascal Van Leeuwen wrote: > > > -Original Message- > > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > > Sent: Wednesday, April 17, 2019 11:43 PM > > To: Pascal Van Leeuwen > > Cc: Eric Biggers ; linux-crypto@vger.kernel.org; > > Herbert Xu > > Sub

RE: Question regarding crypto scatterlists / testmgr

2019-04-17 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, April 17, 2019 11:43 PM > To: Pascal Van Leeuwen > Cc: Eric Biggers ; linux-crypto@vger.kernel.org; > Herbert Xu > Subject: Re: Question regarding crypto scatterlists / testmgr > > On Wed, 17

RE: Question regarding crypto scatterlists / testmgr

2019-04-17 Thread Pascal Van Leeuwen
> -Original Message- > From: Eric Biggers [mailto:ebigg...@kernel.org] > Sent: Wednesday, April 17, 2019 11:43 PM > To: Pascal Van Leeuwen > Cc: linux-crypto@vger.kernel.org; Herbert Xu > > Subject: Re: Question regarding crypto scatterlists / testmgr > > Hi Pascal, > > On Wed, Apr 17, 20

Re: Question regarding crypto scatterlists / testmgr

2019-04-17 Thread Ard Biesheuvel
On Wed, 17 Apr 2019 at 14:17, Pascal Van Leeuwen wrote: > > > -Original Message- > > From: Eric Biggers [mailto:ebigg...@kernel.org] > > Sent: Wednesday, April 17, 2019 10:24 PM > > To: Pascal Van Leeuwen > > Cc: linux-crypto@vger.kernel.org; Herbert Xu > > > > Subject: Re: Question rega

Re: Question regarding crypto scatterlists / testmgr

2019-04-17 Thread Eric Biggers
Hi Pascal, On Wed, Apr 17, 2019 at 09:16:54PM +, Pascal Van Leeuwen wrote: > > -Original Message- > > From: Eric Biggers [mailto:ebigg...@kernel.org] > > Sent: Wednesday, April 17, 2019 10:24 PM > > To: Pascal Van Leeuwen > > Cc: linux-crypto@vger.kernel.org; Herbert Xu > > > > Subje

RE: Question regarding crypto scatterlists / testmgr

2019-04-17 Thread Pascal Van Leeuwen
> > Indeed, since v5.1, testmgr tests scatterlist elements that cross a > > page. > > However, the pages are guaranteed to be *physically* contiguous. > Does > > dma_map_sg() not handle this? > > > I'm not entirely sure and the API documentation is not particularly > clear on *what* dma_map_sg() ac

RE: Question regarding crypto scatterlists / testmgr

2019-04-17 Thread Pascal Van Leeuwen
> -Original Message- > From: Eric Biggers [mailto:ebigg...@kernel.org] > Sent: Wednesday, April 17, 2019 10:24 PM > To: Pascal Van Leeuwen > Cc: linux-crypto@vger.kernel.org; Herbert Xu > > Subject: Re: Question regarding crypto scatterlists / testmgr > > Hi Pascal, > > On Wed, Apr 17, 20

Re: Question regarding crypto scatterlists / testmgr

2019-04-17 Thread Ard Biesheuvel
On Wed, 17 Apr 2019 at 13:49, Pascal Van Leeuwen wrote: > > > > I'm trying to fix the inside-secure driver to pass all testmgr > > > tests and I have one final issue remaining with the AEAD ciphers. > > > As it was not clear at all what the exact problem was, I spent > > > some time reverse engine

RE: Question regarding crypto scatterlists / testmgr

2019-04-17 Thread Pascal Van Leeuwen
> > I'm trying to fix the inside-secure driver to pass all testmgr > > tests and I have one final issue remaining with the AEAD ciphers. > > As it was not clear at all what the exact problem was, I spent > > some time reverse engineering testmgr and I got the distinct > > impression that it is usin

Re: Question regarding crypto scatterlists / testmgr

2019-04-17 Thread Eric Biggers
Hi Pascal, On Wed, Apr 17, 2019 at 07:51:08PM +, Pascal Van Leeuwen wrote: > Hi, > > I'm trying to fix the inside-secure driver to pass all testmgr > tests and I have one final issue remaining with the AEAD ciphers. > As it was not clear at all what the exact problem was, I spent > some time

Re: Question regarding crypto scatterlists / testmgr

2019-04-17 Thread Ard Biesheuvel
On Wed, 17 Apr 2019 at 12:51, Pascal Van Leeuwen wrote: > > Hi, > > I'm trying to fix the inside-secure driver to pass all testmgr > tests and I have one final issue remaining with the AEAD ciphers. > As it was not clear at all what the exact problem was, I spent > some time reverse engineering te

Question regarding crypto scatterlists / testmgr

2019-04-17 Thread Pascal Van Leeuwen
Hi, I'm trying to fix the inside-secure driver to pass all testmgr tests and I have one final issue remaining with the AEAD ciphers. As it was not clear at all what the exact problem was, I spent some time reverse engineering testmgr and I got the distinct impression that it is using scatter parti

Re: [PATCH] crypto: caam/jr - update gcm detection logic

2019-04-17 Thread Iuliana Prodan
On 4/16/2019 7:27 PM, Horia Geantă wrote: > GCM detection logic has to change for two reasons: > -some CAAM instantiations with Era < 10, even though they have AES LP, > they now support GCM mode > -Era 10 upwards, there is a dedicated bit in AESA_VERSION[AESA_MISC] > field for GCM support > > For