Re: [RFC/RFT PATCH 00/18] crypto: fuzz algorithms against their generic implementation

2019-04-07 Thread Herbert Xu
Eric Biggers wrote: > > As usual, the series begins with fixes for the bugs found, roughly in > order of decreasing importance. Please consider sending the Poly1305 > fix to Linus soon. I have applied patches 1-3, 5-6, 9-11. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~

Re: [PATCH] crypto: testmgr - add panic_on_fail module parameter

2019-04-07 Thread Herbert Xu
On Sun, Mar 31, 2019 at 01:09:14PM -0700, Eric Biggers wrote: > From: Eric Biggers > > Add a module parameter cryptomgr.panic_on_fail which causes the kernel > to panic if any crypto self-tests fail. > > Use cases: > > - More easily detect crypto self-test failures by boot testing, > e.g. on

Re: [PATCH 1/2] crypto: scompress: return proper error code for allocation failure

2019-04-07 Thread Herbert Xu
On Fri, Mar 29, 2019 at 02:09:55PM +0100, Sebastian Andrzej Siewior wrote: > If scomp_acomp_comp_decomp() fails to allocate memory for the > destination then we never copy back the data we compressed. > It is probably best to return an error code instead 0 in case of > failure. > I haven't found an

Re: [PATCH -next] crypto: ccp - Use kmemdup in ccp_copy_and_save_keypart()

2019-04-07 Thread Herbert Xu
On Sat, Mar 30, 2019 at 01:43:16AM +, YueHaibing wrote: > Use kmemdup rather than duplicating its implementation > > Signed-off-by: YueHaibing > --- > drivers/crypto/ccp/ccp-crypto-rsa.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu

Re: [PATCH] crypto: Use ___cacheline_aligned for aes data

2019-04-07 Thread Herbert Xu
On Fri, Mar 29, 2019 at 05:46:29PM -0700, Andi Kleen wrote: > From: Andi Kleen > > cacheline_aligned is a special section. It cannot be const at the same > time because it's not read-only. It doesn't give any MMU protection. > > Mark it cacheline_aligned to not place it in a special section,

Re: [PATCH] crypto: caam/qi - Change a couple IS_ERR_OR_NULL() checks to IS_ERR()

2019-04-07 Thread Herbert Xu
On Thu, Mar 28, 2019 at 05:36:01PM +0300, Dan Carpenter wrote: > create_caam_req_fq() doesn't return NULL pointers so there is no need to > check. The NULL checks are problematic because it's hard to say how a > NULL return should be handled, so removing the checks is a nice cleanup. > > Signed-o

Hello Beautiful

2019-04-07 Thread Jack
Hi Dear, my name is Jack and i am seeking for a relationship in which i will feel loved after a series of failed relationships. I am hoping that you would be interested and we could possibly get to know each other more if you do not mind. I am open to answering questions from you as i think my

Re: [RFC/RFT PATCH 04/18] crypto: skcipher - restore default skcipher_walk::iv on error

2019-04-07 Thread Herbert Xu
Eric Biggers wrote: > From: Eric Biggers > > When the user-provided IV buffer is not aligned to the algorithm's > alignmask, skcipher_walk_virt() allocates an aligned buffer and copies > the IV into it. However, skcipher_walk_virt() can fail after that > point, and in this case the buffer will

Re: [Bug] Rockchip crypto driver sometimes produces wrong ciphertext

2019-04-07 Thread Herbert Xu
On Sun, Apr 07, 2019 at 07:12:43PM +, Pascal Van Leeuwen wrote: > > Then where is this specified? Because I read through all the Kernel Crypto > API documentation multiple times, but I have not been able to find ANY > reference to any output IV being stored anywhere. > Yes, I can infer from the

Re: [RFC/RFT PATCH 18/18] crypto: run initcalls for generic implementations earlier

2019-04-07 Thread Herbert Xu
Hi Eric: Eric Biggers wrote: > From: Eric Biggers > > Use subsys_initcall for registration of all templates and generic > algorithm implementations, rather than module_init. I think this is fine except that algboss already hooks in at subsys_initcall and either it needs to move further up or w

RE: [Bug] Rockchip crypto driver sometimes produces wrong ciphertext

2019-04-07 Thread Pascal Van Leeuwen
> > Herbert, can you explain what users actually rely on the next IV being > returned? > > I don't know all the historical context behind this. > > Chaining by reusing the output IV has always been part of the API. > Then where is this specified? Because I read through all the Kernel Crypto API doc

Re: [Bug] Rockchip crypto driver sometimes produces wrong ciphertext

2019-04-07 Thread Herbert Xu
On Thu, Apr 04, 2019 at 10:12:05AM -0700, Eric Biggers wrote: > > Herbert, can you explain what users actually rely on the next IV being > returned? > I don't know all the historical context behind this. Chaining by reusing the output IV has always been part of the API. However, we never tested i