Re: [PATCH v3 0/3] CAAM job ring driver cleanups

2019-03-21 Thread Horia Geanta
On 3/22/2019 4:00 AM, Vakul Garg wrote: > This patchset cleans up caam job ring driver. > The patch series needs to be applied after merging below mentioned > patch. > > https://www.mail-archive.com/linux-crypto@vger.kernel.org/msg37068.html > For the series: Reviewed-by: Horia Geantă Thanks, H

[PATCH v3 3/3] crypto: caam/jr - Remove extra memory barrier during job ring enqueue

2019-03-21 Thread Vakul Garg
In caam_jr_enqueue(), a write barrier is needed to order stores to job ring slot before declaring addition of new job into input job ring. The register write is done using wr_reg32() which internally uses iowrite32() for write operation. The api iowrite32() issues a write barrier before issuing wri

[PATCH v3 0/3] CAAM job ring driver cleanups

2019-03-21 Thread Vakul Garg
This patchset cleans up caam job ring driver. The patch series needs to be applied after merging below mentioned patch. https://www.mail-archive.com/linux-crypto@vger.kernel.org/msg37068.html Vakul Garg (3): crypto: caam/jr - Remove spinlock for output job ring crypto: caam/jr - Removed red

[PATCH v3 1/3] crypto: caam/jr - Remove spinlock for output job ring

2019-03-21 Thread Vakul Garg
For each job ring pair, the output ring is processed exactly by one cpu at a time under a tasklet context (one per ring). Therefore, there is no need to protect a job ring's access & its private data structure using a lock. Hence the lock can be removed. Signed-off-by: Vakul Garg Reviewed-by: Hor

[PATCH v3 2/3] crypto: caam/jr - Removed redundant vars from job ring private data

2019-03-21 Thread Vakul Garg
For each job ring, the variable 'ringsize' is initialised but never used. Similarly variables 'inp_ring_write_index' and 'head' always track the same value and instead of 'inp_ring_write_index', caam_jr_enqueue() can use 'head' itself. Both these variables have been removed. Signed-off-by: Vakul G

PRIVATE...

2019-03-21 Thread daniele
I have a business Proposal that will be of benefit to the both of us.Kindly contact me on mrmichealwu...@yahoo.com.hk should this be of interest to you.

[RFC PATCH] crypto: chtls - handle inet_csk_reqsk_queue_add() failures

2019-03-21 Thread Guillaume Nault
While working on 9d3e1368bb45 ("tcp: handle inet_csk_reqsk_queue_add() failures"), I missed this usage of inet_csk_reqsk_queue_add(). inet_csk_reqsk_queue_add() can fail. In that case, the operation is aborted and inet_csk_destroy_sock() is called automatically, but we need to free the request soc

Re: [Bug] Rockchip crypto driver sometimes produces wrong ciphertext

2019-03-21 Thread Gael PORTAY
Hello, On 3/18/19 11:03 AM, Gael PORTAY wrote: Hello, On 3/16/19 6:31 PM, Ezequiel Garcia wrote: Adding my colleague Gael, who has been working on fixing this driver. I have a couple of pending commits that may fix that issue. I will give it a try, and get back to you then. The patches I

Re: [PATCH v2 1/3] crypto: caam/jr - Remove spinlock for output job ring

2019-03-21 Thread Horia Geanta
On 3/15/2019 1:25 PM, Vakul Garg wrote: > For each job ring pair, the output ring is processed exactly by one cpu > at a time under a tasklet context (one per ring). Therefore, there is no > need to protect a job ring's access & its private data structure using a > lock. Hence the lock can be remov

Re: [PATCH v2 2/3] crypto: caam/jr - Removed redundant vars from job ring private data

2019-03-21 Thread Horia Geanta
On 3/15/2019 1:25 PM, Vakul Garg wrote: > For each job ring, the variable 'ringsize' is initialised but never > used. Similarly variables 'inp_ring_read_index' and 'head' always track > the same value and instead of 'inp_ring_read_index', caam_jr_enqueue() > can use 'head' itself. Both these variab

Re: [Bug] STM32 crc driver failed on selftest 1

2019-03-21 Thread Eric Biggers
On Thu, Mar 21, 2019 at 10:46:53AM +, Lionel DEBIEVE wrote: > Hi All, > > I'm looking further to debug an issue regarding CRC32 selftests. I'm > currently blocked on an issue about the second test vector implemented > on CRC32: > static const struct hash_testvec crc32_tv_template[] = { >   

Re: [PATCH v2 3/3] crypto: caam/jr - Remove extra memory barrier during job ring enqueue

2019-03-21 Thread Horia Geanta
On 3/15/2019 1:25 PM, Vakul Garg wrote: > In caam_jr_enqueue(), a write barrier is needed to order stores to job > ring slot before declaring addition of new job into input job ring. > The register write is done using wr_reg32() which internally uses > iowrite32() for write operation. The api iowri

[Bug] STM32 crc driver failed on selftest 1

2019-03-21 Thread Lionel DEBIEVE
Hi All, I'm looking further to debug an issue regarding CRC32 selftests. I'm currently blocked on an issue about the second test vector implemented on CRC32: static const struct hash_testvec crc32_tv_template[] = {     {         .plaintext = "abcdefg",         .psize = 7,         .digest =

MASSAGE FROM Ms Safi>> Reply

2019-03-21 Thread Ms Safi Kabore
Dear Friend, I am Ms Safi Kabore work with the department of Audit and accounting manager here in the Bank, There is this fund that was keep in my custody years ago,please i need your assistance for the transferring of thIs fund to your bank account for both of us benefit for life time inv