Re: [PATCH] crypto: ccp: introduce SEV_GET_ID2 command

2019-02-21 Thread Herbert Xu
On Thu, Feb 14, 2019 at 07:33:29PM +, Singh, Brijesh wrote: > > > On 2/14/19 10:57 AM, Nathaniel McCallum wrote: > > I'm a little concerned that this immediately disables SEV_GET_ID. > > IMHO, we should continue to support both for a period of time. One > > justification for immediate disable

Re: [RFC PATCH v3 07/18] fscrypt: add FS_IOC_ADD_ENCRYPTION_KEY ioctl

2019-02-21 Thread Eric Biggers
On Thu, Feb 21, 2019 at 10:33:12AM +0100, Richard Weinberger wrote: > Eric, > > Am Donnerstag, 21. Februar 2019, 06:49:39 CET schrieb Eric Biggers: > > Hi Richard, > > > > On Thu, Feb 21, 2019 at 12:52:38AM +0100, Richard Weinberger wrote: > > > On Wed, Feb 20, 2019 at 7:55 AM Eric Biggers wrote

[PATCH] crypto: af_alg - use struct_size() in sock_kfree_s()

2019-02-21 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes, in particular in the context in which this code is being used. So, change the following form: sizeof(*sgl) + sizeof(sgl->sg[0]) * (MAX_SGL_ENTS + 1) to : struct_size(sgl, sg, MAX

Re: [RFC PATCH v3 07/18] fscrypt: add FS_IOC_ADD_ENCRYPTION_KEY ioctl

2019-02-21 Thread Richard Weinberger
Eric, Am Donnerstag, 21. Februar 2019, 06:49:39 CET schrieb Eric Biggers: > Hi Richard, > > On Thu, Feb 21, 2019 at 12:52:38AM +0100, Richard Weinberger wrote: > > On Wed, Feb 20, 2019 at 7:55 AM Eric Biggers wrote: > > > +#define FSCRYPT_FS_KEYRING_DESCRIPTION_SIZE\ > > > + (CONST_STR