Re: [PATCH v5 4/4] hwrng: add OP-TEE based rng driver

2019-01-27 Thread Sumit Garg
Hi Herbert, On Thu, 24 Jan 2019 at 11:25, Sumit Garg wrote: > > On ARM SoC's with TrustZone enabled, peripherals like entropy sources > might not be accessible to normal world (linux in this case) and rather > accessible to secure world (OP-TEE in this case) only. So this driver > aims to provide

Re: [Bug] Rockchip crypto driver sometimes produces wrong ciphertext

2019-01-27 Thread Tao Huang
Hi Eric and Heiko: >> On Sat, 26 Jan 2019 at 22:05, Eric Biggers wrote: >>> >>> Hello, >>> >>> I don't know whether anyone is actually maintaining the Rockchip crypto >>> driver >>> in drivers/crypto/rockchip/, but it's failing the improved crypto tests >>> that I currently have out for review:

Re: [Bug] Rockchip crypto driver sometimes produces wrong ciphertext

2019-01-27 Thread Heiko Stuebner
(also add Ezequiel who has spent a bit of time on the rockchip crypto driver recently) Am Sonntag, 27. Januar 2019, 09:54:54 CET schrieb Ard Biesheuvel: > (add LAKML and arm-soc maintainers) > > On Sat, 26 Jan 2019 at 22:05, Eric Biggers wrote: > > > > Hello, > > > > I don't know whether anyone

[PATCH v3 4/4] crypto: arm64/crct10dif - remove dead code

2019-01-27 Thread Ard Biesheuvel
Remove some code that is no longer called now that we make sure never to invoke the SIMD routine with less than 16 bytes of input. Reviewed-by: Eric Biggers Signed-off-by: Ard Biesheuvel --- arch/arm64/crypto/crct10dif-ce-core.S | 11 --- 1 file changed, 11 deletions(-) diff --git a/ar

[PATCH v3 3/4] crypto: arm/crct10dif - remove dead code

2019-01-27 Thread Ard Biesheuvel
Remove some code that is no longer called now that we make sure never to invoke the SIMD routine with less that 16 bytes of input. Reviewed-by: Eric Biggers Signed-off-by: Ard Biesheuvel --- arch/arm/crypto/crct10dif-ce-core.S | 13 - 1 file changed, 13 deletions(-) diff --git a/ar

[PATCH v3 1/4] crypto: arm/crct10dif - revert to C code for short inputs

2019-01-27 Thread Ard Biesheuvel
The SIMD routine ported from x86 used to have a special code path for inputs < 16 bytes, which got lost somewhere along the way. Instead, the current glue code aligns the input pointer to permit the NEON routine to use special versions of the vld1 instructions that assume 16 byte alignment, but thi

[PATCH v3 2/4] crypto: arm64/crct10dif - revert to C code for short inputs

2019-01-27 Thread Ard Biesheuvel
The SIMD routine ported from x86 used to have a special code path for inputs < 16 bytes, which got lost somewhere along the way. Instead, the current glue code aligns the input pointer to 16 bytes, which is not really necessary on this architecture (although it could be beneficial to performance to

[PATCH v3 0/4] crypto: fix crct10dif for ARM and arm64

2019-01-27 Thread Ard Biesheuvel
Fix the issues in both NEON implementations of the CRC-T10DIF routines, that were reported by Eric's new testing code. v3: - fix commit log to state 'at least 16 bytes' not 'more than 16 bytes' (#1-#2) - add Eric's R-b to all patches v2: - keep alignment specifiers where possible (#1) - clarify/f

Re: [PATCH v2 0/4] crypto: fix crct10dif for ARM and arm64

2019-01-27 Thread Ard Biesheuvel
On Sun, 27 Jan 2019 at 01:07, Eric Biggers wrote: > > On Fri, Jan 25, 2019 at 09:49:11AM +0100, Ard Biesheuvel wrote: > > Fix the issues in both NEON implementations of the CRC-T10DIF routines, > > that were reported by Eric's new testing code. > > > > v2: > > - keep alignment specifiers where pos

Re: [Bug] Rockchip crypto driver sometimes produces wrong ciphertext

2019-01-27 Thread Ard Biesheuvel
(add LAKML and arm-soc maintainers) On Sat, 26 Jan 2019 at 22:05, Eric Biggers wrote: > > Hello, > > I don't know whether anyone is actually maintaining the Rockchip crypto driver > in drivers/crypto/rockchip/, but it's failing the improved crypto tests > that I currently have out for review: >