[PATCH] padata: clean an indentation issue, remove extraneous space

2018-11-09 Thread Colin King
From: Colin Ian King Trivial fix to clean up an indentation issue Signed-off-by: Colin Ian King --- kernel/padata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/padata.c b/kernel/padata.c index d568cc56405f..3e2633ae3bca 100644 --- a/kernel/padata.c +++ b/kernel/p

How driver can mark the algo implementation Unavailable

2018-11-09 Thread Harsh Jain
Hi All, PCI based devices can be shutdown from sysfs interface echo "unbind" > /sys/bus/pci/drivers/cxgb4/unbind In case device has active Transformation(tfm), Drivers cannot un-register the Algorithms because alg->cra_refcnt will be non zero. Can driver use the "CRYPTO_ALG_DEAD" flag to mark

Re: [PATCH] crypto: chelsio: clean up various indentation issues

2018-11-09 Thread Herbert Xu
On Tue, Oct 30, 2018 at 12:01:58PM +, Colin King wrote: > From: Colin Ian King > > Trivial fix to clean up varous indentation issue > > Signed-off-by: Colin Ian King > --- > drivers/crypto/chelsio/chcr_algo.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) Patch a

Re: [PATCH] crypto: mark cts(cbc(aes)) as FIPS allowed

2018-11-09 Thread Herbert Xu
On Sun, Nov 04, 2018 at 10:05:24AM +, Gilad Ben-Yossef wrote: > As per Sp800-38A addendum from Oct 2010[1], cts(cbc(aes)) is > allowed as a FIPS mode algorithm. Mark it as such. > > [1] https://csrc.nist.gov/publications/detail/sp/800-38a/addendum/final > > Signed-off-by: Gilad Ben-Yossef >

Re: [PATCH] pcrypt: use format specifier in kobject_add

2018-11-09 Thread Herbert Xu
On Sat, Oct 27, 2018 at 03:49:26PM +0100, Colin King wrote: > From: Colin Ian King > > Passing string 'name' as the format specifier is potentially hazardous > because name could (although very unlikely to) have a format specifier > embedded in it causing issues when parsing the non-existent argu

Re: [PATCH 1/2] crypto: fix cfb mode decryption

2018-11-09 Thread Herbert Xu
On Sat, Oct 20, 2018 at 02:01:52AM +0300, Dmitry Eremin-Solenikov wrote: > crypto_cfb_decrypt_segment() incorrectly XOR'ed generated keystream with > IV, rather than with data stream, resulting in incorrect decryption. > Test vectors will be added in the next patch. > > Signed-off-by: Dmitry Eremi

Re: [PATCH] crypto: cavium/nitrox - fix a DMA pool free failure

2018-11-09 Thread Herbert Xu
On Thu, Oct 18, 2018 at 07:50:43PM -0500, Wenwen Wang wrote: > In crypto_alloc_context(), a DMA pool is allocated through dma_pool_alloc() > to hold the crypto context. The meta data of the DMA pool, including the > pool used for the allocation 'ndev->ctx_pool' and the base address of the > DMA poo

Re: [PATCH 0/3] crypto: ccree: add SM3 support

2018-11-09 Thread Herbert Xu
On Thu, Oct 18, 2018 at 01:59:56PM +0100, Yael Chemla wrote: > Add support for SM3 in CryptoCell 713. > > Yael Chemla (3): > crypto: ccree: adjust hash length to suit certain context specifics > crypto: ccree: modify set_cipher_mode usage from cc_hash > crypto: ccree: add SM3 support > >

Re: [PATCH v2 0/3] crypto: ccree: add CryptoCell 713 baseline support

2018-11-09 Thread Herbert Xu
On Mon, Oct 29, 2018 at 09:50:11AM +, Gilad Ben-Yossef wrote: > Add first batch of patches for support of Arm TrustZone CryptoCell 713. > > Changes from v1: > - Format dt bindings document one version per line and correct the heading > as indicated by Rob Herring. > > Gilad Ben-Yossef (3):

Re: [PATCH v3 0/2] crypto: some hardening against AES cache-timing attacks

2018-11-09 Thread Herbert Xu
On Wed, Oct 17, 2018 at 09:37:57PM -0700, Eric Biggers wrote: > This series makes the "aes-fixed-time" and "aes-arm" implementations of > AES more resistant to cache-timing attacks. > > Note that even after these changes, the implementations still aren't > necessarily guaranteed to be constant-tim

Re: [PATCH 0/4] crypto: crypto_user reporting fixes and cleanups

2018-11-09 Thread Herbert Xu
On Sat, Nov 03, 2018 at 02:55:59PM -0700, Eric Biggers wrote: > This series fixes all the information leaks in crypto_user reporting, > removes some redundant reporting functions, and makes some changes to > reduce the chance of similar information leaks in the future. Patch 2 > is based on a patc

Re: [PATCH] crypto/simd: correctly take reqsize of wrapped skcipher into account

2018-11-09 Thread Ard Biesheuvel
On 9 November 2018 at 10:45, Herbert Xu wrote: > On Fri, Nov 09, 2018 at 05:44:47PM +0800, Herbert Xu wrote: >> On Fri, Nov 09, 2018 at 12:33:23AM +0100, Ard Biesheuvel wrote: >> > >> > This should be >> > >> > reqsize += max(crypto_skcipher_reqsize(&cryptd_tfm->base); >> >crypto_skcipher_

Re: [PATCH] crypto/simd: correctly take reqsize of wrapped skcipher into account

2018-11-09 Thread Herbert Xu
On Fri, Nov 09, 2018 at 05:44:47PM +0800, Herbert Xu wrote: > On Fri, Nov 09, 2018 at 12:33:23AM +0100, Ard Biesheuvel wrote: > > > > This should be > > > > reqsize += max(crypto_skcipher_reqsize(&cryptd_tfm->base); > >crypto_skcipher_reqsize(cryptd_skcipher_child(cryptd_tfm))); > > > > s

Re: [PATCH] crypto/simd: correctly take reqsize of wrapped skcipher into account

2018-11-09 Thread Herbert Xu
On Fri, Nov 09, 2018 at 12:33:23AM +0100, Ard Biesheuvel wrote: > > This should be > > reqsize += max(crypto_skcipher_reqsize(&cryptd_tfm->base); >crypto_skcipher_reqsize(cryptd_skcipher_child(cryptd_tfm))); > > since the cryptd path in simd still needs some space in the subreq for > the

Re: [PATCH 0/2] crypto: hisilicon - A couple of fixes

2018-11-09 Thread Herbert Xu
On Mon, Nov 05, 2018 at 08:35:13PM +0800, John Garry wrote: > This patchset fixes a couple of issues I discovered while attempting to > bringup the driver. > > John Garry (2): > crypto: hisilicon - Fix NULL dereference for same dst and src > crypto: hisilicon - Fix reference after free of me